fix users handle endpoint.

as it turns out python would return an array here.

Author: stereosteve

api/resolve_middleware.go

@@ -35,7 +35,7 @@ func (app *ApiServer) requireHandleMiddleware(c *fiber.Ctx) error {
 	if err != nil {
 		return err
 	}
-	c.Locals("userId", userId)
+	c.Locals("userId", int(userId))
 	return c.Next()
 }
 

api/server.go

@@ -126,6 +126,7 @@ func NewApiServer(config Config) *ApiServer {
 		g.Get("/users", app.v1Users)
 
 		g.Use("/users/handle/:handle", app.requireHandleMiddleware)
+		g.Get("/users/handle/:handle", app.v1User)
 		g.Get("/users/handle/:handle/tracks", app.v1UserTracks)
 		g.Get("/users/handle/:handle/reposts", app.v1UsersReposts)
 

api/server_test.go

@@ -92,6 +92,7 @@ func Test200(t *testing.T) {
 		"/v1/full/users/7eP5n/supporting",
 		"/v1/full/users/7eP5n/tracks",
 
+		"/v1/full/users/handle/rayjacobson",
 		"/v1/full/users/handle/rayjacobson/tracks",
 		"/v1/full/users/handle/rayjacobson/reposts",
 

api/v1_user.go

@@ -22,7 +22,5 @@ func (app *ApiServer) v1User(c *fiber.Ctx) error {
 		return sendError(c, 404, "user not found")
 	}
 
-	user := users[0]
-
-	return v1UserResponse(c, user)
+	return v1UsersResponse(c, users)
 }

api/v1_user_test.go

@@ -10,7 +10,7 @@ import (
 
 func TestGetUser(t *testing.T) {
 	var userResponse struct {
-		Data dbv1.FullUser
+		Data []dbv1.FullUser
 	}
 
 	status, body := testGet(t, "/v1/full/users/7eP5n", &userResponse)
@@ -23,5 +23,5 @@ func TestGetUser(t *testing.T) {
 
 	// but we also unmarshaled into userResponse
 	// for structured testing
-	assert.Equal(t, userResponse.Data.ID, "7eP5n")
+	assert.Equal(t, userResponse.Data[0].ID, "7eP5n")
 }

apidiff.ts

@@ -10,6 +10,10 @@ const testPaths = [
   "/v1/users/0EoAm",
   "/v1/full/users?id=invalid_id1&id=aNzoj",
 
+  "/v1/full/users/handle/stereosteve",
+
+  "/v1/full/tracks/ZaXp01y",
+
   "/v1/full/tracks?id=ZaXp01y&user_id=aNzoj",
   "/v1/full/tracks?id=ZaXp01y&user_id=7eP5n",
   "/v1/full/tracks?id=ZaXp01y&id=5zdbywJ&id=Pb4MbAX&id=YVog04p&id=7Mv7ZMP&id=g5yzMy2&id=P7dlqNR&id=RR7krAG&id=O7OdxYV&id=72oXyvr&id=jYWyGG0&id=W6KOm8k&id=Xj554dq&id=gbOmq7k&id=G0z4Ap7&id=Yo0XYMm&id=80jlRwP&id=X63z9Wq&id=lZYWRKb&id=JEz6V0o&id=JZq6550&id=b9rbNdM&id=yy71xr7&id=JGNob5Z&id=VpxQ2Aa&id=qGbEZdz&id=B94qO0j&id=oRGgBka&id=jzwlVj0&id=Y5PNmOr&id=5zRm7dx&id=r3KjOg&id=WVP8qav&id=Nvayj1Y&id=V6GZJ3b&id=YoWO0MJ&id=JboVK8Y&id=9bbRG02&id=QRgjAJR&id=gWaBbkW&id=79q1xY7&id=51o1r9J&id=AMJ7d3k&id=O6ZKK0V&id=RpVzBx1&id=VPdaGdQ&id=lv7Obol&id=GQpBNxw&id=83xb96v&id=BJoM2Qx&id=bQoMKlK&id=8E1QjMW&id=O5OVlK4&id=63Gz0yQ&user_id=aNzoj",
@@ -65,14 +69,17 @@ import * as jsondiffpatch from "https://esm.sh/jsondiffpatch@0.6.0";
 import * as htmlFormatter from "https://esm.sh/jsondiffpatch@0.6.0/formatters/html";
 
 Deno.serve({ port: 62185 }, async (req) => {
+  const oldHost = "https://discoveryprovider.audius.co";
+  const newHost = "http://localhost:1323";
+
   const reqUrl = new URL(req.url);
   const idx = parseInt(reqUrl.searchParams.get("idx") || "0");
   const path = testPaths[idx];
   if (!path || path == "/favicon.ico") return new Response("not found");
 
   const [r1, r2] = await Promise.all([
-    fetchJson("https://discoveryprovider.audius.co" + path),
-    fetchJson("http://localhost:1323" + path),
+    fetchJson(oldHost + path),
+    fetchJson(newHost + path),
   ]);
 
   const json1 = r1.data;
@@ -99,7 +106,7 @@ Deno.serve({ port: 62185 }, async (req) => {
           <style>
             del {
               background: #ffbbbb;
-              text-decoration: line-through;
+              text-decoration: none;
             }
             ins {
               background: #bbffbb;
@@ -125,8 +132,12 @@ Deno.serve({ port: 62185 }, async (req) => {
 
           <pre>${path}</pre>
           <div>
-            <del>${r1.took}ms</del>
-            <ins>${r2.took}ms</ins>
+            <a href="${oldHost + path}" target="_blank">
+              <del>${r1.took}ms</del>
+            </a>
+            <a href="${newHost + path}" target="_blank">
+              <ins>${r2.took}ms</ins>
+            </a>
           </div>
           <div>${htmlFormatter.format(delta, json1)}</div>
         </body>