Skip to content

Commit d61fbe4

Browse files
committed
pr feedback
1 parent 56dab68 commit d61fbe4

2 files changed

Lines changed: 23 additions & 26 deletions

File tree

api/dbv1/queries/get_account_playlists.sql

Lines changed: 22 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,28 @@ WITH saved_playlists AS (
77
AND is_delete = FALSE
88
AND (save_type = 'playlist' OR save_type = 'album')
99
)
10-
SELECT * FROM (
11-
SELECT DISTINCT ON (p.playlist_id)
12-
p.playlist_id,
13-
p.is_album,
14-
-- p.permalink // TODO
15-
p.playlist_name,
16-
u.user_id,
17-
u.handle,
18-
u.is_deactivated,
19-
p.created_at
20-
FROM playlists p
21-
JOIN users u ON p.playlist_owner_id = u.user_id
22-
WHERE (
23-
-- Owned playlists
24-
(p.is_current = TRUE
25-
AND p.is_delete = FALSE
26-
AND p.playlist_owner_id = @user_id)
10+
SELECT
11+
p.playlist_id,
12+
p.is_album,
13+
-- p.permalink // TODO
14+
p.playlist_name,
15+
u.user_id,
16+
u.handle,
17+
u.is_deactivated,
18+
p.created_at
19+
FROM playlists p
20+
JOIN users u ON p.playlist_owner_id = u.user_id
21+
WHERE (
22+
-- Owned playlists
23+
(p.is_current = TRUE
24+
AND p.is_delete = FALSE
25+
AND p.playlist_owner_id = @user_id)
2726

28-
OR
27+
OR
2928

30-
-- Saved playlists
31-
(p.is_current = TRUE
32-
AND p.is_delete = FALSE
33-
AND p.playlist_id IN (SELECT save_item_id FROM saved_playlists))
34-
)
35-
ORDER BY p.playlist_id
36-
) subquery
29+
-- Saved playlists
30+
(p.is_current = TRUE
31+
AND p.is_delete = FALSE
32+
AND p.playlist_id IN (SELECT save_item_id FROM saved_playlists))
33+
)
3734
ORDER BY created_at DESC;

api/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func NewApiServer(config config.Config) *ApiServer {
124124
// Users
125125
g.Get("/users", app.v1Users)
126126

127-
g.Get("/users/account/:wallet", app.v1UsersAccount)
127+
g.Get("/users/account/:wallet", app.requiresAuthMiddleware, app.v1UsersAccount)
128128

129129
g.Use("/users/handle/:handle", app.requireHandleMiddleware)
130130
g.Get("/users/handle/:handle", app.v1User)

0 commit comments

Comments
 (0)