Rewards Part 1#34
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16559966 | Triggered | Generic High Entropy Secret | 985a4b2 | api/dbv1/media_link_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
raymondjacobson
left a comment
raymondjacobson
left a comment
There was a problem hiding this comment.
i'm impressed you were able to do this so easily!
| challenge_disbursements.challenge_id IS NULL | ||
| AND user_challenges.is_complete | ||
| AND user_challenges.user_id = @user_id | ||
| AND (@challenge_id::text = '' OR user_challenges.challenge_id = @challenge_id) |
There was a problem hiding this comment.
why is ::text necessary here?
There was a problem hiding this comment.
this made sure it typed as a string when autogenerating the model
| ag_text "github.com/gagliardetto/solana-go/text" | ||
| ) | ||
|
|
||
| var ProgramID = solana.MustPublicKeyFromBase58("CDpzvz7DfgbF95jSSCHLX3ERkugyfgn9Fw8ypNZ1hfXp") |
There was a problem hiding this comment.
should this be per environment? (stage / prod / etc )
There was a problem hiding this comment.
yeah - I'm imitating the other programs in solana-go - I'll have the program id change on init using the method
| @@ -0,0 +1,147 @@ | |||
| package secp256k1 | |||
2 participants
SubmitAttestationinstruction using Solana-Go primitivesgetUndisbursedChallengesqueryRewards is WIP, will add plenty of tests etc in future PRs. Have WIP endpoint but need to decouple some config values.
Probably easier to look at commit by commit?
Tested by successfully submitting an attestation on staging using the new endpoint wip