Skip to content

Derive User Banks, Add Solana Config#44

Merged
rickyrombo merged 4 commits intomainfrom
mjp-rewards-4
Apr 24, 2025
Merged

Derive User Banks, Add Solana Config#44
rickyrombo merged 4 commits intomainfrom
mjp-rewards-4

Conversation

@rickyrombo
Copy link
Copy Markdown
Contributor

  • adds support for deriving user banks
  • adds solana config as nested config
  • fixes default program ID for reward manager to be prod

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Apr 24, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2460750 Triggered Generic High Entropy Secret e29afeb config/solana_config.go View secret
16559966 Triggered Generic High Entropy Secret 1888a17 api/server_test.go View secret
2416685 Triggered Generic High Entropy Secret e29afeb config/solana_config.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread config/config.go
if os.Getenv("ENV") == "stage" {
switch env := os.Getenv("ENV"); env {
case "dev":
fallthrough
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cute

@rickyrombo rickyrombo merged commit 07aab14 into main Apr 24, 2025
2 checks passed
@raymondjacobson raymondjacobson deleted the mjp-rewards-4 branch April 24, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants