[API-75] Implement full requireAuthMiddleware#51
Merged
raymondjacobson merged 2 commits intomainfrom Apr 25, 2025
Merged
Conversation
schottra
reviewed
May 2, 2025
| panic(err) | ||
| } | ||
|
|
||
| resolveGrantCache, err := otter.MustBuilder[string, bool](50_000). |
Contributor
There was a problem hiding this comment.
Am I wrong or does this mean when you delete a grant we will take 10 minutes to stop honoring it for the manager/app in question?
Seems like that might create a concerning UX or folks who expect the revocation to be immediate.
| AND is_approved = true | ||
| AND is_revoked = false | ||
| ) | ||
| `, userId, authedWallet).Scan(&isAuthorized) |
Contributor
There was a problem hiding this comment.
Is this prone to any casing issues or did we fix that already?
| return c.Next() | ||
| } | ||
|
|
||
| if wallet != "" && wallet == authedWallet { |
Contributor
There was a problem hiding this comment.
Is this meant as a catch-all for endpoints that use a wallet param somewhere in their URL?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further implements requireAuthMiddleware to return appropriate 401 and 403 responses (including manager mode support)