Comments#56
Merged
stereosteve merged 6 commits intomainfrom Apr 29, 2025
Merged
Conversation
for better or worse... will probably split apart.
rickyrombo
approved these changes
Apr 29, 2025
raymondjacobson
approved these changes
Apr 29, 2025
| @@ -0,0 +1,3 @@ | |||
| comment_id,user_id,entity_id,text | |||
| func (app *ApiServer) v1TracksComments(c *fiber.Ctx) error { | ||
|
|
||
| sql := ` | ||
| SELECT comment_id as id |
Contributor
Author
There was a problem hiding this comment.
Yeah few reasons:
- Started in pgx land anyway so already had the code.
sqlcdoesn't seem to support type overrides for ad-hoc columns. So for things likementionsyou are stuck withjson.RawMessage.- there are a few fields like
IsDeletedandReplyIdsthat aren't in the json output. It's easy to addjson:"-"for those fields, which is easier than doing other struct embedding stuff.
In many ways it's similar to what sqlc does... but I just did it by hand. And there are some benefits to that.
| } | ||
|
|
||
| const oldHost = "https://discoveryprovider.audius.co"; | ||
| const oldHost = "https://discoveryprovider2.audius.co"; |
Contributor
Author
There was a problem hiding this comment.
DN1 was down atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
users/:id/commentsandtracks/:id/commentsunclaimed_idendpoints