Rewards: TransactionSender, RewardsManagerClient, and more

[rickyrombo]

• Creates RewardsManagerClient to encapsulate the given instance of the rewards program, and implement helpers to get marshalled account data.
• Creates TransactionSender to manage the sending of Solana transactions, as well as handle adding compute budget instructions. (Replaces solana relay for this feature!)
• Updates solana-go to get websockets support (required using a commit hash, there hasn't been a release yet)
• Updates spl programs to use common.Address for eth addresses
• Makes derive methods private again, now encapsulated as part of the RewardsManagerClient
• Normalizes the AAO and Validator attestations so that they're not treated differently when constructing the transaction
• Adds some better errors/wrapped errors for easier debugging etc.

Once I create ClaimableTokensClient in the future, can remove SolanaConfig from the api struct and just have it have services, much like SDK.

[raymondjacobson]

i wonder if this should be solanaTransactionSender/splTransactionSender. could get confusing when we do more relay-to-core stuff

[raymondjacobson]

i think "idiomatic" go would ask you to implement

func (e RewardManagerError) Error() string {
    return e.String()
}

and probably just call this Error instead of RewardManagerError

[rickyrombo]

oh interesting, like make this into an actual go error? I didn't think of that. maybe i should rename this to RewardManagerErrorCode instead then actually

[alecsavvy]

I think what you want is a collection of errors

var (
  ErrAlreadySent = errors.New("already sent")
  ...
)

and then you can compose if you want with errors.Join which allows you to do errors.Is(err, ErrAlreadySent) in a switch like this

[alecsavvy]

something like this

var (
	ErrIncorrectOwner             = errors.New("reward manager: incorrect owner")
	ErrSignCollision             = errors.New("reward manager: sign collision")
	ErrWrongSigner               = errors.New("reward manager: wrong signer")
	ErrNotEnoughSigners          = errors.New("reward manager: not enough signers")
	ErrSecp256InstructionMissing = errors.New("reward manager: secp256 instruction missing")
	ErrInstructionLoadError      = errors.New("reward manager: instruction load error")
	ErrRepeatedSenders           = errors.New("reward manager: repeated senders")
	ErrSignatureVerificationFailed = errors.New("reward manager: signature verification failed")
	ErrOperatorCollision         = errors.New("reward manager: operator collision")
	ErrAlreadySent               = errors.New("reward manager: already sent")
	ErrIncorrectMessages         = errors.New("reward manager: incorrect messages")
	ErrMessagesOverflow          = errors.New("reward manager: messages overflow")
	ErrMathOverflow              = errors.New("reward manager: math overflow")
	ErrInvalidRecipient          = errors.New("reward manager: invalid recipient")
)

then you could use it like this:

func SendReward() error {
	// something goes wrong
	return fmt.Errorf("failed to send reward: %w", rewardmanager.ErrAlreadySent)
}

if errors.Is(err, rewardmanager.ErrAlreadySent) {
fmt.Println("reward was already sent, skipping")
return
}

[rickyrombo]

No I actually need the numbers to map to the codes so I can decode the json I get back from the RPC. I think this would be nice, but separate from what I'm trying to do

[raymondjacobson]

should this just be the passed in ctx?

[rickyrombo]

idts - i want to be able to cancel the polling etc without canceling the parent context

[raymondjacobson]

nice

[raymondjacobson]

can we import this from the core stuff?

[raymondjacobson]

kinda nasty to marshal and unmarshal this - is that what they recommend?

[rickyrombo]

this seemed sensible to me, so that if it doesn't fit the expected structure it's still neatly stringified for logging. open to suggestions though

[raymondjacobson]

i don't love using this interface for AAO in addition to "validator node"

can we make a different struct for it?

perhaps we can rename Node to Validator (endpoint, delegateownerwallet, ownerwallet, isstoragedisabled) and Node (endpoint, address).

[rickyrombo]

I think everything can be a node, and what type of node is based on what list it's in. Validators are nodes in the validator list, AAOs are nodes in the AAO list. Maybe validator can have a separate struct though for the sake of IsStorageDisabled but I don't think it matters that much, especially given that's going away eventually