Rewards: Use core config to get amounts, refactor a bit to allow partial success#60
Merged
rickyrombo merged 3 commits intomainfrom May 1, 2025
Merged
Rewards: Use core config to get amounts, refactor a bit to allow partial success#60rickyrombo merged 3 commits intomainfrom
rickyrombo merged 3 commits intomainfrom
Conversation
Contributor
rickyrombo
commented
May 1, 2025
rickyrombo
commented
- get reward amounts from core config
- use a waitgroup instead of error group to allow for all the goroutines to finish and partially succeed
- use struct embedding to include handle/userBank in the claim struct
- change response structure to a list or challenges with their signatures or errors
raymondjacobson
approved these changes
May 1, 2025
| }, nil | ||
| } | ||
|
|
||
| func getReward(rewardId string, rewardsList []rewards.Reward) (rewards.Reward, error) { |
Member
There was a problem hiding this comment.
you could preload these into a map instead 🤷
Contributor
Author
There was a problem hiding this comment.
list small, should be fineee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.