Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions api/dbv1/full_managers.go

This file was deleted.

2 changes: 1 addition & 1 deletion api/dbv1/get_events.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 15 additions & 17 deletions api/dbv1/get_grants.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

92 changes: 92 additions & 0 deletions api/dbv1/managers.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
package dbv1

import (
"context"
)

type FullManagerGrant struct {
GetGrantsForUserIdRow
GranteeUserID *struct{} `json:"grantee_user_id,omitempty"`
}

type FullManagedUserGrant struct {
GetGrantsForGranteeUserIdRow
GranteeUserID *struct{} `json:"grantee_user_id,omitempty"`
}

type FullManager struct {
Manager FullUser `json:"manager"`
Grant FullManagerGrant `json:"grant"`
}

type FullManagedUser struct {
User FullUser `json:"user"`
Grant FullManagedUserGrant `json:"grant"`
}

func (q *Queries) FullManagers(ctx context.Context, params GetGrantsForUserIdParams) ([]FullManager, error) {

grants, err := q.GetGrantsForUserId(ctx, params)
if err != nil {
return nil, err
}

user_ids := make([]int32, len(grants))
for i, grant := range grants {
user_ids[i] = int32(grant.GranteeUserID)
}

users, err := q.FullUsersKeyed(ctx, GetUsersParams{
Ids: user_ids,
MyID: params.UserID,
})

if err != nil {
return nil, err
}

managers := make([]FullManager, len(grants))
for i, grant := range grants {
managers[i] = FullManager{
Manager: users[int32(grant.GranteeUserID)],
Grant: FullManagerGrant{GetGrantsForUserIdRow: grant},
}
}

return managers, nil
}

func (q *Queries) FullManagedUsers(ctx context.Context, params GetGrantsForGranteeUserIdParams) ([]FullManagedUser, error) {
grants, err := q.GetGrantsForGranteeUserId(ctx, GetGrantsForGranteeUserIdParams{
IsRevoked: params.IsRevoked,
IsApproved: params.IsApproved,
UserID: params.UserID,
})
if err != nil {
return nil, err
}

user_ids := make([]int32, len(grants))
for i, grant := range grants {
user_ids[i] = int32(grant.UserID)
}

users, err := q.FullUsersKeyed(ctx, GetUsersParams{
Ids: user_ids,
MyID: params.UserID,
})

if err != nil {
return nil, err
}

managedUsers := make([]FullManagedUser, len(grants))
for i, grant := range grants {
managedUsers[i] = FullManagedUser{
User: users[int32(grant.UserID)],
Grant: FullManagedUserGrant{GetGrantsForGranteeUserIdRow: grant},
}
}

return managedUsers, nil
}
14 changes: 6 additions & 8 deletions api/dbv1/queries/get_grants.sql
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ JOIN users u ON u.wallet = g.grantee_address
WHERE g.user_id = @user_id::int
AND g.is_revoked = @is_revoked
AND g.is_current = true
AND sqlc.narg('is_approved')::boolean IS NULL OR g.is_approved = sqlc.narg('is_approved')
ORDER BY g.created_at DESC;
AND (g.is_approved = sqlc.narg('is_approved') OR sqlc.narg('is_approved') IS NULL);

-- name: GetGrantsForGranteeAddress :many
-- name: GetGrantsForGranteeUserId :many
SELECT
g.user_id,
g.grantee_address,
Expand All @@ -24,10 +23,9 @@ SELECT
g.created_at,
g.updated_at,
u.user_id as grantee_user_id
FROM grants g
JOIN users u ON u.wallet = g.grantee_address
WHERE g.grantee_address = @grantee_address
FROM users u
JOIN grants g ON g.grantee_address = u.wallet
WHERE u.user_id = @user_id::int
AND g.is_current = true
AND g.is_revoked = @is_revoked
AND sqlc.narg('is_approved')::boolean IS NULL OR g.is_approved = sqlc.narg('is_approved')
ORDER BY g.created_at DESC;
AND (g.is_approved = sqlc.narg('is_approved') OR sqlc.narg('is_approved') IS NULL);
Comment thread
schottra marked this conversation as resolved.
Outdated
1 change: 1 addition & 0 deletions api/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ func NewApiServer(config config.Config) *ApiServer {
g.Get("/users/:userId/library/tracks", app.v1UsersLibraryTracks)
g.Get("/users/:userId/library/:playlistType", app.v1UsersLibraryPlaylists)
g.Get("/users/:userId/managers", app.v1UsersManagers)
g.Get("/users/:userId/managed_users", app.v1UsersManagedUsers)
g.Get("/users/:userId/mutuals", app.v1UsersMutuals)
g.Get("/users/:userId/reposts", app.v1UsersReposts)
g.Get("/users/:userId/related", app.v1UsersRelated)
Expand Down
1 change: 1 addition & 0 deletions api/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ func Test200UnAuthed(t *testing.T) {
"/v1/full/users/7eP5n/library/albums?type=purchase&sort_method=saves",

"/v1/full/users/7eP5n/managers",
"/v1/full/users/7eP5n/managed_users",
"/v1/full/users/7eP5n/mutuals",
"/v1/full/users/7eP5n/reposts",
"/v1/full/users/7eP5n/related",
Expand Down
3 changes: 3 additions & 0 deletions api/testdata/grants_fixtures.csv
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ user_id,grantee_address,is_approved,is_revoked
1,0xc451c1f8943b575158310552b41230c61844a1c1,false,true
1,0x1234567890abcdef,true,true
1,0x681c616ae836ceca1effe00bd07f2fdbf9a082bc,false,false
2,0x681c616ae836ceca1effe00bd07f2fdbf9a082bc,true,false
3,0x681c616ae836ceca1effe00bd07f2fdbf9a082bc,true,true
4,0x681c616ae836ceca1effe00bd07f2fdbf9a082bc,false,true
41 changes: 41 additions & 0 deletions api/v1_users_managed_users.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
package api

import (
"strconv"

"bridgerton.audius.co/api/dbv1"
"github.com/gofiber/fiber/v2"
"github.com/jackc/pgx/v5/pgtype"
)

func (app *ApiServer) v1UsersManagedUsers(c *fiber.Ctx) error {
// Behavior of this field is a little odd. We only want to filter by it
// if it is passed, but otherwise not use a default value for either.
var isApproved *bool
if approvedStr := c.Query("is_approved"); approvedStr != "" {
parsed, err := strconv.ParseBool(approvedStr)
if err != nil {
return fiber.NewError(fiber.StatusBadRequest, "Invalid value for is_approved")
}
isApproved = &parsed
}

isRevoked, err := strconv.ParseBool(c.Query("is_revoked", "false"))
if err != nil {
return fiber.NewError(fiber.StatusBadRequest, "Invalid value for is_revoked")
}
params := dbv1.GetGrantsForGranteeUserIdParams{
UserID: int32(c.Locals("userId").(int)),
Comment thread
schottra marked this conversation as resolved.
Outdated
IsApproved: pgtype.Bool{Bool: isApproved != nil && *isApproved, Valid: isApproved != nil},
IsRevoked: isRevoked,
}

managedUsers, err := app.queries.FullManagedUsers(c.Context(), params)
if err != nil {
return err
}

return c.JSON(fiber.Map{
"data": managedUsers,
})
}
61 changes: 61 additions & 0 deletions api/v1_users_managed_users_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
package api

import (
"testing"

"bridgerton.audius.co/api/dbv1"
"github.com/stretchr/testify/assert"
)

// Defaults to all approval status and no revoked managers
func TestGetManagedUsersNoParams(t *testing.T) {
var managedUsersResponse struct {
Data []dbv1.FullManagedUser
}
status, _ := testGet(t, "/v1/users/eYZmn/managed_users", &managedUsersResponse)
assert.Equal(t, 200, status)
assert.Equal(t, 2, len(managedUsersResponse.Data))

assert.Equal(t, 1, int(managedUsersResponse.Data[0].User.ID))
assert.Equal(t, false, managedUsersResponse.Data[0].Grant.IsApproved.Bool)
assert.Equal(t, 2, int(managedUsersResponse.Data[1].User.ID))
assert.Equal(t, true, managedUsersResponse.Data[1].Grant.IsApproved.Bool)
}

// Should return only approved managers and default to not showing revoked managers
func TestGetManagedUsersApproved(t *testing.T) {
var managedUsersResponse struct {
Data []dbv1.FullManagedUser
}
status, _ := testGet(t, "/v1/users/eYZmn/managed_users?is_approved=true", &managedUsersResponse)
assert.Equal(t, 200, status)
assert.Equal(t, 1, len(managedUsersResponse.Data))
assert.Equal(t, 2, int(managedUsersResponse.Data[0].User.ID))
assert.Equal(t, true, managedUsersResponse.Data[0].Grant.IsApproved.Bool)
}

func TestGetManagedUsersRevoked(t *testing.T) {
var managedUsersResponse struct {
Data []dbv1.FullManagedUser
}
status, _ := testGet(t, "/v1/users/eYZmn/managed_users?is_revoked=true", &managedUsersResponse)
assert.Equal(t, 200, status)
Comment thread
schottra marked this conversation as resolved.
assert.Equal(t, 2, len(managedUsersResponse.Data))
assert.Equal(t, 3, int(managedUsersResponse.Data[0].User.ID))
assert.Equal(t, true, managedUsersResponse.Data[0].Grant.IsApproved.Bool)
assert.Equal(t, true, managedUsersResponse.Data[0].Grant.IsRevoked)
assert.Equal(t, 4, int(managedUsersResponse.Data[1].User.ID))
assert.Equal(t, false, managedUsersResponse.Data[1].Grant.IsApproved.Bool)
assert.Equal(t, true, managedUsersResponse.Data[1].Grant.IsRevoked)
}

func TestGetManagedUsersInvalidParams(t *testing.T) {
var managedUsersResponse struct {
Data []dbv1.FullManagedUser
}
status, _ := testGet(t, "/v1/users/eYZmn/managed_users?is_approved=invalid", &managedUsersResponse)
assert.Equal(t, 400, status)

status, _ = testGet(t, "/v1/users/eYZmn/managed_users?is_revoked=invalid", &managedUsersResponse)
assert.Equal(t, 400, status)
}
4 changes: 2 additions & 2 deletions api/v1_users_managers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func TestGetUsersManagersApproved(t *testing.T) {
}
status, _ := testGet(t, "/v1/users/7eP5n/managers?is_approved=true", &managersResponse)
assert.Equal(t, 200, status)
assert.Equal(t, 2, len(managersResponse.Data))
assert.Equal(t, 1, len(managersResponse.Data))
assert.Equal(t, "0x5f1a372b28956c8363f8bc3a231a6e9e1186ead8", managersResponse.Data[0].Manager.Wallet.String)
assert.Equal(t, true, managersResponse.Data[0].Grant.IsApproved.Bool)
}
Expand All @@ -49,7 +49,7 @@ func TestGetUsersManagersRevoked(t *testing.T) {
assert.Equal(t, true, managersResponse.Data[1].Grant.IsRevoked)
}

func TestInvalidParams(t *testing.T) {
func TestGetUsersManagersInvalidParams(t *testing.T) {
var managersResponse struct {
Data []dbv1.FullManager
}
Expand Down
Loading