Skip to content

Include unlisted tracks in playlist responses #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickyrombo merged 2 commits into from
Apr 8, 2026
Merged

Include unlisted tracks in playlist responses #755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa88d0f
Include unlisted tracks in playlist responses
rickyrombo Apr 7, 2026
68b510e
Add tests for unlisted tracks in playlist responses
rickyrombo Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions api/dbv1/parallel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ import (
)

type ParallelParams struct {
UserIds []int32
TrackIds []int32
PlaylistIds []int32
MyID int32
AuthedWallet string
UserIds []int32
TrackIds []int32
PlaylistIds []int32
MyID int32
AuthedWallet string
IncludeUnlisted bool
}

type ParallelResult struct {
Expand Down Expand Up @@ -43,9 +44,10 @@ func (q *Queries) Parallel(ctx context.Context, arg ParallelParams) (*ParallelRe
var err error
trackMap, err = q.TracksKeyed(ctx, TracksParams{
GetTracksParams: GetTracksParams{
Ids: arg.TrackIds,
MyID: arg.MyID,
AuthedWallet: arg.AuthedWallet,
Ids: arg.TrackIds,
MyID: arg.MyID,
AuthedWallet: arg.AuthedWallet,
IncludeUnlisted: arg.IncludeUnlisted,
},
})
return err
Expand Down
9 changes: 5 additions & 4 deletions api/dbv1/playlists.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@ func (q *Queries) PlaylistsKeyed(ctx context.Context, arg PlaylistsParams) (map[

// fetch users + tracks in parallel
loaded, err := q.Parallel(ctx, ParallelParams{
UserIds: userIds,
TrackIds: trackIds,
MyID: arg.MyID.(int32),
AuthedWallet: arg.AuthedWallet,
UserIds: userIds,
TrackIds: trackIds,
MyID: arg.MyID.(int32),
AuthedWallet: arg.AuthedWallet,
IncludeUnlisted: true,
})
Comment thread
rickyrombo marked this conversation as resolved.
if err != nil {
return nil, err
Expand Down
7 changes: 4 additions & 3 deletions api/v1_playlist_tracks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,10 @@ func (app *ApiServer) v1PlaylistTracks(c *fiber.Ctx) error {

tracks, err := app.queries.Tracks(c.Context(), dbv1.TracksParams{
GetTracksParams: dbv1.GetTracksParams{
Ids: trackIds,
MyID: myId,
AuthedWallet: app.tryGetAuthedWallet(c),
Ids: trackIds,
MyID: myId,
AuthedWallet: app.tryGetAuthedWallet(c),
IncludeUnlisted: true,
},
Comment thread
rickyrombo marked this conversation as resolved.
})

Expand Down
Loading