Skip to content

Commit 4267519

Browse files
dylanjeffersclaude
andcommitted
fix(ci): match CircleCI test invocation for identity-service
CircleCI's test-identity-service entrypoint shifted "test" off and ran `npx mocha` with no args, so mocha used its default `test/*.{js,cjs,mjs}` glob — only the .js tests, never `test/index.ts`. src/app.js only requires .js modules (routes/index.js filters to `.js`), so the .ts solana relay tree never loaded and the missing solana env vars didn't matter. `ts-mocha test/index.ts` exposed that path and crashed on `new PublicKey('')` in solanaRelayChecks.ts. Switch to plain `npx mocha` to mirror CircleCI exactly. Filling in real solana env vars (or unblocking the .ts tests) is out of scope for the migration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 3fb6760 commit 4267519

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

.github/workflows/identity.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -306,10 +306,12 @@ jobs:
306306
- name: Build dependencies
307307
run: npx turbo run build --filter=identity-service^...
308308

309-
# The identity-service test runner (scripts/run-tests.sh) spins up its own
310-
# postgres/redis docker containers when run outside CI. We supply them as
311-
# GHA service containers instead, then call ts-mocha directly with the
312-
# env vars the script exports.
309+
# Mirror what CircleCI ran: `npx mocha` with no args (the
310+
# docker-compose.test.yml `test-identity-service` entrypoint shifted "test"
311+
# off and invoked `npx mocha`). Mocha's default `test/*.{js,cjs,mjs}` glob
312+
# picks up only the `.js` test files; `test/index.ts` (which transitively
313+
# imports the solana relay tree and requires populated solana env vars) is
314+
# intentionally skipped, matching prior CI behavior.
313315
- name: Run tests
314316
timeout-minutes: 20
315317
working-directory: packages/identity-service
@@ -325,10 +327,7 @@ jobs:
325327
ethRegistryAddress: ''
326328
registryAddress: ''
327329
ethOwnerWallet: ''
328-
solanaTrackListenCountAddress: ''
329-
solanaAudiusEthRegistryAddress: ''
330-
solanaValidSigner: ''
331-
run: ../../node_modules/ts-mocha/bin/ts-mocha test/index.ts --timeout 12000 --exit
330+
run: npx mocha
332331

333332
identity-docker-push:
334333
name: Push identity-service Docker image

0 commit comments

Comments
 (0)