Fix visibility copy for playlist edit privacy tile (#14076)

## Summary
- fix incorrect visibility tile copy shown in edit flows for non-track
entities
- update web visibility field to compute title/description from
`entityType`
- update mobile visibility label/screen title to compute title from
`entityType`

## Bug
Playlists were showing track-specific copy in the Edit Playlist privacy
tile (`Track Privacy` and track scheduling language), even though
playlists cannot be scheduled.

## Fix
-
`packages/web/src/components/edit/fields/visibility/VisibilityField.tsx`
- replaced static shared `title`/`description` usage with
`entityType`-aware copy
- playlists now show `Playlist Privacy` and description without
scheduling text
-
`packages/mobile/src/components/edit/VisibilityField/VisibilityField.tsx`
  - updated contextual menu label to `entityType`-aware privacy title
-
`packages/mobile/src/components/edit/VisibilityField/VisibilityScreen.tsx`
  - updated form screen title to `entityType`-aware privacy title

## Validation
- attempted targeted lint checks for edited files in web and mobile
workspaces
- environment is missing local `eslint` binary (`sh: 1: eslint: not
found`), so lint could not be executed in this runner

<div><a
href="https://cursor.com/agents/bc-e3060d50-d639-567b-8e0b-410aa84af00b"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/c63aa103-66df-4558-b31d-675358e5c6a1"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>

Author: 3 people

packages/mobile/src/components/edit/VisibilityField/VisibilityField.tsx

@@ -8,13 +8,17 @@ export const visibilityScreenName = 'Visibility'
 
 const messages = {
   ...visibilityMessages,
+  title: (entityType: 'track' | 'album' | 'playlist') =>
+    `${entityType === 'track' ? 'Track' : entityType === 'album' ? 'Album' : 'Playlist'} Privacy`,
   scheduled: (date: string) => `Scheduled for ${formatCalendarTime(date)}`
 }
 
 export const VisibilityField = () => {
-  const [{ value: entitiType }] = useField('entityType')
+  const [{ value: entityType }] = useField<'track' | 'album' | 'playlist'>(
+    'entityType'
+  )
   const [{ value: isHidden }] = useField(
-    entitiType === 'track' ? 'is_unlisted' : 'is_private'
+    entityType === 'track' ? 'is_unlisted' : 'is_private'
   )
   const [{ value: isScheduledRelease }] = useField('is_scheduled_release')
   const [{ value: releaseDate }] = useField('release_date')
@@ -28,7 +32,7 @@ export const VisibilityField = () => {
 
   return (
     <ContextualMenu
-      label={messages.title}
+      label={messages.title(entityType)}
       value={value}
       menuScreenName={visibilityScreenName}
     />

packages/mobile/src/components/edit/VisibilityField/VisibilityScreen.tsx

@@ -19,9 +19,15 @@ import { ScheduledReleaseDateField } from './ScheduledReleaseDateField'
 
 type VisibilityType = 'scheduled' | 'public' | 'hidden'
 
+const getMessages = (entityType: 'track' | 'album' | 'playlist') => ({
+  ...messages,
+  title: `${entityType === 'track' ? 'Track' : entityType === 'album' ? 'Album' : 'Playlist'} Privacy`
+})
+
 export const VisibilityScreen = () => {
   const { values, initialValues, setValues } = useFormikContext<FormValues>()
   const { entityType } = values
+  const visibilityMessages = getMessages(entityType)
   const hiddenKey = entityType === 'track' ? 'is_unlisted' : 'is_private'
   const {
     [hiddenKey]: isHidden,
@@ -93,7 +99,7 @@ export const VisibilityScreen = () => {
 
   return (
     <FormScreen
-      title={messages.title}
+      title={visibilityMessages.title}
       icon={IconVisibilityPublic}
       onSubmit={handleSubmit}
       variant='white'
@@ -105,21 +111,21 @@ export const VisibilityScreen = () => {
       >
         <ExpandableRadio
           value='public'
-          label={messages.public}
-          description={messages.publicDescription}
+          label={visibilityMessages.public}
+          description={visibilityMessages.publicDescription}
         />
         <ExpandableRadio
           value='hidden'
-          label={messages.hidden}
+          label={visibilityMessages.hidden}
           icon={IconVisibilityHidden}
-          description={messages.hiddenDescription}
+          description={visibilityMessages.hiddenDescription}
         />
         {!initiallyPublic &&
         (entityType === 'track' || entityType === 'album') ? (
           <ExpandableRadio
             value='scheduled'
-            label={messages.scheduledRelease}
-            description={messages.scheduledReleaseDescription}
+            label={visibilityMessages.scheduledRelease}
+            description={visibilityMessages.scheduledReleaseDescription}
             checkedContent={
               <ScheduledReleaseDateField
                 releaseDate={releaseDate}

packages/web/src/components/edit/fields/visibility/VisibilityField.tsx

@@ -27,6 +27,14 @@ import { mergeReleaseDateValues } from './mergeReleaseDateValues'
 
 const messages = {
   ...visibilityMessages,
+  title: (entityType: 'track' | 'album' | 'playlist') =>
+    `${entityType === 'track' ? 'Track' : entityType === 'album' ? 'Album' : 'Playlist'} Privacy`,
+  description: (entityType: 'track' | 'album' | 'playlist') =>
+    entityType === 'track'
+      ? 'Adjust your track’s visibility or schedule it for later release.'
+      : entityType === 'album'
+        ? 'Adjust your album’s visibility or schedule it for later release.'
+        : 'Adjust your playlist’s visibility.',
   scheduled: (date: string) => `Scheduled for ${formatCalendarTime(date)}`,
   emptyPlaylistTooltipText: 'You must add at least 1 song.'
 }
@@ -76,6 +84,8 @@ const visibilitySchema = z
 
 export const VisibilityField = (props: VisibilityFieldProps) => {
   const { entityType, isUpload, isPublishable = true } = props
+  const title = messages.title(entityType)
+  const description = messages.description(entityType)
   const useEntityField = entityType === 'track' ? useTrackField : useField
   const [
     { value: isHidden },
@@ -134,9 +144,9 @@ export const VisibilityField = (props: VisibilityFieldProps) => {
 
   return (
     <ContextualMenu
-      label={messages.title}
+      label={title}
       icon={<IconVisibilityPublic />}
-      description={messages.description}
+      description={description}
       renderValue={renderValue}
       initialValues={initialValues}
       validationSchema={toFormikValidationSchema(visibilitySchema)}
@@ -177,6 +187,7 @@ export const VisibilityField = (props: VisibilityFieldProps) => {
       menuFields={
         <VisibilityMenuFields
           entityType={entityType}
+          title={title}
           initiallyPublic={!initiallyHidden && !isUpload}
           isPublishable={isPublishable}
         />
@@ -187,16 +198,17 @@ export const VisibilityField = (props: VisibilityFieldProps) => {
 
 type VisibilityMenuFieldsProps = {
   entityType: 'track' | 'album' | 'playlist'
+  title: string
   initiallyPublic?: boolean
   isPublishable?: boolean
 }
 
 const VisibilityMenuFields = (props: VisibilityMenuFieldsProps) => {
-  const { initiallyPublic, isPublishable = true, entityType } = props
+  const { initiallyPublic, isPublishable = true, entityType, title } = props
   const [field] = useField<VisibilityType>('visibilityType')
 
   return (
-    <RadioGroup {...field} aria-label={messages.title}>
+    <RadioGroup {...field} aria-label={title}>
       <ModalRadioItem
         value='public'
         label={messages.public}