fix(notifications): personalize embedded users in related response

On initial app load the current user's follow relationship to other
accounts (e.g. @audius) renders as not-following in lists hydrated from
notification responses. Visiting that profile directly fixes the state.
The bug: the /notifications/{user_id} endpoint embeds users in the
related field, and the backend personalizes them via getMyId(c) which
reads ?user_id= from the query string, not the URL path. The SDK was
only sending the id in the path, so MyID resolved to 0 and the SQL
short-circuited does_current_user_follow to false for every embedded
user. The tan-query cache primed those entries on a cold notifications
fetch and sticky-cached the wrong follow state until a personalized
profile fetch overwrote them.

The accompanying api PR adds an optional user_id query param to both
/notifications/{user_id} and /notifications/{user_id}/playlist_updates.
This change:

- Regenerates @audius/sdk from the updated spec. The openapi generator
  renamed the new query param to `userId2` to avoid colliding with the
  path's `userId`. Wire format is correct (`queryParameters['user_id']`),
  the field name is just awkward — see PR description for follow-up
  options.
- Threads the current user id through both call sites
  (useNotifications.ts, usePlaylistUpdates.ts) as `userId2` so the
  backend can compute personalization for related.users. Path and query
  carry the same value in the normal flow; they may diverge when a
  manager reads a managed user's notifications.

The UsersApi.ts diff is incidental drift: getUserForYouFeed was removed
upstream and our generated copy was stale.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: raymondjacobson

packages/common/src/api/tan-query/notifications/useNotifications.ts

@@ -77,6 +77,10 @@ export const useNotifications = (options?: QueryOptions) => {
       const sdk = await audiusSdk()
       const response = await sdk.notifications.getNotifications({
         userId: Id.parse(currentUserId),
+        // Requester id sent as `?user_id=`. Needed so the backend personalizes
+        // embedded related.users (e.g. does_current_user_follow) — the path
+        // userId alone identifies the notifications owner, not the requester.
+        userId2: Id.parse(currentUserId),
         limit: DEFAULT_LIMIT,
         timestamp: pageParam?.timestamp,
         groupId: pageParam?.groupId

packages/common/src/api/tan-query/playlist-updates/usePlaylistUpdates.ts

@@ -38,14 +38,18 @@ export const usePlaylistUpdates = <TResult = PlaylistUpdate[]>(
       const sdk = await audiusSdk()
       // sdk.notifications.getPlaylistUpdates is not currently typed in the
       // public SDK surface; cast to the expected shape used in the legacy saga.
+      // userId2 carries the requester id as `?user_id=` so the backend can
+      // personalize related.users in the response.
       const response = (await (
         sdk.notifications as {
           getPlaylistUpdates: (params: {
             userId: string
+            userId2?: string
           }) => Promise<PlaylistUpdatesResponse>
         }
       ).getPlaylistUpdates({
-        userId: Id.parse(currentUserId)
+        userId: Id.parse(currentUserId),
+        userId2: Id.parse(currentUserId)
       })) as PlaylistUpdatesResponse | undefined
 
       return transformAndCleanList(

packages/sdk/src/sdk/api/generated/default/apis/NotificationsApi.ts

@@ -27,6 +27,7 @@ import {
 
 export interface GetNotificationsRequest {
     userId: string;
+    userId2?: string;
     timestamp?: number;
     groupId?: string;
     limit?: number;
@@ -35,6 +36,7 @@ export interface GetNotificationsRequest {
 
 export interface GetPlaylistUpdatesRequest {
     userId: string;
+    userId2?: string;
 }
 
 /**
@@ -53,6 +55,10 @@ export class NotificationsApi extends runtime.BaseAPI {
 
         const queryParameters: any = {};
 
+        if (params.userId2 !== undefined) {
+            queryParameters['user_id'] = params.userId2;
+        }
+
         if (params.timestamp !== undefined) {
             queryParameters['timestamp'] = params.timestamp;
         }
@@ -100,6 +106,10 @@ export class NotificationsApi extends runtime.BaseAPI {
 
         const queryParameters: any = {};
 
+        if (params.userId2 !== undefined) {
+            queryParameters['user_id'] = params.userId2;
+        }
+
         const headerParameters: runtime.HTTPHeaders = {};
 
         const response = await this.request({

packages/sdk/src/sdk/api/generated/default/apis/UsersApi.ts

@@ -686,14 +686,6 @@ export interface GetUserFeedRequest {
     encodedDataSignature?: string;
 }
 
-export interface GetUserForYouFeedRequest {
-    id: string;
-    limit?: number;
-    offset?: number;
-    maxPerArtist?: number;
-    userId?: string;
-}
-
 export interface GetUserIDsByAddressesRequest {
     address: Array<string>;
 }
@@ -4175,62 +4167,6 @@ export class UsersApi extends runtime.BaseAPI {
         return await response.value();
     }
 
-    /**
-     * @hidden
-     * Returns a personalized For You feed for the user identified in the path. Twitter-style multi-source pipeline — candidate retrieval (in-network, trending, underground, similar-artist) → linear ranking (recency decay × engagement × social affinity, weighted by source) → diversity (per-artist cap + consecutive-same-artist lookahead).
-     * Get For You feed for user
-     */
-    async getUserForYouFeedRaw(params: GetUserForYouFeedRequest, initOverrides?: RequestInit | runtime.InitOverrideFunction): Promise<runtime.ApiResponse<Tracks>> {
-        if (params.id === null || params.id === undefined) {
-            throw new runtime.RequiredError('id','Required parameter params.id was null or undefined when calling getUserForYouFeed.');
-        }
-
-        const queryParameters: any = {};
-
-        if (params.limit !== undefined) {
-            queryParameters['limit'] = params.limit;
-        }
-
-        if (params.offset !== undefined) {
-            queryParameters['offset'] = params.offset;
-        }
-
-        if (params.maxPerArtist !== undefined) {
-            queryParameters['max_per_artist'] = params.maxPerArtist;
-        }
-
-        if (params.userId !== undefined) {
-            queryParameters['user_id'] = params.userId;
-        }
-
-        const headerParameters: runtime.HTTPHeaders = {};
-
-        if (!headerParameters["Authorization"] && this.configuration && this.configuration.accessToken) {
-            const token = await this.configuration.accessToken("OAuth2", ["read"]);
-            if (token) {
-                headerParameters["Authorization"] = token;
-            }
-        }
-
-        const response = await this.request({
-            path: `/users/{id}/feed/for-you`.replace(`{${"id"}}`, encodeURIComponent(String(params.id))),
-            method: 'GET',
-            headers: headerParameters,
-            query: queryParameters,
-        }, initOverrides);
-
-        return new runtime.JSONApiResponse(response, (jsonValue) => TracksFromJSON(jsonValue));
-    }
-
-    /**
-     * Returns a personalized For You feed for the user identified in the path. Twitter-style multi-source pipeline — candidate retrieval (in-network, trending, underground, similar-artist) → linear ranking (recency decay × engagement × social affinity, weighted by source) → diversity (per-artist cap + consecutive-same-artist lookahead).
-     * Get For You feed for user
-     */
-    async getUserForYouFeed(params: GetUserForYouFeedRequest, initOverrides?: RequestInit | runtime.InitOverrideFunction): Promise<Tracks> {
-        const response = await this.getUserForYouFeedRaw(params, initOverrides);
-        return await response.value();
-    }
-
     /**
      * @hidden
      * Gets User IDs from any Ethereum wallet address or Solana account address associated with their Audius account.