Skip to content

Commit bb5bdee

Browse files
chore(mobile): bump versions for release + restore Node in Android CI (#14389)
## Summary Two changes needed to actually publish a release on main: 1. **Version bump for the binary build jobs to fire again.** The `mobile-version-check` job compares `packages/mobile/package.json` `version` between `HEAD` and `HEAD^`. Once **1.5.180** landed (PR #14365 / commit [51cf0b2](51cf0b2eb5)), every subsequent commit reported `version_changed=false`, so the iOS RC, Android RC, iOS Production, and Android Production jobs all got skipped. Bumps: - `packages/mobile/package.json`: `1.5.180` → `1.5.181` - `packages/mobile/ios/AudiusReactNative/Info.plist` `CFBundleShortVersionString`: `1.1.193` → `1.1.194` - `packages/mobile/android/app/build.gradle` `versionName`: `1.1.529` → `1.1.530` 2. **Android RC + Android Production CI no longer falls back to Node 22.** In [run 26246576840](https://github.com/AudiusProject/apps/actions/runs/26246576840), both Android jobs failed `npm ci` with: ``` npm error code EBADENGINE npm error notsup Required: {"node":">=24.10.0","npm":">=11.10.0"} npm error notsup Actual: {"npm":"10.9.8","node":"v22.22.3"} ``` The job order is `Setup Node.js → Setup Android SDK → Free disk space → Setup Java (after disk cleanup) → … → Install dependencies`. The "Free disk space" step does `sudo rm -rf "$AGENT_TOOLSDIRECTORY"`, which is where `actions/setup-node@v4` placed Node 24 — so by the time `npm ci` runs, only the runner's system Node 22 is on PATH. Java is intentionally re-set-up after cleanup; Node was not. This PR adds a matching `Setup Node.js (after disk cleanup)` step (plus the npm 11 upgrade) in both Android jobs. The iOS failures in that run were caused by an unrelated duplicate `make` import in `ContestScreen.tsx`, which has already been fixed on main by [802487b](802487bb3a). ## Test plan - [ ] Merge → Mobile CI/CD on main fires all four binary build/upload jobs (version_changed=true) - [ ] iOS RC build & upload succeeds end-to-end - [ ] Android RC build & upload reaches \`fastlane releaseCandidate\` (Node 24 visible in install step logs) - [ ] iOS Production + Android Production gated on environment approval as usual 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 02e7aa0 commit bb5bdee

4 files changed

Lines changed: 31 additions & 3 deletions

File tree

.github/workflows/mobile.yml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,20 @@ jobs:
673673
distribution: 'temurin'
674674
java-version: '17'
675675

676+
# The "Free disk space" step above removes $AGENT_TOOLSDIRECTORY, which
677+
# also wipes the Node 24 install from the earlier setup-node step. Without
678+
# this re-setup, npm ci falls back to the runner's system Node 22 and the
679+
# mobile workspace's "engines" check fails with EBADENGINE.
680+
- name: Setup Node.js (after disk cleanup)
681+
uses: actions/setup-node@v4
682+
with:
683+
node-version: ${{ env.NODE_VERSION }}
684+
cache: 'npm'
685+
cache-dependency-path: package-lock.json
686+
687+
- name: Upgrade npm to 11.10.0 (after disk cleanup)
688+
run: npm install -g npm@11.10.0
689+
676690
- name: Create concatenated patch file
677691
id: patch-file
678692
run: |
@@ -1051,6 +1065,20 @@ jobs:
10511065
distribution: 'temurin'
10521066
java-version: '17'
10531067

1068+
# The "Free disk space" step above removes $AGENT_TOOLSDIRECTORY, which
1069+
# also wipes the Node 24 install from the earlier setup-node step. Without
1070+
# this re-setup, npm ci falls back to the runner's system Node 22 and the
1071+
# mobile workspace's "engines" check fails with EBADENGINE.
1072+
- name: Setup Node.js (after disk cleanup)
1073+
uses: actions/setup-node@v4
1074+
with:
1075+
node-version: ${{ env.NODE_VERSION }}
1076+
cache: 'npm'
1077+
cache-dependency-path: package-lock.json
1078+
1079+
- name: Upgrade npm to 11.10.0 (after disk cleanup)
1080+
run: npm install -g npm@11.10.0
1081+
10541082
- name: Create concatenated patch file
10551083
id: patch-file
10561084
run: |

packages/mobile/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ android {
128128
// versionCode is automatically incremented in CI
129129
versionCode 1
130130
// Make sure this is above the currently released Android version in the play store if your changes touch native code:
131-
versionName "1.1.529"
131+
versionName "1.1.530"
132132
resValue "string", "build_config_package", "co.audius.app"
133133
resConfigs "en"
134134
}

packages/mobile/ios/AudiusReactNative/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>1.1.193</string>
20+
<string>1.1.194</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleURLTypes</key>

packages/mobile/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@audius/mobile",
3-
"version": "1.5.180",
3+
"version": "1.5.181",
44
"private": true,
55
"scripts": {
66
"android:dev": "ENVFILE=.env.dev turbo run android -- --mode=prodDebug",

0 commit comments

Comments
 (0)