Fix icon builds (#13853)

Author: dylanjeffers

packages/mobile/ios/AudiusReactNative.xcodeproj/project.pbxproj

@@ -58,7 +58,7 @@
 /* Begin PBXFileReference section */
 		00E356F11AD99517003FC87E /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 		00E356F21AD99517003FC87E /* AudiusReactNativeTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = AudiusReactNativeTests.m; sourceTree = "<group>"; };
-		04F6B3542BF84180BC937315 /* Colors.xcassets */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = folder.assetcatalog; name = Colors.xcassets; path = AudiusReactNative/Colors.xcassets; sourceTree = "<group>"; };
+		04F6B3542BF84180BC937315 /* Colors.xcassets */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = folder.assetcatalog; name = Colors.xcassets; path = AudiusReactNative/Colors.xcassets; sourceTree = "<group>"; };
 		13B07F961A680F5B00A75B9A /* Audius Music.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "Audius Music.app"; sourceTree = BUILT_PRODUCTS_DIR; };
 		13B07FAF1A68108700A75B9A /* AppDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AppDelegate.h; path = AudiusReactNative/AppDelegate.h; sourceTree = "<group>"; };
 		13B07FB01A68108700A75B9A /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AppDelegate.mm; path = AudiusReactNative/AppDelegate.mm; sourceTree = "<group>"; };
@@ -435,10 +435,14 @@
 			inputFileListPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-resources-${CONFIGURATION}-input-files.xcfilelist",
 			);
+			inputPaths = (
+			);
 			name = "[CP] Copy Pods Resources";
 			outputFileListPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-resources-${CONFIGURATION}-output-files.xcfilelist",
 			);
+			outputPaths = (
+			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
 			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-resources.sh\"\n";
@@ -452,10 +456,14 @@
 			inputFileListPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-frameworks-${CONFIGURATION}-input-files.xcfilelist",
 			);
+			inputPaths = (
+			);
 			name = "[CP] Embed Pods Frameworks";
 			outputFileListPaths = (
 				"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-frameworks-${CONFIGURATION}-output-files.xcfilelist",
 			);
+			outputPaths = (
+			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
 			shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-AudiusReactNative/Pods-AudiusReactNative-frameworks.sh\"\n";
@@ -500,8 +508,8 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 80E769842E137A16D8B24B96 /* Pods-AudiusReactNative.debug.xcconfig */;
 			buildSettings = {
-				APP_DISPLAY_NAME = "Audius Music";
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				APP_DISPLAY_NAME = "Audius Music";
 				BUNDLE_ID_SUFFIX = "";
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = "AudiusReactNative/Audius Music.entitlements";
@@ -535,8 +543,8 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 453FC09EC343ACA359EB312C /* Pods-AudiusReactNative.release.xcconfig */;
 			buildSettings = {
-				APP_DISPLAY_NAME = "Audius Music";
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
+				APP_DISPLAY_NAME = "Audius Music";
 				BUNDLE_ID_SUFFIX = "";
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = "AudiusReactNative/Audius Music.entitlements";
@@ -888,8 +896,8 @@
 			isa = XCBuildConfiguration;
 			baseConfigurationReference = 1FBFACF443D7D1D743A6B13A /* Pods-AudiusReactNative.releasecandidate.xcconfig */;
 			buildSettings = {
+				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				APP_DISPLAY_NAME = "RC - Prod (Audius)";
-				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon.ReleaseCandidate;
 				BUNDLE_ID_SUFFIX = "";
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = "AudiusReactNative/Audius Music.entitlements";

packages/mobile/ios/fastlane/Fastfile

@@ -72,14 +72,14 @@ platform :ios do
     # build numbers start at 1
 
     app_store_connect_api_key
-    increment_build_number(
-      build_number: app_store_build_number(
-        app_identifier: options[:bundle_id],
-        initial_build_number: 0,
-        version: plistVersionNumber.to_s,
-        live: false
-      ) + 1,
+    next_build = app_store_build_number(
+      app_identifier: options[:bundle_id],
+      initial_build_number: 0,
+      version: plistVersionNumber.to_s,
+      live: false
     )
+    next_build = (next_build.nil? ? 0 : next_build) + 1
+    increment_build_number(build_number: next_build)
 
     # Build ios
     gym(
@@ -123,7 +123,7 @@ platform :ios do
   end
 
   desc "Build + upload via TestFlight"
-  lane:build_and_upload do |options|
+  lane :build_and_upload do |options|
     if options[:bundle_id] === AUDIUSMUSIC_ID
       scheme = 'AudiusReactNative'
     elsif options[:bundle_id] === AUDIUSMUSIC_RELEASECANDIDATE_ID