Create SDK without services by default in all cases (#13906)

See changeset.

Motivation is to make the SDK types the same regardless of which config
you pass in, and use the API endpoints by default.

To keep the existing "services" version of SDK, call
`createSdkWithServices` explicitly. This is not recommended - writes and
other services won't work without tedious and proper integration with
the user's wallet.

Also:
- Adds `UploadsApi` to services SDK
- Updates `storageService` to `storage` in `UploadsApi` config

Author: rickyrombo

.changeset/real-rabbits-pretend.md

@@ -0,0 +1,9 @@
+---
+'@audius/sdk': major
+---
+
+Create SDK without services by default in all cases
+
+Updates the `sdk()` constructor to create the SDK without the old services and API structure regardless of config. This will align all configurations to have the same API surface that matches existing docs and examples.
+
+To maintain compatibility, older legacy apps can use `createSdkWithServices()` instead of `sdk()` when initting the SDK. This is not advised for third-party apps.

packages/commands/src/utils.ts

@@ -1,5 +1,5 @@
 import {
-  sdk,
+  createSdkWithServices,
   SolanaRelay,
   Configuration,
   createHedgehogWalletClient,
@@ -163,7 +163,7 @@ export const initializeAudiusSdk = async ({
 
     const audiusWalletClient = createHedgehogWalletClient(getHedgehog())
 
-    audiusSdk = sdk({
+    audiusSdk = createSdkWithServices({
       appName: 'audius-cmd',
       environment: 'development',
       services: {

packages/common/src/api/tan-query/batchers/types.ts

@@ -1,11 +1,11 @@
-import type { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { QueryClient } from '@tanstack/react-query'
 import { AnyAction, Dispatch } from 'redux'
 
 import { ID } from '~/models/Identifiers'
 
 export type BatchContext = {
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
   currentUserId: ID | null | undefined
   queryClient: QueryClient
   dispatch: Dispatch<AnyAction>

packages/common/src/api/tan-query/collection/useCollection.ts

@@ -1,6 +1,6 @@
 import { useMemo } from 'react'
 
-import { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { useQuery, useQueryClient, QueryClient } from '@tanstack/react-query'
 import { useDispatch } from 'react-redux'
 import { AnyAction, Dispatch } from 'redux'
@@ -26,7 +26,7 @@ export const getCollectionQueryFn = async (
   collectionId: ID,
   currentUserId: number | null | undefined,
   queryClient: QueryClient,
-  sdk: AudiusSdk,
+  sdk: AudiusSdkWithServices,
   dispatch: Dispatch<AnyAction>
 ) => {
   const batchGetCollections = getCollectionsBatcher({

packages/common/src/api/tan-query/jupiter/executors.ts

@@ -1,5 +1,5 @@
 import { FixedDecimal } from '@audius/fixed-decimal'
-import { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { SwapRequest } from '@jup-ag/api'
 import {
   createAssociatedTokenAccountIdempotentInstruction,
@@ -72,7 +72,7 @@ async function executeMeteoraSwap(
   swapDirection: 'audioToCoin' | 'coinToAudio',
   inputAmountUi: number,
   dependencies: {
-    sdk: AudiusSdk
+    sdk: AudiusSdkWithServices
     userPublicKey: PublicKey
     keypair: Keypair
     ethAddress: string

packages/common/src/api/tan-query/jupiter/types.ts

@@ -1,4 +1,4 @@
-import type { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { PublicKey } from '@solana/web3.js'
 import type { Keypair } from '@solana/web3.js'
 import { useQueryClient } from '@tanstack/react-query'
@@ -74,7 +74,7 @@ export interface UserBankManagedTokenInfo {
 }
 
 export type SwapDependencies = {
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
   keypair: Keypair
   userPublicKey: PublicKey
   feePayer: PublicKey

packages/common/src/api/tan-query/jupiter/useCoinExchangeRate.ts

@@ -1,7 +1,7 @@
 import { useMemo } from 'react'
 
 import { FixedDecimal } from '@audius/fixed-decimal'
-import type { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { QuoteResponse, SwapMode } from '@jup-ag/api'
 import { QueryClient, useQuery, useQueryClient } from '@tanstack/react-query'
 
@@ -116,7 +116,7 @@ export const getDirectQuote = async (
     swapMode?: SwapMode
   },
   queryClient: QueryClient,
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
 ): Promise<CoinExchangeRateResponse> => {
   const { hasPool: inputHasPool } = getCoinPoolState(
     params.inputMint,
@@ -172,7 +172,7 @@ export const getIndirectQuoteViaAudio = async (
     swapMode?: SwapMode
   },
   queryClient: QueryClient,
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
 ): Promise<CoinExchangeRateResponse> => {
   const { hasPool: inputHasPool } = getCoinPoolState(
     params.inputMint,
@@ -273,7 +273,7 @@ export const getQuoteViaMeteoraDBC = async (
     amountUi: number
     swapMode?: SwapMode
   },
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
 ): Promise<JupiterQuoteResult> => {
   const { inputMint, outputMint, inputDecimals, outputDecimals, amountUi } =
     params

packages/common/src/api/tan-query/jupiter/utils.ts

@@ -1,5 +1,5 @@
 import { USDC } from '@audius/fixed-decimal'
-import type { AudiusSdk } from '@audius/sdk'
+import type { AudiusSdkWithServices } from '@audius/sdk'
 import { SwapInstructionsResponse, SwapRequest } from '@jup-ag/api'
 import {
   createAssociatedTokenAccountIdempotentInstruction,
@@ -121,7 +121,7 @@ export async function addTransferToUserBankInstructions({
   ethAddress: string
   amountLamports: bigint
   sourceAta: PublicKey
-  sdk: AudiusSdk
+  sdk: AudiusSdkWithServices
   feePayer: PublicKey
   instructions: TransactionInstruction[]
 }): Promise<PublicKey> {
@@ -372,7 +372,7 @@ export const getJupiterSwapInstructions = async (
 }
 
 export const buildAndSendTransaction = async (
-  sdk: AudiusSdk,
+  sdk: AudiusSdkWithServices,
   keypair: Keypair,
   feePayer: PublicKey,
   instructions: TransactionInstruction[],
@@ -421,7 +421,7 @@ export const invalidateSwapQueries = async (
 }
 
 export const prepareOutputUserBank = async (
-  sdk: AudiusSdk,
+  sdk: AudiusSdkWithServices,
   ethAddress: string,
   outputTokenConfig: UserBankManagedTokenInfo
 ): Promise<string> => {

packages/common/src/api/tan-query/tracks/useTrack.ts

@@ -1,6 +1,6 @@
 import { useMemo } from 'react'
 
-import { AudiusSdk } from '@audius/sdk'
+import { AudiusSdkWithServices } from '@audius/sdk'
 import { QueryClient, useQuery, useQueryClient } from '@tanstack/react-query'
 import { useDispatch } from 'react-redux'
 import { AnyAction, Dispatch } from 'redux'
@@ -23,7 +23,7 @@ export const getTrackQueryFn = async (
   trackId: ID,
   currentUserId: ID | null | undefined,
   queryClient: QueryClient,
-  sdk: AudiusSdk,
+  sdk: AudiusSdkWithServices,
   dispatch: Dispatch<AnyAction>
 ) => {
   const batchGetTracks = getTracksBatcher({

packages/common/src/api/tan-query/users/account/useUpdatePlaylistLibrary.ts

@@ -1,4 +1,4 @@
-import { AudiusSdk } from '@audius/sdk'
+import { AudiusSdkWithServices } from '@audius/sdk'
 import { useQueryClient, useMutation, QueryClient } from '@tanstack/react-query'
 import { useDispatch } from 'react-redux'
 import { Dispatch } from 'redux'
@@ -34,7 +34,7 @@ export const useUpdatePlaylistLibrary = () => {
 
 // feature-tan-query TODO: migrate saga usages, then remove this
 export const updatePlaylistLibrary = async (
-  audiusSdk: AudiusSdk,
+  audiusSdk: AudiusSdkWithServices,
   userId: ID | null | undefined,
   playlistLibrary: PlaylistLibrary,
   queryClient: QueryClient,