Commit e822316
feat(genres): allow custom track genres (#14424)
Fresh branch off main — supersedes #14419.
## Summary
- Discovery indexer no longer rejects tracks whose genre isn't in the
hardcoded allowlist; just caps at 100 chars. The allowlist is retained
as a canonical reference for read-side trending/metrics scoping.
- SDK upload schemas for tracks, albums, and playlists changed from
`z.enum(Genre)` to `z.string().min(1).max(100)`. SDK regenerated from
updated swagger (generated `Genre` enum dropped). Manual `Genre` enum is
now the canonical export from `@audius/sdk` with PascalCase keys, plus a
new `GenreString = Genre | string` helper type.
- Web `SelectGenreField` rewritten from `<SelectField>` to `<TextField>`
+ native `<datalist>` — users can pick a known genre via autocomplete or
type a custom one. `maxLength=100` gives the built-in harmony character
counter.
Pairs with [AudiusProject/api
genres/custom](https://github.com/AudiusProject/api) — the Go API must
ship first (or together) so it stops rejecting custom-genre POSTs before
this indexer relaxation lands.
## What we deliberately did NOT change
- `index_trending.py` and `get_genre_metrics.py` still scope to
`genre_allowlist`. Custom-genre tracks silently won't appear in trending
or genre-metrics endpoints — intentional MVP cut.
- `packages/mobile` has its own genre picker that wasn't touched —
follow-up PR needed.
- No write-side normalization. "Hip-Hop" / "Hip Hop" / "hip hop" become
three distinct genres.
## Breaking change (browser dist only)
`packages/sdk/src/sdk/types/Genre.ts` keys changed from SCREAMING_SNAKE
to PascalCase to match the previously-generated enum that downstream
consumers all imported. External integrations referencing
`window.audiusSdk.Genre.HIP_HOP_RAP` etc. via the browser dist need to
update to `Genre.HipHopRap`.
## Test plan
- [x] `tsc --noEmit` in `packages/sdk` — clean
- [x] `vitest run` in `packages/sdk` — 17 files, 196 passed, 2 skipped
- [x] SDK regenerated via `node ./src/sdk/api/generator/gen.js --spec
<local-edited-swagger>` against the updated swagger
- [ ] Type a custom genre in the upload form, confirm it submits
- [ ] Existing known-genre flows still work
- [ ] Verify >100-char input is rejected client and server side
- [ ] Confirm no regression in trending/browse-by-genre for canonical
genres
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 7f36555 commit e822316
19 files changed
Lines changed: 163 additions & 208 deletions
File tree
- packages
- discovery-provider/src
- tasks/entity_manager
- entities
- utils
- sdk/src/sdk
- api
- albums
- generated/default
- .openapi-generator
- models
- playlists
- tracks
- types
- web/src/components/edit/fields
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
48 | | - | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
| 537 | + | |
538 | 538 | | |
539 | | - | |
| 539 | + | |
540 | 540 | | |
541 | 541 | | |
542 | 542 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
99 | 103 | | |
100 | 104 | | |
101 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
195 | 194 | | |
196 | 195 | | |
197 | 196 | | |
| |||
Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 40 | | |
47 | 41 | | |
48 | 42 | | |
| |||
93 | 87 | | |
94 | 88 | | |
95 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
96 | 99 | | |
97 | | - | |
| 100 | + | |
98 | 101 | | |
99 | 102 | | |
100 | | - | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
227 | 230 | | |
228 | 231 | | |
229 | 232 | | |
230 | | - | |
| 233 | + | |
231 | 234 | | |
232 | 235 | | |
233 | 236 | | |
| |||
262 | 265 | | |
263 | 266 | | |
264 | 267 | | |
265 | | - | |
| 268 | + | |
266 | 269 | | |
267 | 270 | | |
268 | 271 | | |
| |||
Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | 52 | | |
59 | 53 | | |
60 | 54 | | |
| |||
93 | 87 | | |
94 | 88 | | |
95 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
96 | 99 | | |
97 | | - | |
| 100 | + | |
98 | 101 | | |
99 | 102 | | |
100 | | - | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
370 | 373 | | |
371 | 374 | | |
372 | 375 | | |
373 | | - | |
| 376 | + | |
374 | 377 | | |
375 | 378 | | |
376 | 379 | | |
| |||
426 | 429 | | |
427 | 430 | | |
428 | 431 | | |
429 | | - | |
| 432 | + | |
430 | 433 | | |
431 | 434 | | |
432 | 435 | | |
| |||
Lines changed: 0 additions & 87 deletions
This file was deleted.
Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 40 | | |
47 | 41 | | |
48 | 42 | | |
| |||
87 | 81 | | |
88 | 82 | | |
89 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
90 | 93 | | |
91 | | - | |
| 94 | + | |
92 | 95 | | |
93 | 96 | | |
94 | | - | |
| 97 | + | |
95 | 98 | | |
96 | 99 | | |
97 | 100 | | |
| |||
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
222 | | - | |
| 225 | + | |
223 | 226 | | |
224 | 227 | | |
225 | 228 | | |
| |||
253 | 256 | | |
254 | 257 | | |
255 | 258 | | |
256 | | - | |
| 259 | + | |
257 | 260 | | |
258 | 261 | | |
259 | 262 | | |
| |||
0 commit comments