Commit f5844db
Refactor balance history graph to use dynamic width and daily granularity (#14106)
## Summary
This PR refactors the UserBalanceHistoryGraph component to dynamically
measure container width instead of accepting a fixed width prop, and
updates balance history queries to use daily granularity across both
mobile and web platforms.
## Key Changes
- **Dynamic Width Measurement**: Replaced the static `width` prop with
runtime layout measurement using `onLayout` callback on mobile, allowing
the graph to responsively adapt to its container
- **Layout State Management**: Added `containerWidth` state and
`handleLayout` callback to capture actual rendered dimensions before
chart rendering
- **Granularity Update**: Added `granularity: 'daily'` parameter to all
`useUserBalanceHistory` hook calls in both mobile and web
implementations
- **Tooltip Date Formatting**: Simplified `formatTooltipDate` function
to display date only (weekday short, month short, day) instead of
including time information
- **Prop Removal**: Removed `width` prop from `UserBalanceHistoryGraph`
and `AccountBalance` components, simplifying the component API
- **Render Guard**: Added early return to render empty Flex container
while waiting for layout measurement to complete
## Implementation Details
- Mobile implementation uses React Native's `LayoutChangeEvent` to
measure container width dynamically
- The chart only renders once `containerWidth > 0`, preventing layout
thrashing
- Web implementation maintains existing behavior while adopting the
daily granularity parameter
- All balance history queries now consistently use daily data
granularity for improved performance and consistency
https://claude.ai/code/session_01EP1m3UXR2bibGyXKUUUZqY
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 4c427f2 commit f5844db
File tree
4 files changed
+33
-31
lines changed- packages
- mobile/src/components
- account-balance
- user-balance-history-graph
- web/src/components
- account-balance
- user-balance-history-graph
4 files changed
+33
-31
lines changedLines changed: 3 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
| |||
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 30 | + | |
35 | 31 | | |
36 | 32 | | |
37 | 33 | | |
38 | 34 | | |
39 | 35 | | |
40 | | - | |
| 36 | + | |
41 | 37 | | |
42 | 38 | | |
43 | 39 | | |
| |||
148 | 144 | | |
149 | 145 | | |
150 | 146 | | |
151 | | - | |
| 147 | + | |
152 | 148 | | |
153 | 149 | | |
154 | 150 | | |
Lines changed: 23 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
51 | 50 | | |
52 | | - | |
53 | | - | |
| 51 | + | |
54 | 52 | | |
55 | 53 | | |
56 | 54 | | |
57 | | - | |
58 | 55 | | |
59 | 56 | | |
| 57 | + | |
60 | 58 | | |
61 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| |||
73 | 75 | | |
74 | 76 | | |
75 | 77 | | |
76 | | - | |
| 78 | + | |
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
| |||
179 | 181 | | |
180 | 182 | | |
181 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
182 | 191 | | |
183 | 192 | | |
184 | 193 | | |
| |||
188 | 197 | | |
189 | 198 | | |
190 | 199 | | |
191 | | - | |
| 200 | + | |
192 | 201 | | |
193 | 202 | | |
194 | 203 | | |
| |||
206 | 215 | | |
207 | 216 | | |
208 | 217 | | |
209 | | - | |
| 218 | + | |
210 | 219 | | |
211 | 220 | | |
212 | 221 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
Lines changed: 6 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
55 | 52 | | |
56 | 53 | | |
57 | 54 | | |
| |||
232 | 229 | | |
233 | 230 | | |
234 | 231 | | |
235 | | - | |
| 232 | + | |
236 | 233 | | |
237 | 234 | | |
238 | 235 | | |
| |||
0 commit comments