Skip to content

Add email+password recovery mode with lookup-key gating#13897

Merged
raymondjacobson merged 3 commits into
mainfrom
codex/rj-cred-change
Mar 11, 2026
Merged

Add email+password recovery mode with lookup-key gating#13897
raymondjacobson merged 3 commits into
mainfrom
codex/rj-cred-change

Conversation

@raymondjacobson
Copy link
Copy Markdown
Member

@raymondjacobson raymondjacobson commented Mar 11, 2026 •
edited
Loading

image

Summary

  • support mode=emailpassword recovery links by prompting for new email + password
  • gate auto-open reset flow on required params:
    • mode=password (or warning=RECOVERY_DO_NOT_SHARE) requires email
    • mode=emailpassword requires lookupKey
  • pass lookupKey through reset flow as oldLookupKey
  • defer browser-push confirmation until password-reset flow is finished (so push modal no longer overlays the recovery modal)
  • preserve backwards compatibility for legacy localStorage payloads
  • fix password-reset saga so success is not dispatched after a failed reset attempt

Validation

  • cd packages/web && npx eslint src/components/password-reset/PasswordResetModal.tsx src/components/password-reset/store/actions.ts src/components/password-reset/store/sagas.tsx src/common/store/pages/signon/sagas.ts
  • cd packages/common && npx eslint src/services/auth/authService.ts
  • cd packages/web && npm run typecheck (fails due existing unrelated error in src/pages/oauth-login-page/hooks.ts(50,21): TS18047)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 11, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: c6a648b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 11, 2026 •
edited
Loading

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-13897.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

dylanjeffers
dylanjeffers approved these changes Mar 11, 2026
View reviewed changes
Comment thread packages/web/src/common/store/pages/signon/sagas.ts
} else {
setHasRequestedBrowserPermission()
while (hasPendingPasswordReset()) {
yield* delay(500)
Copy link
Copy Markdown
Contributor

@dylanjeffers dylanjeffers Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this do?

Copy link
Copy Markdown
Member Author

@raymondjacobson raymondjacobson Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two modals popping up at once

Comment thread packages/web/src/components/password-reset/store/sagas.tsx
password: action.password,
oldLookupKey: action.lookupKey
})
yield put(actions.changePasswordSucceeded())
Copy link
Copy Markdown
Contributor

@dylanjeffers dylanjeffers Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

Comment thread packages/web/src/components/password-reset/PasswordResetModal.tsx
)
)

const decodeIfEncoded = (value: string) => {
Copy link
Copy Markdown
Contributor

@dylanjeffers dylanjeffers Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have utilities out there, but all good

Copy link
Copy Markdown
Member Author

@raymondjacobson raymondjacobson Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like not!

@raymondjacobson raymondjacobson merged commit b9e3a1b into main Mar 11, 2026
14 checks passed
@raymondjacobson raymondjacobson deleted the codex/rj-cred-change branch March 11, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raymondjacobson @dylanjeffers