Fix $AUDIO wallet history loading failure on tip transactions#14103
Closed
cursor[bot] wants to merge 1 commit intomainfrom
Closed
Fix $AUDIO wallet history loading failure on tip transactions#14103cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
|
Member
|
Im just going to fix this with my other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$AUDIO Transactionsparsing to supporttiptransaction types returned by the backendTIPto shared transaction types and map SDKtransactionType: 'tip'in the common adapterTIPentries cleanlyRoot Cause
The transaction adapter in
@audius/commonthrewUnknown Transactionfor backendtiphistory rows. That exception caused repeated query retries (long loading spinner) and eventual empty-state fallback in the wallet history UI.Testing
npm run test -w @audius/common -- src/adapters/audioTransactions.test.ts --runvitestbinary is unavailable (sh: 1: vitest: not found)