[Cleanup] Remove live email frequency; fix broken email images#14288
Merged
Conversation
Instruments three key contest interactions following the existing
'Remix Contest:' event prefix and {remixContestId, trackId} property
shape used by the host/pick-winners events:
- REMIX_CONTEST_VIEW: contest page/screen first resolves trackId+eventId
- REMIX_CONTEST_ENTER: user taps Enter Contest / Upload Remix
- REMIX_CONTEST_VIEW_SUBMISSIONS: user opens the submissions tab
Mobile submissions-tab firing uses useFocusedTab from
react-native-collapsible-tab-view because the contest tabs mount
eagerly (lazy: false) — a plain mount effect would fire even for
users who only view the Details tab.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop the 'live' option from the EmailFrequency enum and the three UI surfaces (desktop notif modal, mobile settings page, RN row). Update the identity-service UserNotificationSettings model: remove 'live' from the enum and flip defaultValue 'live' -> 'daily'. Add an inverse Sequelize migration that updates existing rows live -> daily on both UserNotificationSettings and NotificationEmails and flips PG column defaults back to 'daily'; the enum value itself is left orphaned since Postgres can't drop enum labels without root access. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
6 tasks
dylanjeffers
added a commit
to AudiusProject/pedalboard
that referenced
this pull request
May 11, 2026
) PART 1 — Remove "live" email frequency: - broadcastEmailAnnouncements in announcement.ts now targets every deliverable, non-abusive user whose emailFrequency is set and not 'off' (previously only frequency='live' users). New helper UserNotificationSettings#shouldSendEmail backs this. - Strip dead per-event live-email blocks from ~25 mappers (sendNotificationEmail with frequency='live' was gated by the optimizely live-email plugin, which has been off in production). - Remove isLiveEmailEnabled parameter from BaseNotification's processNotification signature and from every mapper's destructured args (including DM mappers that never used it). - Remove getIsLiveEmailEnabled from AppNotificationsProcessor and stop passing isLiveEmailEnabled to processNotification calls (indexAppNotifications.ts, tasks/dmNotifications.ts). - Drop EmailPluginMappings.Live (and its remote-config diagnostics block). The optimizely flag is no longer read. - Clean up dead 'live'-frequency branches in email/notifications/index.ts (getUsersCanNotifyQuery's 'orWhere live' fallback for daily, the 'live'-only message-id narrowing in getNotifications, and the frequency !== 'live' sendAt ternary in processGroupOfEmails). - Update UserNotificationSettings#getUserEmailFrequency default from 'live' to 'daily'. PART 2 — Fix broken email images: - Body.tsx: replace the 403'd gallery.mailchimp.com/.../b1070e55-...png logo with the in-pattern download.audius.co/static-resources/email/ grayLogoHorizontal.png asset. Refresh affected snapshots. - renderEmail.ts: getTrackCoverArt and getPlaylistImage now fall back to getContentNode() (the stable CN gateway) when the owner's creator_node_endpoint is missing, instead of returning an empty string. Mirrors getUserProfileUrl, which already does this. Companion to apps PR AudiusProject/apps#14288; must merge together. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…Page Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14288.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note: This PR is one of two. The companion changes live in the
pedalboardrepo (broadcastEmailAnnouncements rewrite, per-event live-email cleanup across all mappers, the broken-logo + missing-cover-art image fixes). They must merge together.PART 1 — Remove the "live" email frequency option
PART 2
In the pedalboard PR.
Test plan
🤖 Generated with Claude Code