Skip to content

Fix mobile track artist centering#14488

Merged
raymondjacobson merged 4 commits into
mainfrom
codex/fix-mobile-track-artist-centering
Jun 17, 2026
Merged

Fix mobile track artist centering#14488
raymondjacobson merged 4 commits into
mainfrom
codex/fix-mobile-track-artist-centering

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep the mobile track-page artist names visually centered under the title while still showing user badges in a separate centered badge row.
  • Show accepted collaborators in mobile feed track rows as comma-separated artist names, with one-line ellipsis behavior when the row is too long.
  • Preserve badges in feed rows for both the owner and accepted collaborators.
  • Add focused unit tests for centered artist badge rendering plus artist-name composition.

Test Plan

  • /usr/local/bin/node ../../node_modules/.bin/jest src/components/user-link/TrackArtists.test.tsx src/components/lineup-tile/artistNames.test.ts --moduleNameMapper='{"^react-native$":"<rootDir>/../../node_modules/react-native","^@testing-library/react-native$":"<rootDir>/node_modules/@testing-library/react-native"}'
  • /usr/local/bin/node ../../node_modules/.bin/eslint --cache --ext=js,jsx,ts,tsx src/components/user-link/UserLink.tsx src/components/user-link/TrackArtists.tsx src/components/user-link/TrackArtists.test.tsx src/screens/track-screen/TrackScreenDetailsTile.tsx src/components/track/TrackCard.tsx src/components/lineup-tile/TrackTile.tsx src/components/lineup-tile/LineupTileMetadata.tsx src/components/lineup-tile/styles.ts src/components/lineup-tile/artistNames.ts src/components/lineup-tile/artistNames.test.ts
  • /usr/local/bin/node ../../node_modules/.bin/tsc --noEmit

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 16f0219

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson force-pushed the codex/fix-mobile-track-artist-centering branch from 8d736e5 to 74e7358 Compare June 17, 2026 00:25
@pull-request-size pull-request-size Bot added size/L and removed size/M labels Jun 17, 2026
@raymondjacobson raymondjacobson force-pushed the codex/fix-mobile-track-artist-centering branch from 74e7358 to cb31580 Compare June 17, 2026 16:53
@raymondjacobson raymondjacobson merged commit 26a673b into main Jun 17, 2026
3 checks passed
@raymondjacobson raymondjacobson deleted the codex/fix-mobile-track-artist-centering branch June 17, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant