Generate projects.zip in ant task; a little template cleanup#5
Open
picomancer wants to merge 4 commits into
Open
Generate projects.zip in ant task; a little template cleanup#5picomancer wants to merge 4 commits into
picomancer wants to merge 4 commits into
Conversation
added 4 commits
November 22, 2013 18:20
find src/projects -name "*.java" -print0 | xargs -0 sed -i '' -e 's/[[:space:]]*$//'
find src/projects -name "*.java" -print0 | xargs -0 sed -i -e '$a\'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a big patch, but really it's a very simple and straightforward set of changes that only took about 20 minutes to write.
The first commit was created by unzipping projects.zip, then I did git add the unzipped files and git rm projects.zip. In the same commit, I made a simple ant task to create projects.zip in the bin/res/ directory. The run-time behavior is the same as before.
Then I applied a few very minor style fixes to the templates, namely removing trailing whitespace from every line, ensuring each source file ends with a newline, and removing a space between the function name and parameter list in the two functions in GwtLauncher.java (making the coding style consistent with the other source files in the template).
The advantage of tracking individual source files instead of a zip file is that the template files are now individually tracked in version control. You can easily patch them and see the resulting changes with standard tools like git diff, git log with --stat or --patch options, or the Github user interface.
Casual testing with my changes (creating a single new project) seems to work.
Thanks