fix(proxy): Throw auto-login through whatever next server join

Author: Xephi

authme-velocity/src/main/java/fr/xephi/authme/velocity/VelocityProxyBridge.java

@@ -291,15 +291,6 @@ void onServerConnected(ServerConnectedEvent event) {
         }
 
         boolean connectingToAuthServer = configuration.isAuthServer(event.getServer());
-        boolean leavingAuthServer = event.getPreviousServer()
-            .map(configuration::isAuthServer).orElse(false);
-        logger.debug("autoLogin check for {}: connectingToAuth={}, leavingAuth={}", playerName,
-            connectingToAuthServer, leavingAuthServer);
-
-        if (!connectingToAuthServer && !leavingAuthServer) {
-            logger.debug("Skipping auto-login for {} — server transition not involving an auth server", playerName);
-            return;
-        }
 
         String normalizedName = normalizeName(playerName);
 

authme-velocity/src/test/java/fr/xephi/authme/velocity/VelocityProxyBridgeTest.java

@@ -326,7 +326,19 @@ void shouldDisconnectPlayerOnInitialJoinToNonAuthServerWhenSwitchRequiresAuth()
     }
 
     @Test
-    void shouldNotForwardPerformLoginToNonAuthServers() {
+    void shouldNotForwardPerformLoginForUnauthenticatedPlayer() {
+        given(player.getUsername()).willReturn("Alice");
+        given(nonAuthServer.getServerInfo()).willReturn(nonAuthServerInfo);
+        given(nonAuthServerInfo.getName()).willReturn("survival");
+
+        VelocityProxyBridge bridge = new VelocityProxyBridge(proxyServer, logger, createConfiguration(), new VelocityAuthenticationStore());
+        bridge.onServerConnected(new ServerConnectedEvent(player, nonAuthServer, null));
+
+        verify(currentServer, never()).sendPluginMessage(any(), any(byte[].class));
+    }
+
+    @Test
+    void shouldForwardPerformLoginWhenSwitchingFromAuthServerToNonAuthServer() {
         given(pluginMessageEvent.getResult()).willReturn(PluginMessageEvent.ForwardResult.forward());
         given(pluginMessageEvent.getIdentifier()).willReturn(VelocityProxyBridge.AUTHME_CHANNEL);
         given(pluginMessageEvent.getSource()).willReturn(sourceConnection);
@@ -336,12 +348,18 @@ void shouldNotForwardPerformLoginToNonAuthServers() {
         given(authServerInfo.getName()).willReturn("lobby");
         given(nonAuthServer.getServerInfo()).willReturn(nonAuthServerInfo);
         given(nonAuthServerInfo.getName()).willReturn("survival");
+        given(player.getUsername()).willReturn("Alice");
+        given(player.getCurrentServer()).willReturn(Optional.of(currentServer));
+        given(currentServer.getServer()).willReturn(nonAuthServer);
+        given(currentServer.sendPluginMessage(eq(VelocityProxyBridge.AUTHME_CHANNEL), any(byte[].class)))
+            .willReturn(true);
 
         VelocityProxyBridge bridge = new VelocityProxyBridge(proxyServer, logger, createConfiguration(), new VelocityAuthenticationStore());
         bridge.onPluginMessage(pluginMessageEvent);
-        bridge.onServerConnected(new ServerConnectedEvent(player, nonAuthServer, null));
+        bridge.onServerConnected(new ServerConnectedEvent(player, nonAuthServer, authServer));
 
-        verify(currentServer, never()).sendPluginMessage(any(), any(byte[].class));
+        verify(currentServer).sendPluginMessage(eq(VelocityProxyBridge.AUTHME_CHANNEL), payloadCaptor.capture());
+        assertPerformLoginPayload(payloadCaptor.getValue(), "alice", "test-secret");
     }
 
     // --- Command blocking tests ---