[FIX] Seconds not properly prevented from being negative by olfek · Pull Request #1310 · Authenticator-Extension/Authenticator

olfek · 2024-09-17T00:29:03Z

The current code ...

Line 90 in 6511920

second += Number(UserSettings.items.offset) + 60;

... fails in these two examples:

0 - 61 + 60 < 0
59 - 120 + 60 < 0

The offset (middle value) can be as low as -300.

Authenticator/src/syncTime.ts

Line 27 in 6511920

if (Math.abs(offset) <= 300) {

So the least you can have is -241 (59 - 300), the + 60 is not enough to make a positive number.

Without this fix, in the examples given above, the effect will be:

Countdown circle animation may be out of sync with the current time step because animationDelay will be stuck at 0s.

Authenticator/src/components/Popup/EntryComponent.vue

Lines 22 to 29 in 6511920

    
                 <svg viewBox="0 0 16 16"> 
        
                   <circle 
        
                     cx="8" 
        
                     cy="8" 
        
                     r="4" 
        
                     v-bind:style="{ 
        
                       animationDuration: entry.period + 's', 
        
                       animationDelay: (sectorOffset % entry.period) + 's',

timeout class will never activate unless entry.period < 5 because the left side of the < condition will be stuck at entry.period.

Authenticator/src/components/Popup/EntryComponent.vue

Line 59 in 6511920

timeout: entry.period - (second % entry.period) < 5,

0 - 61 + 60 < 0 59 - 120 + 60 < 0 https://github.com/Authenticator-Extension/Authenticator/blob/6511920bac98576e3c97fe2d213b23e9dc899422/src/store/Accounts.ts#L90

olfek · 2024-09-17T15:32:37Z

Requesting review @Sneezry @mymindstorm

mymindstorm · 2024-09-17T22:43:40Z

It's on my to-do list, but might take me a while to get to this

olfek · 2024-10-04T11:59:17Z

🛎️🛎️🛎️ @Sneezry @mymindstorm

olfek · 2024-10-19T11:03:55Z

@mymindstorm 📟📟📟

mymindstorm

Thanks for your patience. Slight nitpicks, but otherwise good catch!

Co-authored-by: Brendan Early <mymindstorm@evermiss.net>

mymindstorm · 2024-10-21T01:04:44Z

It looks like I don't have permission to push to your branch to fix the lint issues.

olfek · 2024-10-21T06:54:48Z

@mymindstorm I've added you as a collaborator.

olfek · 2024-10-21T14:34:55Z

FYI, I've never been a fan of prettier, it's too opinionated. The actual code is important, how it's formatted can always be corrected later.

olfek · 2024-10-23T16:05:41Z

@mymindstorm I think we're good to go here

olfek · 2024-10-23T17:13:49Z

@mymindstorm ...

After running prettier with the --write option, I get this from git diff --stat :

 src/store/Accounts.ts | 79 +++++++++++++++++++++++++--------------------------
 1 file changed, 38 insertions(+), 41 deletions(-)

Would you like me to commit this? - It will pollute the PR diff a little, I await your decision.

mymindstorm · 2024-10-23T19:30:36Z

That doesn't seem right, have you tried running npm run chrome? It will automatically format it using our configs.

olfek · 2024-10-23T19:33:55Z

@mymindstorm You have collaborator access to my fork, can you take over from here?

olfek · 2024-10-23T19:37:49Z

@mymindstorm ...

That doesn't seem right, have you tried running npm run chrome? It will automatically format it using our configs.

I don't think you have any prettier configs (https://prettier.io/docs/en/configuration)

mymindstorm · 2024-10-23T19:47:53Z

When you use prettier outright instead of through npm run, depending on how your system is configured it might use a different version which may have different rules.

mymindstorm · 2024-10-23T19:48:17Z

I'll get to this when I can just am extremely busy.

olfek · 2024-10-23T19:57:39Z

@mymindstorm ...

When you use prettier outright instead of through npm run, depending on how your system is configured it might use a different version which may have different rules.

https://prettier.io/docs/en/configuration says

Prettier intentionally doesn’t support any kind of global configuration. This is to make sure that when a project is copied to another computer, Prettier’s behavior stays the same. Otherwise, Prettier wouldn’t be able to guarantee that everybody in a team gets the same consistent results.

olfek · 2024-10-23T19:59:52Z

@mymindstorm ...

I propose temporarily (or permanently?) suspending the Prettier CI step until you set up a config file.

olfek · 2024-11-08T14:22:26Z

@mymindstorm ...

After running prettier with the --write option, I get this from git diff --stat :
 src/store/Accounts.ts | 79 +++++++++++++++++++++++++--------------------------
 1 file changed, 38 insertions(+), 41 deletions(-)
Would you like me to commit this? - It will pollute the PR diff a little, I await your decision.

@mymindstorm ...

So ... I was getting a big diff because I was using npx to run prettier like this:

npx prettier --check ./src/* ./src/**/* ./src/**/**/* ./sass/*.scss

... without running npm install, meaning the latest version of prettier (3.3.3) was being used instead of the package.json declared 2.2.1.

The default rules have changed since 2.2.1. See:

https://github.com/prettier/prettier/blob/2.2.1/src/language-js/options.js
https://github.com/prettier/prettier/blob/3.3.3/src/language-js/options.js

https://github.com/prettier/prettier/blob/2.2.1/src/main/core-options.js
https://github.com/prettier/prettier/blob/3.3.3/src/main/core-options.evaluate.js

olfek · 2024-11-08T14:30:00Z

@mymindstorm Can you run CI again?

olfek · 2024-11-18T13:05:36Z

@mymindstorm 📣📣📣

olfek · 2024-12-01T19:51:58Z

@mymindstorm If you're too busy to work on this project, you think maybe it's time to pass it on to someone who can?

mymindstorm · 2024-12-02T02:12:42Z

@mymindstorm If you're too busy to work on this project, you think maybe it's time to pass it on to someone who can?

Given the sensitive nature of this project, we aren't going to take into account external calls for new maintainers. We don't want to be the next xz.

Life happens and circumstances require me to put Authenticator on hold outside of high urgency tasks. We appreciate your contributions, and we're working to get them merged as soon as we can.

olfek · 2024-12-02T08:33:00Z

@mymindstorm

That was an interesting read, I didn't know about it, but with all due respect, there are probably more good cases of handing over the reins than bad, and the potential risks in unmaintained security software has far greater odds I would guess.

olfek · 2025-03-13T18:10:37Z

@mymindstorm @Sneezry 🔔 🔔 🔔

olfek added 3 commits September 17, 2024 00:58

[FIX] Seconds not properly prevented from being negative

9279d0b

0 - 61 + 60 < 0 59 - 120 + 60 < 0 https://github.com/Authenticator-Extension/Authenticator/blob/6511920bac98576e3c97fe2d213b23e9dc899422/src/store/Accounts.ts#L90

Remove the now redundant + 60

9480784

Move comment

737ac3f

mymindstorm reviewed Oct 21, 2024

View reviewed changes

Comment thread src/store/Accounts.ts Outdated

verbose is king

355f8b9

Co-authored-by: Brendan Early <mymindstorm@evermiss.net>

mymindstorm approved these changes Oct 21, 2024

View reviewed changes

.prettierignore

a36b5d0

olfek mentioned this pull request Oct 23, 2024

[FIX] OTP type is ignored #1320

Open

prettier

802f89a

olfek mentioned this pull request Nov 8, 2024

Prettier is outdated #1335

Open

	<svg viewBox="0 0 16 16">
	<circle
	cx="8"
	cy="8"
	r="4"
	v-bind:style="{
	animationDuration: entry.period + 's',
	animationDelay: (sectorOffset % entry.period) + 's',

Conversation

olfek commented Sep 17, 2024

Uh oh!

olfek commented Sep 17, 2024

Uh oh!

mymindstorm commented Sep 17, 2024

Uh oh!

olfek commented Oct 4, 2024

Uh oh!

olfek commented Oct 19, 2024

Uh oh!

mymindstorm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mymindstorm commented Oct 21, 2024

Uh oh!

olfek commented Oct 21, 2024

Uh oh!

olfek commented Oct 21, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

mymindstorm commented Oct 23, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

mymindstorm commented Oct 23, 2024

Uh oh!

mymindstorm commented Oct 23, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

olfek commented Oct 23, 2024

Uh oh!

olfek commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olfek commented Nov 8, 2024

Uh oh!

olfek commented Nov 18, 2024

Uh oh!

olfek commented Dec 1, 2024

Uh oh!

mymindstorm commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olfek commented Dec 2, 2024

Uh oh!

olfek commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olfek commented Nov 8, 2024 •

edited

Loading

mymindstorm commented Dec 2, 2024 •

edited

Loading