Skip to content

[FIX] OTP type is ignored#1320

Open
olfek wants to merge 5 commits into
Authenticator-Extension:devfrom
olfek:fix-otp-type-ignored
Open

[FIX] OTP type is ignored#1320
olfek wants to merge 5 commits into
Authenticator-Extension:devfrom
olfek:fix-otp-type-ignored

Conversation

@olfek

@olfek olfek commented Oct 1, 2024

Copy link
Copy Markdown

Alternative proposal to - #1283

@olfek

olfek commented Oct 1, 2024

Copy link
Copy Markdown
Author

Requesting review @Sneezry @mymindstorm

@olfek

olfek commented Oct 4, 2024

Copy link
Copy Markdown
Author

🛎️🛎️🛎️ @Sneezry @mymindstorm

@mymindstorm

Copy link
Copy Markdown
Member

Earliest I might have time to look at this is Sunday.

@olfek

olfek commented Oct 9, 2024

Copy link
Copy Markdown
Author

@mymindstorm How about this Sunday?

@olfek

olfek commented Oct 19, 2024

Copy link
Copy Markdown
Author

@mymindstorm 📟📟📟

@mymindstorm

Copy link
Copy Markdown
Member

@Sneezry could you look at this one?

olfek added 2 commits October 23, 2024 18:54
TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.
@olfek

olfek commented Oct 23, 2024

Copy link
Copy Markdown
Author

@mymindstorm ...

Can you run CI again, I've fixed the build error, we should only have prettier warnings left, which I will address once you make the decision on #1310 (comment) (same problem of diff pollution applies here).

EDIT
see - #1310 (comment)

@olfek

olfek commented Nov 8, 2024

Copy link
Copy Markdown
Author

@mymindstorm Can you run CI again here too?

@olfek

olfek commented Nov 18, 2024

Copy link
Copy Markdown
Author

@mymindstorm 📣📣📣

@Sneezry

Sneezry commented Dec 5, 2024

Copy link
Copy Markdown
Member

@Sneezry could you look at this one?

Over the past few weeks, I’ve been occupied with changes in the organizational structure at work. For the final two weeks of this year, I’ll need to be on-call 24/7. In January, I’ll take an extended break for Chinese New Year, the most important holiday in China. I plan to start addressing existing issues and pull requests in February next year.

@olfek

olfek commented Dec 5, 2024

Copy link
Copy Markdown
Author

@mymindstorm @Sneezry With all due respect, a PR of this size would take no more than 30 minutes to review, 1 hour at most.

@olfek

olfek commented Mar 13, 2025

Copy link
Copy Markdown
Author

@mymindstorm @Sneezry 🔔 🔔 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants