Skip to content

Commit 0380a09

Browse files
committed
Remove Space so nav links are only triggerable by Enter for now.
1 parent 8a74fae commit 0380a09

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/templates/expanded-endpoint-template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export function expandedTagTemplate(tagId, subsectionFullId) {
111111
<div class='nav-bar-paths-under-tag' style="max-width: 300px">
112112
${tag.paths.map((p) => html`
113113
<div class='nav-bar-path ${this.usePathInNavBar ? 'small-font' : ''}' role="link" tabindex="0"
114-
data-content-id='${p.elementId}' id='link-${p.elementId}' @click = '${(e) => { this.scrollToEventTarget(e, false); }}' @keydown = '${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}'>
114+
data-content-id='${p.elementId}' id='link-${p.elementId}' @click = '${(e) => { this.scrollToEventTarget(e, false); }}' @keydown = '${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}'>
115115
<span style="${p.deprecated ? 'filter:opacity(0.5)' : ''}">
116116
${this.usePathInNavBar
117117
? html`<div class='mono-font' style="display: flex; align-items: center;">

src/templates/navbar-template.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,19 +62,19 @@ export default function navbarTemplate() {
6262
${html`<nav class='nav-scroll' part="navbar-scroll">
6363
${(this.hideInfo || !this.resolvedSpec.info)
6464
? ''
65-
: html`<div class='nav-bar-info' id='link-overview' data-content-id='overview' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}';
65+
: html`<div class='nav-bar-info' id='link-overview' data-content-id='overview' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}';
6666
}>
6767
${this.resolvedSpec.info.title || getI18nText('menu.overview')}
6868
</div>`
6969
}
7070
7171
${this.hideServerSelection
7272
? ''
73-
: html`<div class='nav-bar-info' id='link-servers' data-content-id='servers' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}'> ${getI18nText('menu.api-servers')} </div>`
73+
: html`<div class='nav-bar-info' id='link-servers' data-content-id='servers' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}'> ${getI18nText('menu.api-servers')} </div>`
7474
}
7575
${(this.hideAuthentication || !this.resolvedSpec.securitySchemes)
7676
? ''
77-
: html`<div class='nav-bar-info' id='link-auth' data-content-id='auth' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}'> ${getI18nText('menu.authentication')} </div>`
77+
: html`<div class='nav-bar-info' id='link-auth' data-content-id='auth' @click = '${(e) => this.scrollToEventTarget(e, false)}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}'> ${getI18nText('menu.authentication')} </div>`
7878
}
7979
8080
<slot name="nav-section" class="custom-nav-section" data-content-id='section' @click = '${(e) => this.scrollToCustomNavSectionTarget(e, false)}'></slot>
@@ -105,7 +105,7 @@ export default function navbarTemplate() {
105105
: html`
106106
<div class='nav-bar-tag' id="link-${tag.elementId}" data-content-id='${tag.elementId}' role="link" tabindex="0"
107107
@click='${e => { onExpandCollapseTag.call(this, e, tag.elementId); }}'
108-
@keydown='${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}'
108+
@keydown='${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}'
109109
>
110110
111111
<div style="display: flex; justify-content: space-between; width: 100%;">
@@ -132,7 +132,7 @@ export default function navbarTemplate() {
132132
<!-- Paths in each tag (endpoints) -->
133133
${tag.paths.filter((v) => pathIsInSearch(this.matchPaths, v)).map((p) => html`
134134
<div class='nav-bar-path ${this.usePathInNavBar ? 'small-font' : ''}'
135-
data-content-id='${p.elementId}' id='link-${p.elementId}' @click = '${(e) => { this.scrollToEventTarget(e, false); }}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter', 'Space'].includes(e.key)) { e.target.click(); }}}'>
135+
data-content-id='${p.elementId}' id='link-${p.elementId}' @click = '${(e) => { this.scrollToEventTarget(e, false); }}' role="link" tabindex="0" @keydown = '${(e) => { if (['Enter'].includes(e.key)) { e.target.click(); }}}'>
136136
<span style="${p.deprecated ? 'filter:opacity(0.5)' : ''}">
137137
${this.usePathInNavBar
138138
? html`<div class='mono-font' style="display: flex; align-items: center;">
@@ -175,7 +175,7 @@ export default function navbarTemplate() {
175175
this.scrollToEventTarget(e, false);
176176
}}"
177177
@keydown="${(e) => {
178-
if (['Enter', 'Space'].includes(e.key)) {
178+
if (['Enter'].includes(e.key)) {
179179
e.target.click();
180180
}
181181
}}">

0 commit comments

Comments
 (0)