fix(params): properly order params (fixes mgcrea#15)

Author: mgcrea

.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extends": "airbnb/base",
+  "extends": "airbnb-base",
   "parser": "babel-eslint",
   "rules": {
     "object-curly-spacing": [2, "never"],

package.json

@@ -25,11 +25,10 @@
     "babel-plugin-transform-object-rest-spread": "^6.8.0",
     "babel-preset-es2015": "^6.9.0",
     "babel-register": "^6.9.0",
-    "codeclimate-test-reporter": "^0.3.1",
+    "codeclimate-test-reporter": "^0.3.2",
     "eslint": "^2.11.1",
-    "eslint-config-airbnb": "^9.0.1",
+    "eslint-config-airbnb-base": "^3.0.1",
     "eslint-plugin-import": "^1.8.1",
-    "eslint-plugin-jsx-a11y": "^1.2.2",
     "expect": "^1.20.1",
     "mocha": "^2.5.3",
     "nyc": "^6.4.4",

src/index.js

@@ -30,7 +30,7 @@ export default function exec(action, maybeBuffer, maybeOptions, maybeCallback) {
   }
 
   // Build initial params with passed action
-  const params = action.split('.').map((value, key) => (!key ? value : `-${value}`));
+  let params = action.split('.').map((value, key) => (!key ? value : `-${value}`));
   const lastParams = [];
   Object.keys(options).forEach(key => {
     if (options[key] === false) {
@@ -47,8 +47,8 @@ export default function exec(action, maybeBuffer, maybeOptions, maybeCallback) {
       }
     }
   });
-
-  params.concat(lastParams);
+  // Append last params
+  params = params.concat(lastParams);
 
   // Actually spawn openssl command
   const openssl = spawn('openssl', params);

test/index.spec.js

@@ -15,9 +15,9 @@ describe('openssl-wrapper', () => {
       done();
     });
   });
-  it('should support cms.verify action', (done) => {
+  it('should support smime.verify action', (done) => {
     const buffer = fs.readFileSync(`${__dirname}/fixtures/signed.mobileprovision`);
-    opensslWrapper('cms.verify', buffer, {inform: 'DER', noverify: true}, (err, obj) => {
+    opensslWrapper('smime.verify', buffer, {inform: 'DER', noverify: true}, (err, obj) => {
       expect(err).toBe(null);
       expect(obj).toBeA(Buffer);
       done();