Code quality: Simplify the initialization of Log and remove unnecessary Nuget packages (#1206)

* Code quality: Simplify the part of initializing Log in Program

* Code quality: Remove NLog.Schema because NLog.config is not used

Author: ChenYiLins

AutoDarkModeSvc/AutoDarkModeSvc.csproj

@@ -63,7 +63,6 @@
     <PackageReference Include="Microsoft.Toolkit.Uwp.Notifications" Version="7.1.3" />
     <PackageReference Include="Microsoft.VisualStudio.VsixColorCompiler" Version="17.11.35325.10" />
     <PackageReference Include="NLog" Version="6.0.4" />
-    <PackageReference Include="NLog.Schema" Version="6.0.4" />
     <PackageReference Include="System.Drawing.Common" Version="9.0.9" />
     <PackageReference Include="System.Management" Version="9.0.12" />
     <PackageReference Include="System.Runtime.InteropServices" Version="4.3.0" />

AutoDarkModeSvc/Core/LoggerSetup.cs

@@ -15,6 +15,7 @@
 //  along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #endregion
 using System;
+using System.Collections.Generic;
 using System.IO;
 using AutoDarkModeLib;
 using NLog;
@@ -44,29 +45,57 @@ public static class LoggerSetup
         "cleanNamesOfAsyncContinuations=true}: ${message} ${exception}"
     };
 
-    public static void UpdateLogmanConfig()
+    /// <summary>
+    /// Initialize logging based on command line arguments
+    /// </summary>
+    public static void InitializeLogging(List<string> args)
+    {
+        //Set up Logger
+        NLog.Config.LoggingConfiguration config = new();
+
+        // Rules for mapping loggers to targets
+        config.AddRule(LogLevel.Trace, LogLevel.Fatal, LoggerSetup.Logconsole);
+        if (args.Contains("/debug"))
+        {
+            config.AddRule(LogLevel.Debug, LogLevel.Fatal, LoggerSetup.Logfile);
+        }
+        else if (args.Contains("/trace"))
+        {
+            config.AddRule(LogLevel.Trace, LogLevel.Fatal, LoggerSetup.Logfile);
+        }
+        else
+        {
+            config.AddRule(LogLevel.Info, LogLevel.Fatal, LoggerSetup.Logfile);
+        }
+        // Apply config
+        LogManager.Configuration = config;
+    }
+
+    /// <summary>
+    /// Update logging configuration based on config file settings
+    /// </summary>
+    public static void UpdateLoggingFromConfig()
     {
         AdmConfigBuilder builder = AdmConfigBuilder.Instance();
         var config = new NLog.Config.LoggingConfiguration();
         config.AddRule(LogLevel.Trace, LogLevel.Fatal, Logconsole);
-        if (builder.Config.Tunable.Debug)
+
+        if (builder.Config.Tunable.Trace)
+        {
+            Logger.Info("enabling trace logs");
+            config.AddRule(LogLevel.Trace, LogLevel.Fatal, Logfile);
+        }
+        else if (builder.Config.Tunable.Debug)
         {
-            if (builder.Config.Tunable.Trace)
-            {
-                Logger.Info("enabling trace logs");
-                config.AddRule(LogLevel.Trace, LogLevel.Fatal, Logfile);
-            }
-            else
-            {
-                Logger.Info("enabling debug logs");
-                config.AddRule(LogLevel.Debug, LogLevel.Fatal, Logfile);
-            }
+            Logger.Info("enabling debug logs");
+            config.AddRule(LogLevel.Debug, LogLevel.Fatal, Logfile);
         }
         else
         {
             Logger.Info("enabling standard logging");
             config.AddRule(LogLevel.Info, LogLevel.Fatal, Logfile);
         }
+
         LogManager.Configuration = config;
     }
 }

AutoDarkModeSvc/Monitors/ConfigUpdateEvents/LoggingVerbosityEvent.cs

@@ -25,6 +25,6 @@ protected override void ChangeEvent()
     {
         bool debugToggled = newConfig.Tunable.Debug != oldConfig.Tunable.Debug;
         bool traceToggled = newConfig.Tunable.Trace != oldConfig.Tunable.Trace;
-        if (debugToggled || traceToggled) LoggerSetup.UpdateLogmanConfig();
+        if (debugToggled || traceToggled) LoggerSetup.UpdateLoggingFromConfig();
     }
 }