refactor: potential nullreferenceexception in basesettings constructor (#1212)

The constructor of `BaseSettings<T>` uses `Activator.CreateInstance(typeof(T))` to initialize the `Component` property. If `T` does not have a parameterless constructor or if `T` is an interface or abstract class, this will throw an exception at runtime, potentially causing a crash.


Affected files: BaseSettings.cs

Signed-off-by: BachDEV <1437214+bachdev@users.noreply.github.com>
Co-authored-by: Sam <sam@spiritreader.eu>

Author: bachdev

AutoDarkModeLib/ComponentSettings/BaseSettings.cs

@@ -19,13 +19,12 @@
 
 namespace AutoDarkModeLib.ComponentSettings;
 
-public class BaseSettings<T> : ISwitchComponentSettings<T> where T : class
+public class BaseSettings<T> : ISwitchComponentSettings<T> where T : new()
 {
     public virtual bool Enabled { get; set; }
     public T? Component { get; set; }
     public BaseSettings()
-    {
-        if (typeof(T) == typeof(object)) Component = null;
-        else Component = (T)Activator.CreateInstance(typeof(T));
+    {
+        Component = new T();
     }
 }