Refactoring, starting with folders and a way to create a release#26
Refactoring, starting with folders and a way to create a release#26
Conversation
|
Thank you @kanashius 👌 . I will have a deeper look later today. Few things to consider:
Don't get me wrong, you do a great job and your thoughts are very valuable. I guess we should increase the communication via GitHub issues where we discuss next steps before we introduce a PR 🤔 . Best regards |
|
I am not very good when it comes to organizing and refactoring. So I will leave that to you and Sven to figure out. Most of my AutoIt projects in my repo have a workflow file to build and put releases together. We can do something similar. |
|
Hi @kanashius , 🛎️ "ping" . |
|
Using github to create the release files is a good way to handle public releases, I think. I am also currently reworking the entire script, based on the original, when I started adding the processing in different processes. I tried to do that for the TreeListExplorer UDF, because that can also block the hole application and got into some issues. So some things have to switch to an event based system to trigger changes and react, when they are done and because I basically touch almost everything, I thought I could do a little restructuring/... as well.
|
This is actually a really good idea that I had never really thought about before. Having a local build for testing purposes and a public release flow on Github would both be good options to have.
This is very intriguing and exciting. This whole multi-process with IPC seems to open up a lot of possibilities. I was wondering if you would attempt to extend that to your TreeListExplorer UDF. I can imagine that is difficult and would require changes. But if successful, in the long run, Files Au3 will have much better performance. I noticed that loading of folders sometimes causing a flicker with the menubar as well. So I can see how it is sometimes blocking the overall script temporarily. If only AutoIt had multi-threading. But your multi-process can solve this.
This all sounds wonderful. I know from experience with you that when you are quiet for many days, that usually means that you are working very hard on it and don't usually write much until complete. You like to go quiet and come back with surprises and that is all good. Having a good base design will be important. It will especially help to attract more developers who want to help and make it easier for them to understand the code base. With all of the features that we have now and a restructured code base soon, that will put Files Au3 in good position for the future. Thank you for all of this work that you are putting into this. It will absolutely be worth it. |
|
Very nice Patrick 👌 . What do you think - should be keep this PR open or should we close it until you did your refactoring more complete? Both ways are fine in my opinions, but personally I suggest to push many small PRs instead of one big one, when you can do this. |
Description
Create a way to generate releases with the targets portable-x86, portable-x64 and src (the source code).
The result will be put into
Additionally, application resources now have their own folders, as assets contain documentation related things.
🚀 What is the new behavior?
Behaviour of the application is unchanged.
An additional script was added to generate releases.
Type of changes
Breaking changes 🔥
How and where was this tested?
🖥️ Describe where you tested your changes
System:
Context:
🔬 Describe how you tested your changes
Checklist
Additional context
Screenshots
Note to reviewers