This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Add jayh#7
Open
jayholliday wants to merge 3 commits into
Open
Conversation
…e is still probably in the bucket paging). Added filter field to return a filtered list of objects in the bucket when it's refreshed. Added a display manifest but to show an objects manifest which contains the status and potentially the reason the transformation failed.
…the issue is still probably in the bucket paging)." This reverts commit acf73da.
…e is still probably in the bucket paging). Added a sort to the treeview. Added a filter input text field that can be used to filter the objects in the buckets when the refresh buckets button is pressed. Added a show manifest button so you can see the object status, and more importantly, the reason if the translate failed.
Collaborator
|
@jayholliday tks for the PR and functionality wise everything looks great. Just two things:
|
Author
|
HI Bryan
Sorry about the multiple commits, this was my first post to a Github project that wasn’t a private repository that I already had access too. The first commit was a mistake and the second was to remove the first which I thought would remove it from the chain, operator error, the third commit is the only one that’s relevant. I’ll go back and figure out how to make the changes you’re asking for.
Thank you
Jay
From: Bryan Huang <notifications@github.com>
Sent: Monday, March 16, 2020 5:01 AM
To: Autodesk-Forge/forge-bucketsmanager-desktop <forge-bucketsmanager-desktop@noreply.github.com>
Cc: Jay Holliday <jayh@palittoconsulting.com>; Mention <mention@noreply.github.com>
Subject: Re: [Autodesk-Forge/forge-bucketsmanager-desktop] Add jayh (#7)
@jayholliday<https://github.com/jayholliday> tks for the PR and functionality wise everything looks great. Just two things:
* Remove the backup files from the PR - since all those are checked in developers can roll back to past commits if necessary
* Also fill out the description of your PR so ppl know what's changed/added (the ability to see the manifest apparently) since we'd be merging all these three commits when accepting the PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADBIUXF4565WLJFEOXRH32LRHXTENANCNFSM4KZ5JOKA>.
PCS and Affiliated Companies HIPAA Privacy Notification: This message and accompanying documents are covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, and contain information intended for the specified individual(s) only. This information is confidential. If you are not the intended recipient or an agent responsible for delivering it to the intended recipient, you are hereby notified that you have received this document in error and that any review, dissemination, copying, or the taking of any action based on the contents of this information is strictly prohibited. If you have received this communication in error, please notify us immediately by e-mail or phone at 330-335-7271 and delete the original message.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.