Skip to content

Commit 13719cc

Browse files
committed
EMSUSD-3870 - MAYA Integration : Fix lib name for RenderSetup
* Adapt to name changes in RenderSetup shared component. * Added missing ifdef to guard when not building with RS. * Rename RS test to be consistent with other shared component tests. * Update RS test to test python bindings.
1 parent 398a58c commit 13719cc

5 files changed

Lines changed: 33 additions & 9 deletions

File tree

cmake/modules/FindAdskUsdRenderSetup.cmake

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ message(STATUS "Finding Autodesk USD Render Setup")
1313

1414
find_path(ADSK_USD_RENDER_SETUP_INCLUDE_DIR
1515
NAMES
16-
RenderSetup/RenderSetupVersion.h
16+
AdskUsdRenderSetup/AdskUsdRenderSetupVersion.h
1717
HINTS
1818
$ENV{ADSK_USD_RENDER_SETUP_ROOT_DIR}
1919
${ADSK_USD_RENDER_SETUP_ROOT_DIR}
@@ -29,7 +29,7 @@ find_path(ADSK_USD_RENDER_SETUP_INCLUDE_DIR
2929

3030
find_library(ADSK_USD_RENDER_SETUP_LIBRARY
3131
NAMES
32-
RenderSetup
32+
AdskUsdRenderSetup
3333
HINTS
3434
$ENV{ADSK_USD_RENDER_SETUP_ROOT_DIR}
3535
${ADSK_USD_RENDER_SETUP_ROOT_DIR}
@@ -44,9 +44,10 @@ find_library(ADSK_USD_RENDER_SETUP_LIBRARY
4444
# Render Setup version
4545

4646
if(ADSK_USD_RENDER_SETUP_INCLUDE_DIR)
47+
set(adsk_rs_version_header "${ADSK_USD_RENDER_SETUP_INCLUDE_DIR}/AdskUsdRenderSetup/AdskUsdRenderSetupVersion.h")
4748
file(
4849
STRINGS
49-
${ADSK_USD_RENDER_SETUP_INCLUDE_DIR}/RenderSetup/RenderSetupVersion.h
50+
${adsk_rs_version_header}
5051
ADSK_USD_RENDER_SETUP_VERSION
5152
REGEX "define RENDER_SETUP_VERSION .*")
5253
if(ADSK_USD_RENDER_SETUP_VERSION)

lib/usd/ui/renderSetup/mayaEditCommitter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919

2020
#include <pxr/usd/usd/stage.h>
2121

22+
#include <AdskUsdRenderSetup/HostStage.h>
23+
#include <AdskUsdRenderSetup/IEditCommitter.h>
2224
#include <QtCore/QObject>
23-
#include <RenderSetup/HostStage.h>
24-
#include <RenderSetup/IEditCommitter.h>
2525

2626
#include <functional>
2727
#include <string>

lib/usd/ui/renderSetup/renderSetupWindowCmd.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include "mayaEditCommitter.h"
1919

2020
#include <mayaUsd/nodes/proxyShapeBase.h>
21-
#include <mayaUsd/nodes/usdSceneSettingsManager.h>
2221
#include <mayaUsd/ufe/Utils.h>
2322
#include <mayaUsd/utils/mayaNodeTypeObserver.h>
2423

@@ -34,23 +33,29 @@
3433
#include <maya/MSceneMessage.h>
3534
#include <maya/MSyntax.h>
3635

36+
#include <AdskUsdRenderSetup/RenderSetupWidget.h>
3737
#include <QtCore/QPointer>
3838
#include <QtCore/QTimer>
3939
#include <QtGui/QAction>
4040
#include <QtWidgets/QMainWindow>
4141
#include <QtWidgets/QMenuBar>
4242
#include <QtWidgets/QVBoxLayout>
43-
#include <RenderSetup/RenderSetupWidget.h>
4443

4544
#include <algorithm>
4645
#include <vector>
4746

47+
#ifdef MAYA_HAS_USD_SETTINGS_NODES
48+
#include <mayaUsd/nodes/usdSceneSettingsManager.h>
49+
#endif
50+
4851
namespace MAYAUSD_NS_DEF {
4952

5053
class RenderSetupWindow;
5154

52-
const MString RenderSetupWindowCmd::commandName("mayaUsdRenderSetupWindow");
55+
const MString RenderSetupWindowCmd::commandName("mayaUsdRenderSetupWindow");
56+
#ifdef MAYA_HAS_USD_SETTINGS_NODES
5357
const std::string kUSDRenderSettingsNodeName("UsdDefaultRenderSettings");
58+
#endif
5459

5560
namespace {
5661
constexpr auto kReloadFlag = "-rl";

test/lib/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ else()
113113
endif()
114114

115115
if (AdskUsdRenderSetup_FOUND)
116-
mayaUsd_get_unittest_target(target testUsdRenderSetup.py)
116+
mayaUsd_get_unittest_target(target testAdskUsdRenderSetup.py)
117117
mayaUsd_add_test(${target}
118118
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
119119
PYTHON_MODULE ${target}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import maya.cmds as cmds
2222
import maya.mel as mel
2323

24+
from mayaUsd.lib import UsdDefaultRenderSettings
25+
2426
class VerifyUsdRenderSetupTestCase(unittest.TestCase):
2527
""" Test the Usd Render Setup. """
2628

@@ -33,3 +35,19 @@ def setUpClass(cls):
3335
def testWindowCommandExists(self):
3436
# Verify that the render setup window command exists, which indicates that the render setup UI is available.
3537
self.assertTrue(mel.eval('exists mayaUsdRenderSetupWindow'))
38+
39+
def testPythonBindings(self):
40+
# Verify that we can load the python bindings and call at least one method.
41+
try:
42+
import AdskUsdRenderSetup as rs
43+
except ImportError as e:
44+
self.fail(f"Failed to import my_module: {e}")
45+
46+
self.assertEqual(rs.__name__, 'AdskUsdRenderSetup')
47+
self.assertTrue(rs.__version_info__ >= (0, 0, 1))
48+
49+
stage = UsdDefaultRenderSettings.getUsdStage()
50+
self.assertIsNotNone(rs.GetAllRenderSettingsPaths(stage))
51+
52+
prim = rs.GetActiveRenderSettings(stage)
53+
self.assertTrue(prim)

0 commit comments

Comments
 (0)