Skip to content

Commit 07d10b3

Browse files
committed
test update
1 parent 476dfa2 commit 07d10b3

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

scripts/generate_switcher.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,13 @@ def get_git_tags():
4949

5050
def parse_version_tags(tags):
5151
"""
52-
Filter tags to those matching strict X.Y.Z releases.
52+
Filter tags to those matching the required vX.Y.Z format.
5353
5454
Uses the same pattern as smv_tag_whitelist in docs/source/conf.py
5555
so that switcher.json stays in sync with the versions that
56-
sphinx-multiversion actually builds. Accepts both vX.Y.Z and X.Y.Z.
56+
sphinx-multiversion actually builds.
5757
58-
Returns the original tag strings (preserving any 'v' prefix).
58+
Returns the matching tag strings.
5959
"""
6060
version_tags = []
6161

tests/core/test_generate_switcher.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,19 @@
3737
@pytest.mark.scripts
3838
@pytest.mark.generate_switcher
3939
class TestParseVersionTags:
40-
"""Tests for tag filtering against the sphinx-multiversion whitelist."""
40+
"""Tests for tag filtering against the vX.Y.Z version tag pattern."""
4141

4242
def test_accepts_v_prefixed_tags(self):
4343
tags = ['v1.0.0', 'v2.3.4', 'v27.0.0']
4444
assert parse_version_tags(tags) == tags
4545

46-
def test_accepts_tags_without_v_prefix(self):
46+
def test_rejects_tags_without_v_prefix(self):
4747
tags = ['1.0.0', '2.3.4', '27.0.0']
48-
assert parse_version_tags(tags) == tags
48+
assert parse_version_tags(tags) == []
4949

50-
def test_accepts_mixed_prefix_tags(self):
50+
def test_filters_tags_without_v_prefix(self):
5151
tags = ['v1.0.0', '2.0.0', 'v3.1.2']
52-
assert parse_version_tags(tags) == tags
52+
assert parse_version_tags(tags) == ['v1.0.0', 'v3.1.2']
5353

5454
def test_rejects_prerelease_tags(self):
5555
tags = ['v1.0.0rc1', 'v1.0.0a1', 'v1.0.0b2']
@@ -70,7 +70,7 @@ def test_rejects_non_version_tags(self):
7070

7171
def test_filters_mixed_valid_and_invalid(self):
7272
tags = ['v1.0.0', 'v2.0.0rc1', 'latest', '3.0.0', 'v4.0.0.dev1']
73-
assert parse_version_tags(tags) == ['v1.0.0', '3.0.0']
73+
assert parse_version_tags(tags) == ['v1.0.0']
7474

7575
def test_empty_input(self):
7676
assert parse_version_tags([]) == []
@@ -95,9 +95,9 @@ def test_patch_ordering(self):
9595
tags = ['v1.0.2', 'v1.0.0', 'v1.0.1']
9696
assert sort_versions(tags) == ['v1.0.2', 'v1.0.1', 'v1.0.0']
9797

98-
def test_mixed_prefix_ordering(self):
99-
tags = ['1.0.0', 'v2.0.0', '3.0.0']
100-
assert sort_versions(tags) == ['3.0.0', 'v2.0.0', '1.0.0']
98+
def test_many_versions_ordering(self):
99+
tags = ['v1.0.0', 'v2.0.0', 'v3.0.0']
100+
assert sort_versions(tags) == ['v3.0.0', 'v2.0.0', 'v1.0.0']
101101

102102
def test_single_tag(self):
103103
assert sort_versions(['v1.0.0']) == ['v1.0.0']
@@ -138,10 +138,10 @@ def test_url_uses_tag_name(self, _):
138138
result = generate_switcher_json(['v1.0.0'])
139139
assert result[0]['url'] == '../v1.0.0/'
140140

141-
@patch(MOCK_VERSION_JSON, return_value='1.0.0')
142-
def test_url_preserves_no_v_prefix(self, _):
143-
result = generate_switcher_json(['1.0.0'])
144-
assert result[0]['url'] == '../1.0.0/'
141+
@patch(MOCK_VERSION_JSON, return_value='v1.0.0')
142+
def test_url_preserves_v_prefix(self, _):
143+
result = generate_switcher_json(['v1.0.0'])
144+
assert result[0]['url'] == '../v1.0.0/'
145145

146146
@patch(MOCK_VERSION_JSON, return_value='v2.0.0')
147147
def test_all_entries_have_required_keys(self, _):

0 commit comments

Comments
 (0)