Skip to content

Commit 2962989

Browse files
vjeevaclaude
andauthored
fix(tests): await _compare_sequences in integration test (#938)
_compare_sequences is async and contains the only assertion that src and dst sequence values match (assert src_val == dst_val), but both call sites in _ensure_same_data invoked it without await. The resulting coroutine was never run, so the assertion never fired and the integration test silently passed even when sync-sequences left sequences out of sync. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent bdd697a commit 2962989

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tests/integration/test_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ async def _ensure_same_data(configs: dict[str, DbupgradeConfig]):
461461
f"Ensuring {setname} source and destination sequences are the same..."
462462
)
463463

464-
_compare_sequences(
464+
await _compare_sequences(
465465
configs[
466466
setname
467467
].sequences, # In exodus-style migrations, we have our sequences defined in the config
@@ -496,7 +496,7 @@ async def _ensure_same_data(configs: dict[str, DbupgradeConfig]):
496496
.split("\n")
497497
)
498498

499-
_compare_sequences(
499+
await _compare_sequences(
500500
sequences, # In full migrations, we need to get the sequences from the source database
501501
configs[setname].src.root_dsn,
502502
configs[setname].dst.root_dsn,

0 commit comments

Comments
 (0)