fix: always move floating tag on push to master#33
Closed
Shubhank-Jonnada wants to merge 2 commits into
Closed
Conversation
The bootstrap logic checked if v2 already existed and skipped it, so the tag never moved after the initial creation. Now the push-to-master path always deletes and recreates the floating tag pointing at the current master HEAD.
Moving v2 on every master push is unsafe — consumers would get unrelased code. The release: published trigger is the correct signal that code is ready for consumers. Cut a release to move the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bootstrap logic in the push-to-master path checked if
v2already existed and skipped it:So after the initial
v2tag was created (pointing at2.0.3), it never moved when new fixes were merged to master.Fix
Remove the existence check — always delete and recreate the floating tag pointing at the current master HEAD on every push to master.
After merging this
v2will immediately move to the current master HEAD, and consumer repos on@v2will pick up all the fixes that have been merged.