Skip to content

fix: follow helper input access in config sync#43

Merged
TheRealAgentK merged 1 commit into
masterfrom
fix/config-sync-helper-input-access
Jun 23, 2026
Merged

fix: follow helper input access in config sync#43
TheRealAgentK merged 1 commit into
masterfrom
fix/config-sync-helper-input-access

Conversation

@TheRealAgentK

Copy link
Copy Markdown
Collaborator

Summary

Fixes a false positive in check_config_sync.py where schema parameters accessed through simple module-local helpers were reported as unused.

The checker now preserves direct execute() scanning and additionally follows statically named module-local helper calls when an action passes its inputs object, for patterns like _pagination_params(inputs).

Scope

  • Supports helper parameter aliases such as action_inputs.
  • Preserves direct vs .get() classification for required/optional consistency checks.
  • Keeps analysis intentionally limited to module-local functions with static names.
  • Does not analyze imported functions, method calls, dynamic calls, nested closures, or complex control flow.

Tests

  • Added focused pytest regressions for direct access, helper-only access, helper required/optional classification, non-calling action isolation, and new-integration fatal drift behavior.
  • Wired the focused pytest regressions into the self-test workflow.
  • Updated the config-sync docs to describe the limited helper-call support.

Validation

  • .venv/bin/pytest tests/test_check_config_sync.py
  • .venv/bin/ruff check scripts/check_config_sync.py tests/test_check_config_sync.py
  • .venv/bin/ruff format --check scripts/check_config_sync.py tests/test_check_config_sync.py
  • From autohive-integrations: .venv/bin/python ../autohive-integrations-tooling/scripts/check_code.py --base-ref origin/master missive

@Olwiba Olwiba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice set of changes :)

@TheRealAgentK TheRealAgentK merged commit b646afa into master Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants