fix(google-ads): fix campaign and keyword metrics validation errors and ROAS calculations#167
Merged
Merged
Conversation
…ata format
- Wrap retrieve_campaign_metrics response in {"results": ...} to match the
expected output schema (fixes ValidationError in production)
- Apply the same fix to retrieve_keyword_metrics (same issue)
- Default cost_micros to 0 instead of 1 when missing, preventing incorrect
Return On Ad Spend calculations
ProRedCat
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Updates
👉 Wrapped
retrieve_campaign_metricsandretrieve_keyword_metricsresponses in{"results": ...}object to match expected output schema and fix production ValidationError👉 Changed default
cost_microsvalue from 1 to 0 when missing to prevent incorrect Return On Ad Spend (ROAS) calculations👉 Applied consistent response format across both campaign and keyword metrics endpoints
Screenshots
N/A
Test plan
retrieve_campaign_metricsaction with valid customer ID and verify response format matches{"results": [...]}schemaretrieve_keyword_metricsaction with valid parameters and verify response format is correctAuthor(s) to check