docs(skills): make destructive-test invocation safer by default#41
Open
TheRealAgentK wants to merge 1 commit into
Open
docs(skills): make destructive-test invocation safer by default#41TheRealAgentK wants to merge 1 commit into
TheRealAgentK wants to merge 1 commit into
Conversation
Pytest's -m flag is additive, so 'pytest -m integration' selects every test marked 'integration' — including those also marked 'destructive'. The previous skill text presented all three invocations equally, which encouraged PR descriptions and READMEs to recommend the bare '-m integration' form (the dangerous one). This change: - Adds a callout in 'When to Use' explaining that the destructive marker does NOT auto-exclude tests from -m integration - Reframes 'Running Commands' so the safe command is the documented default, with a leading warning - Adds a new 'Documenting How to Run' subsection prescribing PR description / README conventions - Appends a step 9 to the workflow checklist for documenting the run commands
Coverage —
|
| File | Stmts | Miss | Cover | Missing |
|---|---|---|---|---|
src/autohive_integrations_sdk/__init__.py |
2 | 0 | 100% | |
src/autohive_integrations_sdk/integration.py |
358 | 0 | 100% |
NinosMan
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest's
-mflag is additive:pytest -m integrationmatches every test markedintegration, including those also markeddestructive. The previous skill text presented all three invocations equally, which encouraged PR descriptions and integration READMEs to recommend the bare-m integrationform — the dangerous one.This PR tightens the writing-integration-tests skill in three places:
-m integrationrecommendation)Motivated by review feedback on a Humanitix integration PR (Autohive-AI/autohive-integrations#306) where the marker was applied correctly but the PR description still recommended the bare
-m integrationinvocation.