fix(review): suppress misleading 'key absent' log on unseal failure + optional-chain ctx.browser()

getSavedCookies was logging both the real unseal error AND a spurious
"'cookies' key is absent" message because the existsSync branch fired
regardless of whether the null came from a vault error or a missing key.
Added an unsealFailed flag to skip the second diagnostic when the catch
path already explained the failure.

login-runner.js / manual-login-runner.js: ctx.browser().close()
→ ctx.browser()?.close() so a null browser() return degrades gracefully
instead of throwing a TypeError swallowed by .catch().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: A.R.

packages/mcp-server/src/config.ts

@@ -406,18 +406,22 @@ export async function getSavedCookies(): Promise<PlaywrightCookie[]> {
   // so the extension output channel shows why — otherwise the user sees
   // "run Login first" for a profile they already logged into.
   const profile = activeName();
+  let unsealFailed = false;
   const raw = await _vault.get(profile, "cookies").catch((err: unknown) => {
+    unsealFailed = true;
     const msg = err instanceof Error ? err.message : String(err);
     console.error(`[vault] getSavedCookies failed for profile '${profile}': ${msg}`);
     return null;
   });
   if (!raw) {
-    // Distinguish "no vault.enc" from "vault exists but has no cookies key"
-    const paths = getProfilePaths(profile);
-    if (!existsSync(paths.vault)) {
-      console.error(`[vault] getSavedCookies: no vault.enc for profile '${profile}' — run login first`);
-    } else {
-      console.error(`[vault] getSavedCookies: vault.enc exists for profile '${profile}' but 'cookies' key is absent`);
+    if (!unsealFailed) {
+      // Distinguish "no vault.enc" from "vault exists but has no cookies key"
+      const paths = getProfilePaths(profile);
+      if (!existsSync(paths.vault)) {
+        console.error(`[vault] getSavedCookies: no vault.enc for profile '${profile}' — run login first`);
+      } else {
+        console.error(`[vault] getSavedCookies: vault.enc exists for profile '${profile}' but 'cookies' key is absent`);
+      }
     }
     return [];
   }

packages/mcp-server/src/login-runner.js

@@ -89,7 +89,7 @@ async function main() {
   const ready = await waitForLoginReady(page);
   if (!ready) {
     const title = await page.title().catch(() => "");
-    await ctx.browser().close().catch(() => {});
+    await ctx.browser()?.close().catch(() => {});
     emit({ ok: false, reason: /just a moment/i.test(title) ? "cf_blocked" : "auto_unsupported" });
     process.exit(/just a moment/i.test(title) ? 3 : 2);
   }
@@ -102,19 +102,19 @@ async function main() {
   if (!localOrigin) await minimizePageWindow(page);
 
   if (authFlow.kind === "sso_required") {
-    await ctx.browser().close().catch(() => {});
+    await ctx.browser()?.close().catch(() => {});
     emit({ ok: false, reason: "sso_required" });
     process.exit(2);
   }
 
   if (authFlow.kind === "unsupported") {
-    await ctx.browser().close().catch(() => {});
+    await ctx.browser()?.close().catch(() => {});
     emit({ ok: false, reason: "auto_unsupported", detail: authFlow.detail });
     process.exit(2);
   }
 
   if (authFlow.kind === "email_rejected") {
-    await ctx.browser().close().catch(() => {});
+    await ctx.browser()?.close().catch(() => {});
     emit({ ok: false, reason: "email_rejected", detail: authFlow.detail });
     process.exit(2);
   }
@@ -125,7 +125,7 @@ async function main() {
     try {
       otp = await awaitOtp();
     } catch {
-      await ctx.browser().close().catch(() => {});
+      await ctx.browser()?.close().catch(() => {});
       emit({ ok: false, reason: "otp_timeout" });
       process.exit(2);
     }
@@ -148,7 +148,7 @@ async function main() {
       recordLoginSuccess(PROFILE, { tier: metadata.tier, loginMode: "auto", lastLogin: new Date().toISOString() });
       writeFileSync(paths.reinit, String(Date.now()));
 
-      await ctx.browser().close().catch(() => {});
+      await ctx.browser()?.close().catch(() => {});
       emit({ ok: true, tier: metadata.tier, modelCount: Object.keys(metadata.models?.models ?? {}).length });
       process.exit(0);
     }
@@ -159,7 +159,7 @@ async function main() {
     }
 
     if (attempt === MAX_RETRIES) {
-      await ctx.browser().close().catch(() => {});
+      await ctx.browser()?.close().catch(() => {});
       emit({ ok: false, reason: "otp_rejected" });
       process.exit(2);
     }

packages/mcp-server/src/manual-login-runner.js

@@ -74,7 +74,7 @@ async function main() {
   if (Date.now() - cfStart >= CF_TIMEOUT_MS) {
     const title = await page.title().catch(() => "");
     if (/just a moment/i.test(title)) {
-      await ctx.browser().close().catch(() => {});
+      await ctx.browser()?.close().catch(() => {});
       emit({ ok: false, reason: "cf_blocked" });
       process.exit(3);
     }
@@ -94,7 +94,7 @@ async function main() {
 
   // Test hook: force a browser close to exercise the cancelled path.
   if (process.env.PERPLEXITY_TEST_BROWSER_CLOSE_AFTER_MS) {
-    setTimeout(() => ctx.browser().close().catch(() => {}), Number(process.env.PERPLEXITY_TEST_BROWSER_CLOSE_AFTER_MS));
+    setTimeout(() => ctx.browser()?.close().catch(() => {}), Number(process.env.PERPLEXITY_TEST_BROWSER_CLOSE_AFTER_MS));
   }
 
   const started = Date.now();
@@ -110,7 +110,7 @@ async function main() {
     if (sessionCookie) break;
   }
   if (!sessionCookie) {
-    await ctx.browser().close().catch(() => {});
+    await ctx.browser()?.close().catch(() => {});
     emit({ ok: false, reason: "timeout" });
     process.exit(2);
   }
@@ -130,7 +130,7 @@ async function main() {
 
   writeFileSync(paths.reinit, String(Date.now()));
 
-  await ctx.browser().close().catch(() => {});
+  await ctx.browser()?.close().catch(() => {});
   emit({ ok: true, tier: metadata.tier, modelCount: Object.keys(metadata.models?.models ?? {}).length });
   process.exit(0);
 }