Performance/LowExpiryCacheTime: improve the tests

* Add some more variations to the pre-existing tests:
    - Non-lowercase function call(s).
    - Fully qualified function calls.
    - Use PHP 7.3+ trailing comma's in a few function calls.
* Add tests for some edge-cases (empty text string, parse error).
* Add tests with a few additional PHP syntaxes to document these are handled correctly.

Author: jrfnl

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.1.inc

@@ -10,12 +10,12 @@ wp_cache_set( $testing, $data, 'test_group', 5*MINUTE_IN_SECONDS );
 wp_cache_set( 123, $data, 'test_group',  5 * MINUTE_IN_SECONDS );
 wp_cache_set( 1234, $data, '', 425 );
 wp_cache_set( $testing, $data, null, 350 );
-wp_cache_set( $testing, $data );
+\wp_cache_set( $testing, $data );
 wp_cache_set( 'test', $data, $group );
 
 wp_cache_add( 'test', $data, $group, 300 );
 wp_cache_add( $testing, $data, 'test_group', 6*MINUTE_IN_SECONDS );
-wp_cache_add( 1234, $data, '', 425 );
+WP_CACHE_ADD( 1234, $data, '', 425 );
 wp_cache_add( $testing, $data, null, 350 );
 
 wp_cache_replace( 'test', $data, $group, 300 );
@@ -30,13 +30,13 @@ wp_cache_set( 123, $data, null, 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 wp_cache_set( $testing, $data, '', 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 
 wp_cache_add( 'test', $data, $group, 100 ); // Lower than 300.
-wp_cache_add( 'test', $data, $group,  2*MINUTE_IN_SECONDS  ); // Lower than 300.
+\wp_cache_add( 'test', $data, $group,  2*MINUTE_IN_SECONDS  ); // Lower than 300.
 wp_cache_add( 123, $data, null, 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 wp_cache_add( $testing, $data, '', 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 
 wp_cache_replace( 'test', $data, $group, 100 ); // Lower than 300.
 wp_cache_replace( 'test', $data, $group,  2*MINUTE_IN_SECONDS  ); // Lower than 300.
-wp_cache_replace( 123, $data, null, 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
+WP_CACHE_REPLACE( 123, $data, null, 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 wp_cache_replace( $testing, $data, '', 1.5 * MINUTE_IN_SECONDS ); // Lower than 300.
 
 // Test error being reported on the line containing the parameter.
@@ -49,7 +49,7 @@ wp_cache_replace(
 
 // Test calculations with floats.
 wp_cache_replace( $testing, $data, '', 7.5 * MINUTE_IN_SECONDS ); // OK.
-wp_cache_replace( $testing, $data, '', 500 * 0.1 ); // Bad.
+wp_cache_replace( $testing, $data, '', 500 * 0.1, ); // Bad.
 
 // Test comment handling.
 wp_cache_add( 'test', $data, $group, /* Deliberately left empty */ ); // OK.
@@ -71,11 +71,11 @@ wp_cache_add(
 ); // OK.
 
 // Test variable/constant with or without calculation being passed.
-wp_cache_set( $key, $data, '', $time ); // Manual inspection warning.
+WP_Cache_Set( $key, $data, '', $time ); // Manual inspection warning.
 wp_cache_set( $key, $data, '', PREFIX_FIVE_MINUTES ); // Manual inspection warning.
 wp_cache_set( $key, $data, '', 20 * $time ); // Manual inspection warning.
-wp_cache_set( $key, $data, '', $base + $extra ); // Manual inspection warning.
-wp_cache_set( $key, $data, '', 300 + $extra ); // Manual inspection warning.
+wp_cache_set( $key, $data, '', $base + $extra, ); // Manual inspection warning.
+\wp_cache_set( $key, $data, '', 300 + $extra ); // Manual inspection warning.
 wp_cache_set( $key, $data, '', PREFIX_CUSTOM_TIME * 5); // Manual inspection warning.
 
 // Test calculations with additional aritmetic operators.
@@ -84,7 +84,7 @@ wp_cache_add( 'test', $data, $group, WEEK_IN_SECONDS / 3 + HOUR_IN_SECONDS  ); /
 
 // Test calculations grouped with parentheses.
 wp_cache_set( $key, $data, '', (24 * 60 * 60) ); // OK.
-wp_cache_set( $key, $data, '', (-(2 * 60) + 600) ); // OK.
+wp_cache_set( $key, $data, '', (-(2 * 60) + 600), ); // OK.
 wp_cache_set( $key, $data, '', (2 * 60) ); // Bad.
 
 
@@ -113,11 +113,27 @@ wp_cache_set( 'test', $data, $group, month_in_seconds ); // Bad - constants are
 wp_cache_set( 'test', $data, $group, HOUR_IN_SECONDS::methodName() ); // Bad - not a constant.
 wp_cache_set( 'test', $data, $group, $obj->MONTH_IN_SECONDS ); // Bad - not a constant.
 wp_cache_set( 'test', $data, $group, $obj::MONTH_IN_SECONDS ); // Bad - not the WP constant.
-wp_cache_set( 'test', $data, $group, PluginNamespace\SubLevel\DAY_IN_SECONDS ); // Bad - not the WP constant.
+WP_Cache_Set( 'test', $data, $group, PluginNamespace\SubLevel\DAY_IN_SECONDS, ); // Bad - not the WP constant.
 
 // Test passing negative number as cache time.
 wp_cache_set( 'test', $data, $group, -300 ); // Bad.
 wp_cache_add( $testing, $data, 'test_group', -6 * MINUTE_IN_SECONDS ); // Bad.
 
 // Test more complex logic in the parameter.
 wp_cache_add( $key, $data, '', ($toggle ? 200 : 400) ); // Manual inspection warning.
+
+// Test handling of non-numeric data in text string.
+wp_cache_set( 'test', $data, $group, '' ); // Manual inspection warning.
+wp_cache_set( 'test', $data, $group, '300 Mulberry Street' ); // Manual inspection warning.
+
+// Test handling of edge case/parse error.
+wp_cache_set( 'test', $data, $group,\); // OK, ignore.
+
+// Test handling of some modern PHP syntaxes.
+wp_cache_add('test', $data, $group, ...$params); // PHP 5.6 argument unpacking. Manual inspection warning.
+wp_cache_add( $key, $data, '', $toggle ?? 400) ); // PHP 7.0 null coalesce. Manual inspection warning.
+add_action('my_action', wp_cache_set(...)); // PHP 8.1 first class callable. OK, ignore.
+
+// Looks like a function call, but is a PHP 8.0+ class instantiation via an attribute.
+#[WP_Cache_Replace('text', 'data', 'group', 50)]
+function foo() {}

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.php

@@ -70,6 +70,10 @@ public function getWarningList( $testFile = '' ) {
 					119 => 1,
 					120 => 1,
 					123 => 1,
+					126 => 1,
+					127 => 1,
+					133 => 1,
+					134 => 1,
 				];
 
 			default: