Performance/LowExpiryCacheTime: add support for PHP 7.4+ numeric literals and 8.1+ octal literals

While PHPCS fully supports these syntaxes at the tokenizer level, this sniff includes the contents of the found token in a string which will be run through `eval()`, which means that if the number was originally provided in a PHP 7.4+ syntax and the sniffs are run on PHP 7.2, the `eval` will result in a fatal error, breaking the sniff (and possibly the PHPCS run).

By using the PHPCSUtils `Numbers` class, we can bypass this and retrieve the decimal value of a integer/float, no matter in what syntax the number is provided. If we then use the decimal value in the string which will be run through `eval()`, the potential fatal error is avoided.

Includes tests.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/LowExpiryCacheTimeSniff.php

@@ -10,6 +10,7 @@
 namespace WordPressVIPMinimum\Sniffs\Performance;
 
 use PHP_CodeSniffer\Util\Tokens;
+use PHPCSUtils\Utils\Numbers;
 use PHPCSUtils\Utils\TextStrings;
 use WordPressCS\WordPress\AbstractFunctionParameterSniff;
 
@@ -104,8 +105,10 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 			if ( $this->tokens[ $i ]['code'] === T_LNUMBER
 				|| $this->tokens[ $i ]['code'] === T_DNUMBER
 			) {
-				// Integer or float.
-				$tokensAsString .= $this->tokens[ $i ]['content'];
+				// Make sure that PHP 7.4 numeric literals and PHP 8.1 explicit octals don't cause problems.
+				$number_info     = Numbers::getCompleteNumber( $this->phpcsFile, $i );
+				$tokensAsString .= $number_info['decimal'];
+				$i               = $number_info['last_token'];
 				continue;
 			}
 

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.1.inc

@@ -137,3 +137,16 @@ add_action('my_action', wp_cache_set(...)); // PHP 8.1 first class callable. OK,
 // Looks like a function call, but is a PHP 8.0+ class instantiation via an attribute.
 #[WP_Cache_Replace('text', 'data', 'group', 50)]
 function foo() {}
+
+// Alternative numeric base.
+wp_cache_set( $key, $data, '', 0620 ); // Octal number. OK (=400).
+wp_cache_set( $key, $data, '', 0x190 ); // Hexidecimal number. OK (=400).
+wp_cache_set( $key, $data, '', 0b110010000 ); // PHP 5.4 binary number. OK (=400).
+wp_cache_set( $key, $data, '', 1_000 ); // PHP 7.4 numeric literal with underscore. OK.
+wp_cache_set( $key, $data, '', 0o620 ); // PHP 8.1 octal literal. OK (=400).
+
+wp_cache_set( $key, $data, '', 0226 ); // Octal number. Bad (=150).
+wp_cache_set( $key, $data, '', 0x96 ); // Hexidecimal number. Bad (=150).
+wp_cache_set( $key, $data, '', 0b10010110 ); // PHP 5.4 binary number. Bad (=150).
+wp_cache_set( $key, $data, '', 1_50 ); // PHP 7.4 numeric literal with underscore. Bad.
+wp_cache_set( $key, $data, '', 0o226 ); // PHP 8.1 octal literal. Bad (=150).

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.php

@@ -74,6 +74,11 @@ public function getWarningList( $testFile = '' ) {
 					127 => 1,
 					133 => 1,
 					134 => 1,
+					148 => 1,
+					149 => 1,
+					150 => 1,
+					151 => 1,
+					152 => 1,
 				];
 
 			default: