Performance/FetchingRemoteData: bug fix - examine all text string tokens in the parameter

As things were, only the first text string token in the parameter was being examined, while lead to false negatives.

Includes test.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php

@@ -67,9 +67,16 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 			$this->add_contents_unknown_warning( $stackPtr, $data );
 		}
 
-		$fileName = $this->tokens[ $has_text_string ]['content'];
+		$isRemoteFile = false;
+		while ( $has_text_string !== false ) {
+			if ( strpos( $this->tokens[ $has_text_string ]['content'], '://' ) !== false ) {
+				$isRemoteFile = true;
+				break;
+			}
+
+			$has_text_string = $this->phpcsFile->findNext( Tokens::$stringTokens, ( $has_text_string + 1 ), $search_end );
+		}
 
-		$isRemoteFile = ( strpos( $fileName, '://' ) !== false );
 		if ( $isRemoteFile === true ) {
 			$message = '`%s()` is highly discouraged for remote requests, please use `wpcom_vip_file_get_contents()` or `vip_safe_wp_remote_get()` instead.';
 			$this->phpcsFile->addWarning( $message, $stackPtr, 'FileGetContentsRemoteFile', $data );

WordPressVIPMinimum/Tests/Performance/FetchingRemoteDataUnitTest.inc

@@ -80,3 +80,6 @@ array_walk($files, file_get_contents(...)); // PHP 8.1 first class callable. War
 
 // Bug: don't throw a warning when __DIR__ is used as this indicates use with a local file.
 \file_get_contents( __DIR__ . $filename ); // OK.
+
+// Bug: check all text string tokens in the parameter.
+$result = file_get_contents(( is_ssl() ? 'http' : 'https' ) . '://example.com'); // Warning FileGetContentsRemoteFile.

WordPressVIPMinimum/Tests/Performance/FetchingRemoteDataUnitTest.php

@@ -43,6 +43,7 @@ public function getWarningList() {
 			62 => 1,
 			70 => 1,
 			79 => 1,
+			85 => 1,
 		];
 	}
 }