Skip to content

Commit dbe0fc0

Browse files
committed
ci: bump minimum PHP version from 5.4 to 7.4
WPCS 3.3.0 and its develop branch now require PHP 7.2+, making the existing PHP 5.4–7.1 CI matrix entries unable to install dev dependencies. Since the VIP platform requires PHP 8.3 and consuming plugins typically require 7.4+, raising the minimum to 7.4 aligns VIPCS with its actual usage whilst keeping the dev dependency early warning system functional.
1 parent 853dd1a commit dbe0fc0

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

.github/workflows/quicktest.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ jobs:
2626
strategy:
2727
matrix:
2828
include:
29-
- php: '5.4'
29+
- php: '7.4'
3030
dependencies: 'stable'
31-
- php: '5.4'
31+
- php: '7.4'
3232
dependencies: 'lowest'
3333

3434
- php: 'latest'

.github/workflows/test.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828

2929
strategy:
3030
matrix:
31-
php: ['5.4', 'latest', '8.5']
31+
php: ['7.4', 'latest', '8.5']
3232

3333
name: "Lint: PHP ${{ matrix.php }}"
3434
continue-on-error: ${{ matrix.php == '8.5' }}
@@ -64,20 +64,13 @@ jobs:
6464
# - php: The PHP versions to test against.
6565
# - dependencies: The PHPCS dependencies versions to test against.
6666
# IMPORTANT: test runs shouldn't fail because of PHPCS being incompatible with a PHP version.
67-
# - PHPCS will run without errors on PHP 5.4 - 7.4 on any supported version.
68-
# - PHP 8.0 needs PHPCS 3.5.7+ to run without errors, and we require a higher minimum version.
69-
# - PHP 8.1 needs PHPCS 3.6.1+ to run without errors, but works best with 3.7.1+, and we require at least this minimum version.
7067
# - PHP 8.2, 8.3 and 8.4 need PHPCS 3.8.0+ to run without errors (though the errors don't affect the tests).
7168
matrix:
72-
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
69+
php: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
7370
dependencies: ['lowest', 'stable']
7471

7572
include:
7673
# Test against dev versions of all dependencies with select PHP versions for early detection of issues.
77-
- php: '5.4'
78-
dependencies: 'dev'
79-
- php: '7.0'
80-
dependencies: 'dev'
8174
- php: '7.4'
8275
dependencies: 'dev'
8376
- php: '8.4'

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
}
1717
],
1818
"require": {
19-
"php": ">=5.4",
19+
"php": ">=7.4",
2020
"phpcsstandards/phpcsextra": "^1.4.0",
2121
"phpcsstandards/phpcsutils": "^1.1.0",
2222
"sirbrillig/phpcs-variable-analysis": "^2.12.0",
@@ -28,7 +28,7 @@
2828
"php-parallel-lint/php-console-highlighter": "^1.0.0",
2929
"phpcompatibility/php-compatibility": "^9",
3030
"phpcsstandards/phpcsdevtools": "^1.2.3",
31-
"phpunit/phpunit": "^4 || ^5 || ^6 || ^7 || ^8 || ^9"
31+
"phpunit/phpunit": "^8 || ^9"
3232
},
3333
"config": {
3434
"allow-plugins": {

0 commit comments

Comments
 (0)