Performance/LowExpiryCacheTime: add support for handling PHP 8.0+ function calls using named parameters

Includes tests.

Author: jrfnl

WordPressVIPMinimum/Sniffs/Performance/LowExpiryCacheTimeSniff.php

@@ -10,6 +10,7 @@
 namespace WordPressVIPMinimum\Sniffs\Performance;
 
 use PHP_CodeSniffer\Util\Tokens;
+use PHPCSUtils\Utils\PassedParameters;
 use PHPCSUtils\Utils\TextStrings;
 use WordPressCS\WordPress\AbstractFunctionParameterSniff;
 
@@ -67,21 +68,21 @@ class LowExpiryCacheTimeSniff extends AbstractFunctionParameterSniff {
 	 *                  normal file processing.
 	 */
 	public function process_parameters( $stackPtr, $group_name, $matched_content, $parameters ) {
-		if ( isset( $parameters[4] ) === false ) {
+		$expire_param = PassedParameters::getParameterFromStack( $parameters, 4, 'expire' );
+		if ( $expire_param === false ) {
 			// If no cache expiry time, bail (i.e. we don't want to flag for something like feeds where it is cached indefinitely until a hook runs).
 			return;
 		}
 
-		$param          = $parameters[4];
 		$tokensAsString = '';
 		$reportPtr      = null;
 		$openParens     = 0;
 
 		$message    = 'Cache expiry time could not be determined. Please inspect that the fourth parameter passed to %s() evaluates to 300 seconds or more. Found: "%s"';
 		$error_code = 'CacheTimeUndetermined';
-		$data       = [ $matched_content, $parameters[4]['clean'] ];
+		$data       = [ $matched_content, $expire_param['clean'] ];
 
-		for ( $i = $param['start']; $i <= $param['end']; $i++ ) {
+		for ( $i = $expire_param['start']; $i <= $expire_param['end']; $i++ ) {
 			if ( isset( Tokens::$emptyTokens[ $this->tokens[ $i ]['code'] ] ) === true ) {
 				$tokensAsString .= ' ';
 				continue;

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.1.inc

@@ -150,3 +150,12 @@ wp_cache_set( $key, $data, '', 0x96 ); // Hexidecimal number. Bad (=150).
 wp_cache_set( $key, $data, '', 0b10010110 ); // PHP 5.4 binary number. Bad (=150).
 wp_cache_set( $key, $data, '', 1_50 ); // PHP 7.4 numeric literal with underscore. Bad.
 wp_cache_set( $key, $data, '', 0o226 ); // PHP 8.1 octal literal. Bad (=150).
+
+// Safeguard handling of function calls using PHP 8.0+ named parameters.
+wp_cache_add(data: $data, group: $group); // OK, well, not really, missing required $key param, but that's not the concern of this sniff.
+wp_cache_replace(data: $data, expire: 400, group: $group); // OK.
+wp_cache_add($key, group: $group, data: $data, expires: 100,); // OK, well, not really, typo in param name, but that's not the concern of the sniff.
+wp_cache_replace($key, expire: 400, group: $group, data: 100,); // OK.
+
+wp_cache_replace($key, $data, expire: 100 ); // Bad.
+wp_cache_replace(expire: 100, data: $data, key: $group); // Bad.

WordPressVIPMinimum/Tests/Performance/LowExpiryCacheTimeUnitTest.php

@@ -79,6 +79,8 @@ public function getWarningList( $testFile = '' ) {
 					150 => 1,
 					151 => 1,
 					152 => 1,
+					160 => 1,
+					161 => 1,
 				];
 
 			default: