Hard-deprecate all JS specific sniffs#839
Merged
Merged
Conversation
Removing these sniffs needs to wait for a new major, as it would be a breaking change, however, in the mean time, we can: * Exclude the sniffs from both rulesets. This will prevent PHP_CodeSniffer from throwing deprecation notices about these sniffs. * Deprecate the sniffs themselves, in case users of the VIP-Coding-Standards would be explicitly including any of these sniff from within their own ruleset. Fixes 836 Related to 442 Related to 552 Issue 442 should be kept as a reminder to remove these sniffs in VIPCS 4.0. Issues 267, 376, 393, 411, 524, 525, 526, 527, 528, 650, 686, which are all related to these sniffs, should probably be closed as superseded by the deprecation and the sniffs no longer being used by the VIPCS native rulesets.
GaryJones
approved these changes
Jul 14, 2025
Collaborator
Author
|
@GaryJones Do you agree that the issues I've listed above should be closed ? If so, I'll go and do that ;-) |
Contributor
|
I've just done them all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing these sniffs needs to wait for a new major, as it would be a breaking change, however, in the mean time, we can:
Fixes #836
Related to #442
Related to #552
Issue #442 should be kept open as a reminder to remove these sniffs in VIPCS 4.0.
Issues #267, #376, #393, #411, #524, #525, #526, #527, #528, #650, #686, which are all related to these sniffs, should probably be closed as superseded by the deprecation and the sniffs no longer being used by the VIPCS native rulesets.