Security/Twig: sniff improvements#841
Merged
Merged
Conversation
As things were, double quoted strings with interpolation and PHP 5.3+ nowdocs were not examined. Includes ensuring that all tokens which should be examined have tests associated with them.
…essions Double quoted strings and heredocs may contain interpolated expressions, which could lead to false positives. Fixed now. Includes unit tests proving the bug.
GaryJones
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security/Twig: sniff for all text string tokens
As things were, double quoted strings with interpolation and PHP 5.3+ nowdocs were not examined.
Includes ensuring that all tokens which should be examined have tests associated with them.
Security/Twig: bug fix - prevent false positives on interpolated expressions
Double quoted strings and heredocs may contain interpolated expressions, which could lead to false positives.
Fixed now.
Includes unit tests proving the bug.
Closes #545