Merged
Conversation
GaryJones
force-pushed
the
GaryJones/fix-ci-879
branch
from
1770b8e to
1d3ca7f
Compare
GaryJones
force-pushed
the
GaryJones/fix-ci-879
branch
from
3e60b44 to
80aed0a
Compare
GaryJones
changed the title
The PHPCS repository moved from squizlabs to phpcsstandards and no longer has a master branch. The dev CI jobs need to track the 3.x branch until WPCS (and by extension VIPCS) is compatible with PHPCS 4.x.
WPCS 3.3.0 and its develop branch now require PHP 7.2+, making the existing PHP 5.4–7.1 CI matrix entries unable to install dev dependencies. Since the VIP platform requires PHP 8.3 and consuming plugins typically require 7.4+, raising the minimum to 7.4 aligns VIPCS with its actual usage whilst keeping the dev dependency early warning system functional.
With PHP 7.4 as the minimum, PHPUnit 9 (which requires PHP 7.3+) covers the entire supported range. This removes the PHPUnit 8 schema validation step and tightens the Composer constraint accordingly.
GaryJones
force-pushed
the
GaryJones/fix-ci-879
branch
from
80aed0a to
fdd5a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI workflows testing against development versions of PHPCS dependencies have been failing because they referenced
dev-masterforsquizlabs/php_codesniffer, but that branch no longer exists — the repository moved tophpcsstandards/php_codesnifferand the development branch is now3.x. The correct Composer constraint for a version-like branch is3.x-dev(suffix form), notdev-3.x.Fixing the PHPCS branch reference then exposed a second issue: WPCS
developnow requires PHP 7.2+, causing the PHP 5.4 and 7.0 "dev" matrix entries to fail on dependency resolution. Rather than simply adjusting the dev matrix, this raises the minimum PHP version to 7.4. The VIP platform requires PHP 8.3, and consuming plugins typically require 7.4+, so PHP 5.4 support was purely theoretical at this point.With PHP 7.4 as the floor, PHPUnit 8 (which supports PHP 7.2+) is no longer needed — PHPUnit 9 (PHP 7.3+) covers the entire supported range. This removes PHPUnit 8 from the Composer constraint and drops the PHPUnit 8 schema validation step from the BasicQA workflow.
Changes
dev-master→3.x-devinbasics.ymlandtest.ymlcomposer.json, lint matrix, test matrix, quicktest matrix^4 || ^5 || ^6 || ^7 || ^8 || ^9→^9; removed PHPUnit 8 schema validation stepTest plan