From cdbf5dd5c6cb650e73a439362e0a4a34135aabd9 Mon Sep 17 00:00:00 2001 From: Chris Huber Date: Thu, 2 Jul 2026 23:09:39 -0400 Subject: [PATCH 1/8] Fix SSI coffee transformer validity --- php-transformer/composer.json | 1 + .../src/ArtifactCompiler/ArtifactCompiler.php | 3 + .../Contract/ConversionReportProjection.php | 3 + .../src/CorpusDiagnostics/CorpusDetectors.php | 34 ++++++++-- .../src/HtmlToBlocks/BlockFactory.php | 68 ++++++++++++++++++- .../Diagnostics/DiagnosticsCollector.php | 3 + .../Diagnostics/FallbackEmitter.php | 3 + .../src/HtmlToBlocks/FallbackDiagnostic.php | 3 + .../src/HtmlToBlocks/HtmlTransformer.php | 67 +++++++++++++++++- .../Patterns/NavigationPattern.php | 48 +++++++++++-- .../Style/StyleAttributeMapper.php | 65 ++++++++++++++++-- .../Style/StyleResolutionTrait.php | 45 ++++++++++-- .../HtmlToBlocks/TypographyParityAnalyzer.php | 3 +- .../FontMaterializationPlanBuilder.php | 2 +- php-transformer/tests/contract/run.php | 66 +++++++++++++++++- ...nked-css-layout-wrapper-style-signals.json | 3 +- .../parity/html-anchor-inline-patterns.json | 2 +- .../parity/html-class-grid-card-layout.json | 2 +- ...explicit-grid-class-non-card-children.json | 1 + ...ml-group-wrapper-canonical-save-shape.json | 2 +- .../html-logo-nav-button-classification.json | 2 +- .../html-single-child-flex-svg-address.json | 2 +- .../parity/html-single-child-flex-svg.json | 2 +- ...ml-vertical-flex-column-becomes-group.json | 1 + .../unit/block-style-support-conversion.php | 62 +++++++++++++++++ .../tests/unit/css-value-splitter.php | 20 ++++++ 26 files changed, 477 insertions(+), 36 deletions(-) create mode 100644 php-transformer/tests/unit/block-style-support-conversion.php diff --git a/php-transformer/composer.json b/php-transformer/composer.json index 80ecd4b7..c07d18df 100644 --- a/php-transformer/composer.json +++ b/php-transformer/composer.json @@ -57,6 +57,7 @@ "php tests/unit/subtree-classifier.php", "php tests/unit/custom-block-generator.php", "php tests/unit/css-value-splitter.php", + "php tests/unit/block-style-support-conversion.php", "php tests/unit/content-round-trip-reporter.php", "php tests/unit/content-round-trip-form-echo.php", "php tests/unit/corpus-detectors.php", diff --git a/php-transformer/src/ArtifactCompiler/ArtifactCompiler.php b/php-transformer/src/ArtifactCompiler/ArtifactCompiler.php index 212babeb..50fe9afc 100644 --- a/php-transformer/src/ArtifactCompiler/ArtifactCompiler.php +++ b/php-transformer/src/ArtifactCompiler/ArtifactCompiler.php @@ -286,6 +286,9 @@ private function runtimeIslandsWithMaterializedInlineScripts(array $runtimeIslan 'diagnostic_code' => 'preserved_runtime_island', 'preservation_reason' => 'script_requires_runtime', 'runtime_requirement' => 'client_script_execution', + 'disposition' => 'preserve', + 'preservation_status' => 'accepted_runtime_preservation', + 'js_handling' => 'preserve_verbatim', 'source_snippet' => '', 'source_bytes' => strlen($content), 'source_truncated' => false, diff --git a/php-transformer/src/Contract/ConversionReportProjection.php b/php-transformer/src/Contract/ConversionReportProjection.php index 91fa0e07..24c46729 100644 --- a/php-transformer/src/Contract/ConversionReportProjection.php +++ b/php-transformer/src/Contract/ConversionReportProjection.php @@ -368,6 +368,9 @@ private static function runtimeIslandSummaryEntries(array $sourceReports): array 'tag' => $island['tag'] ?? '', 'conversion_classification' => 'runtime_island_preserved', 'preservation_strategy' => $island['preservation_strategy'] ?? 'scoped_runtime_metadata', + 'disposition' => $island['disposition'] ?? '', + 'preservation_status' => $island['preservation_status'] ?? '', + 'js_handling' => $island['js_handling'] ?? '', ), static fn (mixed $value): bool => '' !== $value ); diff --git a/php-transformer/src/CorpusDiagnostics/CorpusDetectors.php b/php-transformer/src/CorpusDiagnostics/CorpusDetectors.php index 6b7885b8..4ea9dbce 100644 --- a/php-transformer/src/CorpusDiagnostics/CorpusDetectors.php +++ b/php-transformer/src/CorpusDiagnostics/CorpusDetectors.php @@ -269,13 +269,14 @@ public static function varDependentStyling(array $flat): array foreach ( $flat as $block ) { $haystack = self::blockMarkup($block); - if ( '' === $haystack ) { - continue; - } - if ( ! preg_match_all('/var\(\s*(--[A-Za-z0-9_-]+)/', $haystack, $matches) ) { - continue; + if ( '' !== $haystack && preg_match_all('/var\(\s*(--[A-Za-z0-9_-]+)/', $haystack, $matches) ) { + foreach ( $matches[1] as $name ) { + ++$total; + $occurrences[$name] = ($occurrences[$name] ?? 0) + 1; + } } - foreach ( $matches[1] as $name ) { + + foreach ( self::presetVarNamesFromAttrs($block) as $name ) { ++$total; $occurrences[$name] = ($occurrences[$name] ?? 0) + 1; } @@ -729,6 +730,27 @@ private static function blockMarkup(array $block): string return is_string($block['innerHTML'] ?? null) ? $block['innerHTML'] : ''; } + /** + * Native preset color attrs are the valid form of CSS preset vars, so they no + * longer appear in innerHTML. Keep them in var_names for corpus visibility. + * + * @param array $block + * @return array + */ + private static function presetVarNamesFromAttrs(array $block): array + { + $attrs = is_array($block['attrs'] ?? null) ? $block['attrs'] : array(); + $names = array(); + foreach ( array( 'textColor', 'backgroundColor' ) as $attrName ) { + $slug = is_string($attrs[ $attrName ] ?? null) ? strtolower(trim($attrs[ $attrName ])) : ''; + if ( '' !== $slug && preg_match('/^[a-z0-9_-]+$/', $slug) ) { + $names[] = '--wp--preset--color--' . $slug; + } + } + + return $names; + } + /** * RichText content for a paragraph/heading/list-item block: the explicit * content attribute, falling back to saved innerHTML. diff --git a/php-transformer/src/HtmlToBlocks/BlockFactory.php b/php-transformer/src/HtmlToBlocks/BlockFactory.php index a4b07561..920de2b2 100644 --- a/php-transformer/src/HtmlToBlocks/BlockFactory.php +++ b/php-transformer/src/HtmlToBlocks/BlockFactory.php @@ -33,6 +33,7 @@ private function styleMapper(): StyleAttributeMapper */ public function create(string $name, array $attrs = array(), array $innerBlocks = array()): array { + $attrs = $this->normalizeAttrsForBlock($name, $attrs); $innerHtml = $this->blockHtml($name, $attrs, $innerBlocks); if ( is_array($innerHtml) ) { $innerContent = array( $innerHtml['opening'] ); @@ -54,6 +55,25 @@ public function create(string $name, array $attrs = array(), array $innerBlocks ); } + /** + * @param array $attrs + * @return array + */ + private function normalizeAttrsForBlock(string $name, array $attrs): array + { + if ( in_array($name, array( 'core/column', 'core/group', 'core/heading', 'core/list-item', 'core/paragraph' ), true) ) { + unset($attrs['style']['spacing']['blockGap']); + if ( empty($attrs['style']['spacing']) ) { + unset($attrs['style']['spacing']); + } + if ( empty($attrs['style']) ) { + unset($attrs['style']); + } + } + + return $attrs; + } + /** * @param array $attrs * @return array @@ -545,7 +565,9 @@ private function mergeClassNames(string ...$classNames): string private function blockSupportAttrs(array $attrs, string $baseClass = ''): string { $support = $this->styleSupport($attrs['style'] ?? null); - $classes = $this->mergeClassNames($baseClass, $support['classes'], (string) ($attrs['className'] ?? '')); + $presetClasses = $this->presetColorClasses($attrs); + $layoutClasses = $this->layoutClasses($attrs['layout'] ?? null, $baseClass); + $classes = $this->mergeClassNames($baseClass, $presetClasses, $support['classes'], $layoutClasses, (string) ($attrs['className'] ?? '')); return $this->htmlAttrs(array( 'id' => (string) ($attrs['anchor'] ?? ''), 'class' => $classes, @@ -573,6 +595,50 @@ private function styleSupport(mixed $style): array ); } + /** + * @param array $attrs + */ + private function presetColorClasses(array $attrs): string + { + $classes = array(); + $textColor = $this->safeSlug((string) ($attrs['textColor'] ?? '')); + if ( '' !== $textColor ) { + $classes[] = 'has-' . $textColor . '-color'; + $classes[] = 'has-text-color'; + } + + $backgroundColor = $this->safeSlug((string) ($attrs['backgroundColor'] ?? '')); + if ( '' !== $backgroundColor ) { + $classes[] = 'has-' . $backgroundColor . '-background-color'; + $classes[] = 'has-background'; + } + + return implode(' ', $classes); + } + + private function layoutClasses(mixed $layout, string $baseClass): string + { + if ( ! is_array($layout) ) { + return ''; + } + + $type = $this->safeSlug((string) ($layout['type'] ?? '')); + if ( ! in_array($type, array( 'constrained', 'flex', 'flow', 'grid' ), true) ) { + return ''; + } + + return $this->mergeClassNames( + 'is-layout-' . $type, + '' !== $baseClass ? $baseClass . '-is-layout-' . $type : '' + ); + } + + private function safeSlug(string $value): string + { + $value = strtolower(trim($value)); + return preg_match('/^[a-z0-9_-]+$/', $value) ? $value : ''; + } + /** * @param array $attrs * @param array $includeEmpty diff --git a/php-transformer/src/HtmlToBlocks/Diagnostics/DiagnosticsCollector.php b/php-transformer/src/HtmlToBlocks/Diagnostics/DiagnosticsCollector.php index 5d825d0d..6ca3870a 100644 --- a/php-transformer/src/HtmlToBlocks/Diagnostics/DiagnosticsCollector.php +++ b/php-transformer/src/HtmlToBlocks/Diagnostics/DiagnosticsCollector.php @@ -102,6 +102,9 @@ public function collect( 'diagnostic_class' => 'runtime_island_preserved', 'suggested_repair_class' => 'preserve_runtime_island', 'preservation_strategy' => $island['preservation_strategy'] ?? 'bounded_raw_html_runtime_island', + 'disposition' => $island['disposition'] ?? null, + 'preservation_status' => $island['preservation_status'] ?? null, + 'js_handling' => $island['js_handling'] ?? null, 'runtime_requirement' => $island['runtime_requirement'] ?? null, 'kind' => $island['kind'] ?? null, 'reason' => $island['preservation_reason'] ?? null, diff --git a/php-transformer/src/HtmlToBlocks/Diagnostics/FallbackEmitter.php b/php-transformer/src/HtmlToBlocks/Diagnostics/FallbackEmitter.php index 6aa70398..56f75995 100644 --- a/php-transformer/src/HtmlToBlocks/Diagnostics/FallbackEmitter.php +++ b/php-transformer/src/HtmlToBlocks/Diagnostics/FallbackEmitter.php @@ -506,6 +506,9 @@ public function recordRuntimeIsland(DOMElement $element, string $kind, string $r 'diagnostic_code' => 'preserved_runtime_island', 'preservation_reason' => $reason, 'runtime_requirement' => $runtimeRequirement, + 'disposition' => 'preserve', + 'preservation_status' => 'accepted_runtime_preservation', + 'js_handling' => 'client_script_execution' === $runtimeRequirement ? 'preserve_verbatim' : '', 'source_snippet' => $boundedHtml['html'], 'source_bytes' => $boundedHtml['bytes'], 'source_truncated' => $boundedHtml['truncated'], diff --git a/php-transformer/src/HtmlToBlocks/FallbackDiagnostic.php b/php-transformer/src/HtmlToBlocks/FallbackDiagnostic.php index 293190d0..1cf7b333 100644 --- a/php-transformer/src/HtmlToBlocks/FallbackDiagnostic.php +++ b/php-transformer/src/HtmlToBlocks/FallbackDiagnostic.php @@ -84,6 +84,9 @@ private static function defaults(array $fields): array 'conversion_classification' => 'runtime_island_preserved', 'loss_class' => 'runtime_island_preserved', 'diagnostic_class' => 'runtime_island_preserved', + 'disposition' => 'preserve', + 'preservation_status' => 'accepted_runtime_preservation', + 'js_handling' => 'preserve_verbatim', 'preservation_strategy' => 'scoped_runtime_metadata', 'runtime_requirement' => 'client_script_execution', 'recoverability' => 'recoverable_with_script_enqueue_or_component_runtime', diff --git a/php-transformer/src/HtmlToBlocks/HtmlTransformer.php b/php-transformer/src/HtmlToBlocks/HtmlTransformer.php index 51944e1d..689080e1 100644 --- a/php-transformer/src/HtmlToBlocks/HtmlTransformer.php +++ b/php-transformer/src/HtmlToBlocks/HtmlTransformer.php @@ -1099,6 +1099,9 @@ private function convertElement(DOMElement $element, array &$fallbacks, bool $ca if ( preg_match('/^h([1-6])$/', $tagName, $matches) ) { $content = $this->innerHtml($element); + if ( $this->richTextRequiresHtmlFallback($content) ) { + return $this->createBlock('core/html', array( 'content' => $this->restoreSvgCasing($this->outerHtml($element)) ), array(), $element); + } if ( '' === trim($this->runtime->stripAllTags($content)) ) { return null; } @@ -1111,6 +1114,9 @@ private function convertElement(DOMElement $element, array &$fallbacks, bool $ca if ( 'p' === $tagName ) { $content = $this->innerHtml($element); + if ( $this->richTextRequiresHtmlFallback($content) ) { + return $this->createBlock('core/html', array( 'content' => $this->restoreSvgCasing($this->outerHtml($element)) ), array(), $element); + } if ( '' === trim($this->runtime->stripAllTags($content)) ) { if ( $this->isRuntimeDomTarget($element) ) { return $this->createBlock('core/group', $this->presentationAttributes($element), array(), $element); @@ -1829,6 +1835,10 @@ private function createBlock(string $name, array $attrs = array(), array $innerB { $attrs = $this->hoistContentWrappingSpans($name, $attrs); + if ( $sourceElement instanceof DOMElement && in_array($name, array( 'core/paragraph', 'core/heading' ), true) && $this->richTextRequiresHtmlFallback((string) ($attrs['content'] ?? '')) ) { + return $this->blockFactory->create('core/html', array( 'content' => $this->restoreSvgCasing($this->outerHtml($sourceElement)) )); + } + if ( $sourceElement instanceof DOMElement ) { $provenanceId = $this->nextSourceProvenanceId++; $this->recordPresentationProvenance($name, $attrs, $sourceElement); @@ -1880,7 +1890,10 @@ private function createBlock(string $name, array $attrs = array(), array $innerB * - Remaining sibling/partial styling-hook spans are UNWRAPPED to their * inner content. Their per-span class styling cannot ride valid RichText * here, so this is best-effort; the emitted block is always valid. - * Genuine inline formats (strong/em/a/br/…) are never touched. + * Genuine inline formats (strong/em/a/br/…) are kept, but arbitrary + * class/style hooks on links are moved to the block wrapper when the link is + * the sole content wrapper, or dropped when they are partial-content hooks. + * RichText's link format round-trips href/target/rel, not source CSS hooks. * * A list item whose content carries block-level children (an image/heading/ * paragraph "card", e.g. a commerce product grid) is left untouched here: @@ -1897,7 +1910,7 @@ private function hoistContentWrappingSpans(string $name, array $attrs): array } $content = (string) ($attrs['content'] ?? ''); - if ( '' === $content || ! preg_match('/unwrapElement($wrapper); } + $soleAnchor = $this->soleRichTextAnchor($body); + if ( $soleAnchor instanceof DOMElement ) { + $hoistedClasses = trim($hoistedClasses . ' ' . $this->attr($soleAnchor, 'class')); + $anchorStyle = trim($this->attr($soleAnchor, 'style')); + if ( '' !== $anchorStyle ) { + $hoistedDeclarations = array_merge($hoistedDeclarations, $this->cssDeclarations($anchorStyle)); + } + } + + foreach ( $this->richTextAnchors($body) as $anchor ) { + $anchor->removeAttribute('class'); + $anchor->removeAttribute('style'); + } + // Unwrap any remaining styling-hook spans (sibling / partial content): // best-effort, the class styling is not representable as valid RichText. foreach ( $this->stylingHookSpans($body) as $span ) { @@ -1982,6 +2009,22 @@ private function soleStylingHookSpan(DOMElement $container): ?DOMElement return $only instanceof DOMElement && $this->isStylingHookSpan($only) ? $only : null; } + private function soleRichTextAnchor(DOMElement $container): ?DOMElement + { + $only = null; + foreach ( $container->childNodes as $child ) { + if ( XML_TEXT_NODE === $child->nodeType && '' === trim($child->textContent ?? '') ) { + continue; + } + if ( null !== $only ) { + return null; + } + $only = $child; + } + + return $only instanceof DOMElement && 'a' === strtolower($only->tagName) ? $only : null; + } + /** * A `` whose only attributes are class and/or style (at least one * non-empty). These are presentational styling hooks RichText cannot store, @@ -2022,6 +2065,26 @@ private function stylingHookSpans(DOMElement $container): array return $spans; } + /** + * @return array + */ + private function richTextAnchors(DOMElement $container): array + { + $anchors = array(); + foreach ( $container->getElementsByTagName('a') as $anchor ) { + if ( $anchor instanceof DOMElement && ( $anchor->hasAttribute('class') || $anchor->hasAttribute('style') ) ) { + $anchors[] = $anchor; + } + } + + return $anchors; + } + + private function richTextRequiresHtmlFallback(string $content): bool + { + return (bool) preg_match('/<(?:svg|canvas|img|picture|video|audio|iframe|object|embed|input|button|select|textarea|form)\b/i', $content); + } + /** * Replace an element with its children in place, dropping only the wrapper. */ diff --git a/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php b/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php index c7f60938..8eb1af74 100644 --- a/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php +++ b/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php @@ -39,7 +39,7 @@ public function match(DOMElement $element, PatternContext $context): ?array // `mobile` matches the core default: WP renders the responsive overlay // container and enqueues the `navigation/view` Interactivity module so the // hamburger menu functions on the rendered site (#native-interactivity). - return $createBlock('core/navigation', array_merge($presentationAttributes($element), array( + return $createBlock('core/navigation', array_merge($this->navigationContainerAttributes($element, $presentationAttributes), array( 'overlayMenu' => 'mobile', )), $links, $element); } @@ -251,9 +251,9 @@ private function navigationLabel(string $html): string */ private function navigationItemAttributes(DOMElement $item, DOMElement $anchor, ?DOMElement $submenuContainer, array $baseAttrs, callable $presentationAttributes): array { - $itemAttrs = $item->isSameNode($anchor) ? array() : $presentationAttributes($item); - $anchorAttrs = $presentationAttributes($anchor); - $submenuAttrs = $submenuContainer instanceof DOMElement ? $presentationAttributes($submenuContainer) : array(); + $itemAttrs = $item->isSameNode($anchor) ? array() : $this->withoutCoreNavigationClasses($presentationAttributes($item)); + $anchorAttrs = $this->withoutCoreNavigationClasses($presentationAttributes($anchor)); + $submenuAttrs = $submenuContainer instanceof DOMElement ? $this->withoutCoreNavigationClasses($presentationAttributes($submenuContainer)) : array(); if ( '' === (string) ($itemAttrs['className'] ?? '') && '' !== (string) ($anchorAttrs['className'] ?? '') ) { $itemAttrs['className'] = $anchorAttrs['className']; } @@ -267,6 +267,44 @@ private function navigationItemAttributes(DOMElement $item, DOMElement $anchor, )), static fn ($value): bool => '' !== $value); } + /** + * @return array + */ + private function navigationContainerAttributes(DOMElement $element, callable $presentationAttributes): array + { + return $this->withoutCoreNavigationClasses($presentationAttributes($element)); + } + + /** + * @param array $attrs + * @return array + */ + private function withoutCoreNavigationClasses(array $attrs): array + { + if ( empty($attrs['className']) || ! is_string($attrs['className']) ) { + return $attrs; + } + + $classNames = array_values(array_filter(preg_split('/\s+/', trim($attrs['className'])) ?: array(), static function (string $className): bool { + return ! in_array($className, array( + 'wp-block-navigation', + 'wp-block-navigation-item', + 'wp-block-navigation-link', + 'wp-block-navigation-submenu', + 'wp-block-navigation__container', + 'wp-block-navigation__submenu-container', + ), true); + })); + + if ( array() === $classNames ) { + unset($attrs['className']); + return $attrs; + } + + $attrs['className'] = implode(' ', $classNames); + return $attrs; + } + private function attr(DOMElement $element, string $name): string { return $element->hasAttribute($name) ? $element->getAttribute($name) : ''; @@ -310,7 +348,7 @@ private function submenuContainers(DOMElement $element, DOMElement $primaryAncho } $tagName = strtolower($child->tagName); - if ( in_array($tagName, array( 'ul', 'ol' ), true) || $this->hasSubmenuSignal($child) ) { + if ( in_array($tagName, array( 'nav', 'ul', 'ol' ), true) || $this->hasSubmenuSignal($child) ) { $containers[] = $child; } } diff --git a/php-transformer/src/HtmlToBlocks/Style/StyleAttributeMapper.php b/php-transformer/src/HtmlToBlocks/Style/StyleAttributeMapper.php index 1d0c56f7..7efaa4a2 100644 --- a/php-transformer/src/HtmlToBlocks/Style/StyleAttributeMapper.php +++ b/php-transformer/src/HtmlToBlocks/Style/StyleAttributeMapper.php @@ -53,7 +53,7 @@ final class StyleAttributeMapper * Map resolved CSS declarations to canonical block style attributes. * * @param array $declarations - * @return array{style: array, leftover: array} + * @return array{style: array, attrs: array, leftover: array} */ public function map(array $declarations): array { @@ -74,7 +74,8 @@ public function map(array $declarations): array $style['typography'] = $typography; } - $color = $this->color($normalized, $consumed); + $attrs = array(); + $color = $this->color($normalized, $consumed, $attrs); if ( array() !== $color ) { $style['color'] = $color; } @@ -92,6 +93,11 @@ public function map(array $declarations): array $style['spacing'] = $spacing; } + $blockGap = $this->blockGap($normalized, $consumed); + if ( '' !== $blockGap ) { + $style['spacing']['blockGap'] = $blockGap; + } + $border = $this->border($normalized, $consumed); if ( array() !== $border ) { $style['border'] = $border; @@ -107,6 +113,7 @@ public function map(array $declarations): array return array( 'style' => $style, + 'attrs' => $attrs, 'leftover' => $leftover, ); } @@ -167,6 +174,10 @@ public function serialize(array $style): array } } } + $blockGap = trim((string) ($spacing['blockGap'] ?? '')); + if ( '' !== $blockGap ) { + $declarations[] = 'gap:' . $blockGap; + } $typography = is_array($style['typography'] ?? null) ? $style['typography'] : array(); $typographyMap = array( @@ -225,7 +236,7 @@ private function typography(array $declarations, array &$consumed): array * @param array $consumed * @return array */ - private function color(array $declarations, array &$consumed): array + private function color(array $declarations, array &$consumed, array &$attrs): array { $color = array(); @@ -233,14 +244,24 @@ private function color(array $declarations, array &$consumed): array $consumed['color'] = true; $text = $this->cssColor($declarations['color']); if ( '' !== $text ) { - $color['text'] = $text; + $preset = $this->presetColorSlug($text); + if ( '' !== $preset ) { + $attrs['textColor'] = $preset; + } else { + $color['text'] = $text; + } } } $gradient = $this->gradient($declarations, $consumed); $background = $this->backgroundColor($declarations, $consumed); if ( '' !== $background ) { - $color['background'] = $background; + $preset = $this->presetColorSlug($background); + if ( '' !== $preset ) { + $attrs['backgroundColor'] = $preset; + } else { + $color['background'] = $background; + } } if ( '' !== $gradient ) { $color['gradient'] = $gradient; @@ -249,6 +270,40 @@ private function color(array $declarations, array &$consumed): array return $color; } + /** + * Gutenberg stores preset colors as top-level block attrs, not custom inline + * style values. Accept both serialized support syntax and CSS custom props. + */ + private function presetColorSlug(string $value): string + { + $value = trim($value); + if ( preg_match('/^var:preset\|color\|([a-z0-9_-]+)$/i', $value, $match) ) { + return strtolower($match[1]); + } + if ( preg_match('/^var\(\s*--wp--preset--color--([a-z0-9_-]+)\s*\)$/i', $value, $match) ) { + return strtolower($match[1]); + } + + return ''; + } + + /** + * @param array $declarations + * @param array $consumed + */ + private function blockGap(array $declarations, array &$consumed): string + { + foreach ( array( 'gap', 'row-gap', 'column-gap' ) as $name ) { + $value = trim((string) ($declarations[ $name ] ?? '')); + if ( '' !== $value ) { + $consumed[ $name ] = true; + return $value; + } + } + + return ''; + } + /** * @param array $declarations * @param array $consumed diff --git a/php-transformer/src/HtmlToBlocks/Style/StyleResolutionTrait.php b/php-transformer/src/HtmlToBlocks/Style/StyleResolutionTrait.php index 91fc0583..0bd446b3 100644 --- a/php-transformer/src/HtmlToBlocks/Style/StyleResolutionTrait.php +++ b/php-transformer/src/HtmlToBlocks/Style/StyleResolutionTrait.php @@ -48,12 +48,12 @@ private function presentationAttributes(DOMElement $element): array $declarations = $this->stripFrozenHiddenState($element, $this->cssDeclarations($style)); $mapped = $this->styleAttributeMapper()->map($declarations); - return array_filter(array( + return array_filter(array_merge($mapped['attrs'] ?? array(), array( 'anchor' => $this->safeAnchor($this->attr($element, 'id')), 'className' => $this->promotedClassName($this->attr($element, 'class')), 'style' => $mapped['style'], 'layout' => $this->layoutAttribute($element, $this->cssDeclarationString($declarations)), - ), static fn ($value): bool => is_array($value) ? array() !== $value : '' !== trim((string) $value)); + )), static fn ($value): bool => is_array($value) ? array() !== $value : '' !== trim((string) $value)); } /** @@ -420,20 +420,28 @@ private function layoutAttribute(DOMElement $element, string $mergedStyle = ''): } $inlineStyle = strtolower($this->attr($element, 'style')); + $mergedDeclarations = $this->cssDeclarations($mergedStyle); + $inlineDeclarations = $this->cssDeclarations($inlineStyle); if ( preg_match('/(?:^|;)\s*display\s*:\s*(inline-)?flex\b/', $inlineStyle) ) { + $layout = array( 'type' => 'flex' ); // flex-direction: column / column-reverse is a vertical main axis. A // core/group flex layout defaults to a horizontal Row, so the // orientation must be made explicit or the children render // side-by-side instead of stacked. Row / row-reverse / default flex // keeps the implicit horizontal orientation. if ( preg_match('/(?:^|;)\s*flex-direction\s*:\s*column(?:-reverse)?\b/', $inlineStyle) ) { - return array( - 'type' => 'flex', - 'orientation' => 'vertical', - ); + $layout['orientation'] = 'vertical'; + } + $justifyContent = $this->layoutJustifyContent((string) ($inlineDeclarations['justify-content'] ?? $mergedDeclarations['justify-content'] ?? '')); + if ( '' !== $justifyContent ) { + $layout['justifyContent'] = $justifyContent; + } + $flexWrap = $this->layoutFlexWrap((string) ($inlineDeclarations['flex-wrap'] ?? $mergedDeclarations['flex-wrap'] ?? '')); + if ( '' !== $flexWrap ) { + $layout['flexWrap'] = $flexWrap; } - return array( 'type' => 'flex' ); + return $layout; } $style = strtolower('' !== trim($mergedStyle) ? $mergedStyle : $this->attr($element, 'style')); if ( preg_match('/(?:^|;)\s*display\s*:\s*(inline-)?flex\b/', $style) @@ -470,6 +478,29 @@ private function layoutAttribute(DOMElement $element, string $mergedStyle = ''): return array(); } + private function layoutJustifyContent(string $value): string + { + $value = strtolower(trim($value)); + $map = array( + 'flex-start' => 'left', + 'start' => 'left', + 'left' => 'left', + 'center' => 'center', + 'flex-end' => 'right', + 'end' => 'right', + 'right' => 'right', + 'space-between' => 'space-between', + ); + + return $map[ $value ] ?? ''; + } + + private function layoutFlexWrap(string $value): string + { + $value = strtolower(trim($value)); + return in_array($value, array( 'wrap', 'nowrap' ), true) ? $value : ''; + } + /** * Unambiguous grid class tokens: a bare `grid`, a numbered `grid-N`, or any * `*-grid` / `*_grid` suffix (footer-grid, card-grid, mission-grid, …) plus diff --git a/php-transformer/src/HtmlToBlocks/TypographyParityAnalyzer.php b/php-transformer/src/HtmlToBlocks/TypographyParityAnalyzer.php index f9ce2f5d..c8e6d23c 100644 --- a/php-transformer/src/HtmlToBlocks/TypographyParityAnalyzer.php +++ b/php-transformer/src/HtmlToBlocks/TypographyParityAnalyzer.php @@ -63,8 +63,9 @@ public function findings(string $html, string $css, array $inlineHeadingDeclarat ); } + $typographyCss = $this->planBuilder->resolveCssVariables(trim($this->styleBlockCss($html) . "\n" . $css)); $headingDeclarations = array_merge( - $this->headingFamiliesFromCss($this->styleBlockCss($html)), + $this->headingFamiliesFromCss($typographyCss), $this->normalizeInlineHeadingDeclarations($inlineHeadingDeclarations) ); diff --git a/php-transformer/src/StaticSite/FontMaterialization/FontMaterializationPlanBuilder.php b/php-transformer/src/StaticSite/FontMaterialization/FontMaterializationPlanBuilder.php index 8a0ba9e0..503115be 100644 --- a/php-transformer/src/StaticSite/FontMaterialization/FontMaterializationPlanBuilder.php +++ b/php-transformer/src/StaticSite/FontMaterialization/FontMaterializationPlanBuilder.php @@ -304,7 +304,7 @@ private function primaryFamily(string $declaration): string * passes resolve variables whose values reference other variables. Leaves * unresolved references intact so they can be filtered as invalid families. */ - private function resolveCssVariables(string $css): string + public function resolveCssVariables(string $css): string { if ( '' === trim($css) || ! str_contains($css, 'var(') ) { return $css; diff --git a/php-transformer/tests/contract/run.php b/php-transformer/tests/contract/run.php index 81ab0f75..05162924 100644 --- a/php-transformer/tests/contract/run.php +++ b/php-transformer/tests/contract/run.php @@ -560,10 +560,42 @@ public function match(DOMElement $element, PatternContext $context): ?array $linkedLogoSerialized = (string) ($linkedLogoResult['serialized_blocks'] ?? ''); $assert('core/paragraph' === ($linkedLogoBlock['blockName'] ?? ''), 'linked logo text converts to a paragraph block'); $assert(! array_key_exists('content', is_array($linkedLogoBlock['attrs'] ?? null) ? $linkedLogoBlock['attrs'] : array()), 'paragraph source content is not serialized as a block comment attribute'); -$assert(str_contains($linkedLogoSerialized, ''), 'linked logo paragraph preserves anchor markup in saved HTML'); +$assert(str_contains($linkedLogoSerialized, ''), 'linked logo paragraph hoists link styling hooks to the paragraph wrapper and keeps valid anchor markup'); +$assert(! str_contains($linkedLogoSerialized, '
' +)->toArray(); +$paragraphSvgBlock = $paragraphSvgResult['blocks'][0] ?? array(); +$paragraphSvgSerialized = (string) ($paragraphSvgResult['serialized_blocks'] ?? ''); +$assert('core/html' === ($paragraphSvgBlock['blockName'] ?? ''), 'paragraph content with inline SVG falls back to core/html instead of invalid RichText'); +$assert(str_contains($paragraphSvgSerialized, '.*/s', $paragraphSvgSerialized), 'paragraph inline SVG is not stored inside core/paragraph RichText'); + +$coffeeHtml = (string) file_get_contents(dirname(__DIR__, 3) . '/fixtures/websites/2-onepager-coffee/index.html'); +$coffeeResult = ( new HtmlTransformer() )->transform($coffeeHtml, array())->toArray(); +$coffeeSerialized = (string) ($coffeeResult['serialized_blocks'] ?? ''); +$coffeeRiskCount = 0; +if ( preg_match_all('/(.*?)/s', $coffeeSerialized, $coffeeBlocks, PREG_SET_ORDER) ) { + foreach ( $coffeeBlocks as $coffeeBlock ) { + if ( preg_match('/<(?:span|a)\b[^>]*(?:class|style)=| 'core/button', @@ -787,6 +819,21 @@ public function match(DOMElement $element, PatternContext $context): ?array $assert(5 === ($dropdownHeaderBlockMenu['item_count'] ?? null), 'dropdown header nav counts parent and submenu items consistently'); $assert('Day Hike' === ($dropdownHeaderBlockMenu['items'][2]['label'] ?? ''), 'dropdown header nav preserves submenu item labels'); +$nestedNavMenu = ( new HtmlTransformer() )->transform( + '' +)->toArray(); +$nestedNavMenuSerialized = (string) ($nestedNavMenu['serialized_blocks'] ?? ''); +$nestedNavMenuParity = $nestedNavMenu['source_reports']['semantic_parity'] ?? array(); +$nestedNavMenuBlock = $nestedNavMenuParity['navigation_menus']['blocks'][0] ?? array(); +$assert('pass' === ($nestedNavMenu['source_reports']['wp_block_validity']['status'] ?? ''), 'nested nav/menu serializes to valid WordPress navigation blocks'); +$assert(str_contains($nestedNavMenuSerialized, '" }, + { "path": "serialized_blocks", "assert": "contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "shift-card" }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, diff --git a/php-transformer/tests/fixtures/parity/html-anchor-inline-patterns.json b/php-transformer/tests/fixtures/parity/html-anchor-inline-patterns.json index 8f3f65e0..d8870d26 100644 --- a/php-transformer/tests/fixtures/parity/html-anchor-inline-patterns.json +++ b/php-transformer/tests/fixtures/parity/html-anchor-inline-patterns.json @@ -25,7 +25,7 @@ { "path": "blocks", "assert": "count", "count": 2 }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, - { "path": "serialized_blocks", "assert": "contains", "value": "
" }, + { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" } ] diff --git a/php-transformer/tests/fixtures/parity/html-explicit-grid-class-non-card-children.json b/php-transformer/tests/fixtures/parity/html-explicit-grid-class-non-card-children.json index 9e2d28fa..593bfba3 100644 --- a/php-transformer/tests/fixtures/parity/html-explicit-grid-class-non-card-children.json +++ b/php-transformer/tests/fixtures/parity/html-explicit-grid-class-non-card-children.json @@ -30,6 +30,7 @@ { "path": "blocks", "assert": "count", "count": 1 }, { "path": "blocks.0.innerBlocks.0.innerBlocks", "assert": "count", "count": 3 }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "\"className\":\"reveal reveal-delay-1\"" }, { "path": "serialized_blocks", "assert": "contains", "value": "" } ] diff --git a/php-transformer/tests/fixtures/parity/html-group-wrapper-canonical-save-shape.json b/php-transformer/tests/fixtures/parity/html-group-wrapper-canonical-save-shape.json index 5cce98b6..d622a471 100644 --- a/php-transformer/tests/fixtures/parity/html-group-wrapper-canonical-save-shape.json +++ b/php-transformer/tests/fixtures/parity/html-group-wrapper-canonical-save-shape.json @@ -22,7 +22,7 @@ "expect": [ { "path": "status", "assert": "equals", "value": "success" }, { "path": "source_reports.wp_block_validity.status", "assert": "equals", "value": "pass" }, - { "path": "serialized_blocks", "assert": "contains", "value": "
" }, + { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "id=\"foo\" class=\"wp-block-group grid-3 custom-x\" id=" }, { "path": "fallbacks", "assert": "count", "count": 0 } ] diff --git a/php-transformer/tests/fixtures/parity/html-logo-nav-button-classification.json b/php-transformer/tests/fixtures/parity/html-logo-nav-button-classification.json index 558cbf04..ef822a9e 100644 --- a/php-transformer/tests/fixtures/parity/html-logo-nav-button-classification.json +++ b/php-transformer/tests/fixtures/parity/html-logo-nav-button-classification.json @@ -17,7 +17,7 @@ }, "expected_blocks": [ { "path": "blocks.0", "name": "core/group", "attrs": { "className": "site-header" } }, - { "path": "blocks.0.innerBlocks.0", "name": "core/paragraph" }, + { "path": "blocks.0.innerBlocks.0", "name": "core/html" }, { "path": "blocks.0.innerBlocks.1", "name": "core/navigation", "attrs": { "className": "primary-nav" } }, { "path": "blocks.0.innerBlocks.1.innerBlocks.0", "name": "core/navigation-link", "attrs": { "url": "/docs", "kind": "custom" } }, { "path": "blocks.0.innerBlocks.1.innerBlocks.1", "name": "core/navigation-link", "attrs": { "url": "/pricing", "kind": "custom" } }, diff --git a/php-transformer/tests/fixtures/parity/html-single-child-flex-svg-address.json b/php-transformer/tests/fixtures/parity/html-single-child-flex-svg-address.json index 644e40a6..4b3e6947 100644 --- a/php-transformer/tests/fixtures/parity/html-single-child-flex-svg-address.json +++ b/php-transformer/tests/fixtures/parity/html-single-child-flex-svg-address.json @@ -17,7 +17,7 @@ }, "expected_blocks": [ { "path": "blocks.0", "name": "core/group" }, - { "path": "blocks.0.innerBlocks.0", "name": "core/group", "attrs": { "className": "illustration-frame", "layout": { "type": "flex" } } }, + { "path": "blocks.0.innerBlocks.0", "name": "core/group", "attrs": { "className": "illustration-frame", "layout": { "type": "flex", "justifyContent": "center" } } }, { "path": "blocks.0.innerBlocks.0.innerBlocks.0", "name": "core/html" }, { "path": "blocks.0.innerBlocks.1", "name": "core/paragraph", "attrs": { "className": "contact-card", "content": "214 Maple Street
Benton Harbor, MI
(269) 555-0193" } } ], diff --git a/php-transformer/tests/fixtures/parity/html-single-child-flex-svg.json b/php-transformer/tests/fixtures/parity/html-single-child-flex-svg.json index 835c6800..cc8bcab3 100644 --- a/php-transformer/tests/fixtures/parity/html-single-child-flex-svg.json +++ b/php-transformer/tests/fixtures/parity/html-single-child-flex-svg.json @@ -16,7 +16,7 @@ "content": "
GIRTH
" }, "expected_blocks": [ - { "path": "blocks.0", "name": "core/group", "attrs": { "layout": { "type": "flex" } } }, + { "path": "blocks.0", "name": "core/group", "attrs": { "layout": { "type": "flex", "justifyContent": "center" } } }, { "path": "blocks.0.innerBlocks.0", "name": "core/html" } ], "expected_fallbacks": [], diff --git a/php-transformer/tests/fixtures/parity/html-vertical-flex-column-becomes-group.json b/php-transformer/tests/fixtures/parity/html-vertical-flex-column-becomes-group.json index bb0c8352..5d65a8d5 100644 --- a/php-transformer/tests/fixtures/parity/html-vertical-flex-column-becomes-group.json +++ b/php-transformer/tests/fixtures/parity/html-vertical-flex-column-becomes-group.json @@ -28,6 +28,7 @@ { "path": "blocks", "assert": "count", "count": 1 }, { "path": "blocks.0.innerBlocks", "assert": "count", "count": 4 }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, - { "path": "serialized_blocks", "assert": "contains", "value": "
" }, + { "path": "serialized_blocks", "assert": "contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "shift-card" }, { "path": "serialized_blocks", "assert": "contains", "value": "" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, diff --git a/php-transformer/tests/unit/block-style-support-conversion.php b/php-transformer/tests/unit/block-style-support-conversion.php index 6e475ee5..cafc1334 100644 --- a/php-transformer/tests/unit/block-style-support-conversion.php +++ b/php-transformer/tests/unit/block-style-support-conversion.php @@ -51,7 +51,7 @@ $assert('center' === ($groupAttrs['layout']['justifyContent'] ?? ''), '10: group flex justify-content is normalized to layout attr', json_encode($groupAttrs['layout'] ?? array())); $assert(str_contains($groupInnerHtml, 'has-base-background-color has-background'), '11: rendered wrapper uses preset color classes', $groupInnerHtml); $assert(str_contains($groupInnerHtml, 'is-layout-flex wp-block-columns-is-layout-flex'), '12: rendered wrapper uses layout support classes', $groupInnerHtml); -$assert(str_contains($groupInnerHtml, 'gap:1rem'), '13: rendered wrapper keeps supported gap only via blockGap serialization', $groupInnerHtml); +$assert(! str_contains($groupInnerHtml, 'gap:1rem'), '13: rendered wrapper omits blockGap when the core save shape does not reproduce it', $groupInnerHtml); $assert(! str_contains($groupInnerHtml, 'display:flex') && ! str_contains($groupInnerHtml, 'justify-content:center'), '14: rendered wrapper does not carry raw flex declarations', $groupInnerHtml); if ( $failures > 0 ) { From aae02f7f545682035ed2460ab9e076c700c5a51f Mon Sep 17 00:00:00 2001 From: Chris Huber Date: Thu, 2 Jul 2026 23:41:09 -0400 Subject: [PATCH 3/8] Preserve business hours and contact link structure --- .../src/HtmlToBlocks/HtmlTransformer.php | 34 +++++++++++++++---- .../Patterns/NavigationPattern.php | 23 ++++++++++++- .../html-business-hours-label-value-rows.json | 33 ++++++++++++++++++ .../html-contact-links-not-navigation.json | 31 +++++++++++++++++ .../parity/html-inline-content-wrapper.json | 4 ++- 5 files changed, 117 insertions(+), 8 deletions(-) create mode 100644 php-transformer/tests/fixtures/parity/html-business-hours-label-value-rows.json create mode 100644 php-transformer/tests/fixtures/parity/html-contact-links-not-navigation.json diff --git a/php-transformer/src/HtmlToBlocks/HtmlTransformer.php b/php-transformer/src/HtmlToBlocks/HtmlTransformer.php index 689080e1..dc48242e 100644 --- a/php-transformer/src/HtmlToBlocks/HtmlTransformer.php +++ b/php-transformer/src/HtmlToBlocks/HtmlTransformer.php @@ -5468,16 +5468,18 @@ private function namePriceChildren(DOMElement $element): ?array $second = $children[1]; $firstIsPrice = $this->isPriceElement($first); $secondIsPrice = $this->isPriceElement($second); - if ( $firstIsPrice === $secondIsPrice ) { - return null; + if ( $firstIsPrice !== $secondIsPrice ) { + $other = $firstIsPrice ? $second : $first; + if ( $this->isNameElement($other) || $this->hasCommerceToken($element, array( 'menu', 'product', 'pricing', 'price', 'plan', 'tier', 'dish', 'item', 'row' )) ) { + return $children; + } } - $other = $firstIsPrice ? $second : $first; - if ( ! $this->isNameElement($other) && ! $this->hasCommerceToken($element, array( 'menu', 'product', 'pricing', 'price', 'plan', 'tier', 'dish', 'item', 'row' )) ) { - return null; + if ( $this->looksLikeHoursRow($element, $first, $second) ) { + return $children; } - return $children; + return null; } private function isInlineCommerceRowChild(DOMElement $element): bool @@ -5500,6 +5502,26 @@ private function isNameElement(DOMElement $element): bool return $this->hasCommerceToken($element, array( 'name', 'title', 'product', 'dish', 'item', 'plan', 'tier' )) || preg_match('/^h[1-6]$/', strtolower($element->tagName)); } + private function looksLikeHoursRow(DOMElement $row, DOMElement $first, DOMElement $second): bool + { + if ( ! $this->hasCommerceToken($row, array( 'hours', 'hour', 'schedule', 'time', 'row' )) ) { + return false; + } + + return ( $this->isDayElement($first) && $this->isTimeValueElement($second) ) + || ( $this->isDayElement($second) && $this->isTimeValueElement($first) ); + } + + private function isDayElement(DOMElement $element): bool + { + return $this->hasCommerceToken($element, array( 'day', 'date', 'label' )) || (bool) preg_match('/\b(?:mon(?:day)?|tue(?:sday)?|wed(?:nesday)?|thu(?:rsday)?|fri(?:day)?|sat(?:urday)?|sun(?:day)?|weekdays?|weekends?)\b/i', $element->textContent ?? ''); + } + + private function isTimeValueElement(DOMElement $element): bool + { + return $this->hasCommerceToken($element, array( 'time', 'hours', 'value', 'closed' )) || (bool) preg_match('/\b(?:closed|open|\d{1,2}(?::\d{2})?\s*(?:am|pm)?\s*(?:[\x{2013}\x{2014}-]|to)\s*\d{1,2}(?::\d{2})?\s*(?:am|pm)?)\b/iu', $element->textContent ?? ''); + } + /** * @return array|null */ diff --git a/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php b/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php index 8eb1af74..16b0095f 100644 --- a/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php +++ b/php-transformer/src/HtmlToBlocks/Patterns/NavigationPattern.php @@ -581,7 +581,10 @@ private function hasNavigationSignal(DOMElement $element): bool foreach ( array( 'class', 'id' ) as $attribute ) { $value = $element->hasAttribute($attribute) ? $element->getAttribute($attribute) : ''; foreach ( preg_split('/[^a-z0-9]+/', strtolower($value)) ?: array() as $token ) { - if ( in_array($token, array( 'nav', 'navbar', 'navigation', 'menu', 'links' ), true) ) { + if ( in_array($token, array( 'nav', 'navbar', 'navigation', 'menu' ), true) ) { + return true; + } + if ( 'links' === $token && ! $this->isContactLinkCluster($element) ) { return true; } } @@ -590,6 +593,24 @@ private function hasNavigationSignal(DOMElement $element): bool return false; } + private function isContactLinkCluster(DOMElement $element): bool + { + $anchors = array(); + $this->collectAnchorsExcluding($element, $anchors, array()); + if ( array() === $anchors ) { + return false; + } + + foreach ( $anchors as $anchor ) { + $href = strtolower(trim($anchor->hasAttribute('href') ? $anchor->getAttribute('href') : '')); + if ( ! preg_match('/^(?:tel|mailto|sms):/', $href) ) { + return false; + } + } + + return true; + } + private function hasDirectListNavigationSignal(DOMElement $element): bool { foreach ( $element->childNodes as $child ) { diff --git a/php-transformer/tests/fixtures/parity/html-business-hours-label-value-rows.json b/php-transformer/tests/fixtures/parity/html-business-hours-label-value-rows.json new file mode 100644 index 00000000..3b5582b6 --- /dev/null +++ b/php-transformer/tests/fixtures/parity/html-business-hours-label-value-rows.json @@ -0,0 +1,33 @@ +{ + "schema": "blocks-engine/php-transformer/parity-fixture/v1", + "name": "html-business-hours-label-value-rows", + "description": "Preserves business-hours rows as editable label/value columns instead of flattening day and time text.", + "source_reference": { + "repo": "php-transformer", + "path": "tests/fixtures/parity/html-business-hours-label-value-rows.json", + "notes": "Generic local-business hours coverage." + }, + "legacy_comparison": { + "skip": true, + "reason": "This upstream primitive fixture has no downstream legacy comparison." + }, + "operation": "html_transformer.transform", + "input": { + "content": "
Hours
MondayClosed
Tuesday – Thursday5:00 – 10:00 pm
" + }, + "expected_blocks": [ + { "path": "blocks.0", "name": "core/group", "attrs": { "className": "hours-col" } }, + { "path": "blocks.0.innerBlocks.1", "name": "core/columns", "attrs": { "className": "hours-row" } }, + { "path": "blocks.0.innerBlocks.1.innerBlocks.0", "name": "core/column", "attrs": { "className": "hours-day" } }, + { "path": "blocks.0.innerBlocks.1.innerBlocks.1", "name": "core/column", "attrs": { "className": "hours-time closed" } }, + { "path": "blocks.0.innerBlocks.2", "name": "core/columns", "attrs": { "className": "hours-row" } } + ], + "expected_fallbacks": [], + "expect": [ + { "path": "status", "assert": "equals", "value": "success" }, + { "path": "serialized_blocks", "assert": "contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

Monday

" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

Closed

" }, + { "path": "serialized_blocks", "assert": "not_contains", "value": "Monday\n" } + ] +} diff --git a/php-transformer/tests/fixtures/parity/html-contact-links-not-navigation.json b/php-transformer/tests/fixtures/parity/html-contact-links-not-navigation.json new file mode 100644 index 00000000..8e804c8d --- /dev/null +++ b/php-transformer/tests/fixtures/parity/html-contact-links-not-navigation.json @@ -0,0 +1,31 @@ +{ + "schema": "blocks-engine/php-transformer/parity-fixture/v1", + "name": "html-contact-links-not-navigation", + "description": "Keeps tel/mail contact link clusters as content instead of site navigation.", + "source_reference": { + "repo": "php-transformer", + "path": "tests/fixtures/parity/html-contact-links-not-navigation.json", + "notes": "Generic contact details coverage for local-business imports." + }, + "legacy_comparison": { + "skip": true, + "reason": "This upstream primitive fixture has no downstream legacy comparison." + }, + "operation": "html_transformer.transform", + "input": { + "content": "
(503) 841-7220hello@example.com
" + }, + "expected_blocks": [ + { "path": "blocks.0", "name": "core/buttons", "attrs": { "className": "visit-links" } }, + { "path": "blocks.0.innerBlocks.0", "name": "core/button", "attrs": { "text": "(503) 841-7220", "url": "tel:+15038417220" } }, + { "path": "blocks.0.innerBlocks.1", "name": "core/button", "attrs": { "text": "hello@example.com", "url": "mailto:hello@example.com" } } + ], + "expected_fallbacks": [], + "expect": [ + { "path": "status", "assert": "equals", "value": "success" }, + { "path": "serialized_blocks", "assert": "not_contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

Opening keynote

" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

Location

" }, + { "path": "serialized_blocks", "assert": "contains", "value": "

Main Hall

" }, + { "path": "serialized_blocks", "assert": "not_contains", "value": "10:00 AM\n" }, + { "path": "fallbacks", "assert": "count", "count": 0 } + ] +} From 41c1b4ec1d8c436ce770144f0451f3eabf61ce5b Mon Sep 17 00:00:00 2001 From: Chris Huber Date: Fri, 3 Jul 2026 08:21:14 -0400 Subject: [PATCH 7/8] Omit unsupported button runtime attributes --- .../src/HtmlToBlocks/BlockFactory.php | 7 +--- .../HtmlToBlocks/Patterns/ButtonsPattern.php | 15 ++----- php-transformer/tests/contract/run.php | 4 +- ...time-attrs-omitted-from-native-button.json | 39 +++++++++++++++++++ 4 files changed, 45 insertions(+), 20 deletions(-) create mode 100644 php-transformer/tests/fixtures/parity/html-button-runtime-attrs-omitted-from-native-button.json diff --git a/php-transformer/src/HtmlToBlocks/BlockFactory.php b/php-transformer/src/HtmlToBlocks/BlockFactory.php index 250bd29e..6cebb9b8 100644 --- a/php-transformer/src/HtmlToBlocks/BlockFactory.php +++ b/php-transformer/src/HtmlToBlocks/BlockFactory.php @@ -256,12 +256,7 @@ private function blockHtml(string $name, array $attrs, array $innerBlocks): stri ); if ( 'button' === ($attrs['tagName'] ?? '') ) { - $buttonAttrs = array_intersect_key($attrs, array_flip(array( 'type', 'role', 'aria-label', 'aria-controls', 'aria-expanded', 'aria-haspopup' ))); - foreach ( $attrs as $attrName => $attrValue ) { - if ( is_string($attrName) && str_starts_with(strtolower($attrName), 'data-') ) { - $buttonAttrs[$attrName] = (string) $attrValue; - } - } + $buttonAttrs = array_intersect_key($attrs, array_flip(array( 'type' ))); $buttonAttrs = array_merge(array( 'class' => $this->mergeClassNames('wp-block-button__link', $support['classes'], 'wp-element-button'), 'style' => $support['style'], diff --git a/php-transformer/src/HtmlToBlocks/Patterns/ButtonsPattern.php b/php-transformer/src/HtmlToBlocks/Patterns/ButtonsPattern.php index d03a52d5..083f7fcf 100644 --- a/php-transformer/src/HtmlToBlocks/Patterns/ButtonsPattern.php +++ b/php-transformer/src/HtmlToBlocks/Patterns/ButtonsPattern.php @@ -229,20 +229,11 @@ private function buttonPresentationAttributes(DOMElement $element, callable $pre */ private function buttonRuntimeAttributes(DOMElement $button): array { - $attrs = array(); - foreach ( array( 'type', 'role', 'aria-label', 'aria-controls', 'aria-expanded', 'aria-haspopup' ) as $name ) { - if ( $button->hasAttribute($name) ) { - $attrs[$name] = $button->getAttribute($name); - } + if ( ! $button->hasAttribute('type') ) { + return array(); } - foreach ( $button->attributes ?? array() as $attribute ) { - if ( str_starts_with(strtolower($attribute->nodeName), 'data-') ) { - $attrs[$attribute->nodeName] = $attribute->nodeValue ?? ''; - } - } - - return $attrs; + return array( 'type' => $button->getAttribute('type') ); } private function hasOutlineSignal(DOMElement $element, string $style): bool diff --git a/php-transformer/tests/contract/run.php b/php-transformer/tests/contract/run.php index 05162924..2e7c20f8 100644 --- a/php-transformer/tests/contract/run.php +++ b/php-transformer/tests/contract/run.php @@ -888,7 +888,7 @@ public function match(DOMElement $element, PatternContext $context): ?array $labeledButtonsSerialized = (string) ($labeledButtons['serialized_blocks'] ?? ''); $assert(str_contains($labeledButtonsSerialized, '" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#ffffff;background-color:#0a66c2;border-radius:6px;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-radius:6px;color:#ffffff;background-color:#0a66c2;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "wp:paragraph" } ] } diff --git a/php-transformer/tests/fixtures/parity/html-button-outline-ghost-cta-style.json b/php-transformer/tests/fixtures/parity/html-button-outline-ghost-cta-style.json index 14dfed72..c98b061c 100644 --- a/php-transformer/tests/fixtures/parity/html-button-outline-ghost-cta-style.json +++ b/php-transformer/tests/fixtures/parity/html-button-outline-ghost-cta-style.json @@ -24,6 +24,6 @@ { "path": "status", "assert": "equals", "value": "success" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link has-text-color has-background has-border-color wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#135e96;background-color:transparent;border-color:currentColor;border-width:2px;border-style:solid;border-radius:8px;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px;font-weight:600;text-transform:none\"" } + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-color:currentColor;border-style:solid;border-width:2px;border-radius:8px;color:#135e96;background-color:transparent;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px;font-weight:600;text-transform:none\"" } ] } diff --git a/php-transformer/tests/fixtures/parity/html-button-runtime-attrs-omitted-from-native-button.json b/php-transformer/tests/fixtures/parity/html-button-runtime-attrs-omitted-from-native-button.json index 201ccb4b..fc78e8e3 100644 --- a/php-transformer/tests/fixtures/parity/html-button-runtime-attrs-omitted-from-native-button.json +++ b/php-transformer/tests/fixtures/parity/html-button-runtime-attrs-omitted-from-native-button.json @@ -29,7 +29,7 @@ ], "expect": [ { "path": "status", "assert": "equals", "value": "success" }, - { "path": "serialized_blocks", "assert": "contains", "value": "" }, + { "path": "serialized_blocks", "assert": "contains", "value": "" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "data-amount" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "aria-label" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "aria-controls" }, diff --git a/php-transformer/tests/fixtures/parity/html-button-style-fidelity-filled-from-css.json b/php-transformer/tests/fixtures/parity/html-button-style-fidelity-filled-from-css.json index 35d40d1b..6449a502 100644 --- a/php-transformer/tests/fixtures/parity/html-button-style-fidelity-filled-from-css.json +++ b/php-transformer/tests/fixtures/parity/html-button-style-fidelity-filled-from-css.json @@ -24,7 +24,7 @@ { "path": "status", "assert": "equals", "value": "success" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link has-text-color has-background wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#ffffff;background-color:#13314f;border-radius:6px;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-radius:6px;color:#ffffff;background-color:#13314f;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "is-style-outline" } ] } diff --git a/php-transformer/tests/fixtures/parity/html-button-style-fidelity-outline-from-css.json b/php-transformer/tests/fixtures/parity/html-button-style-fidelity-outline-from-css.json index fa28047f..c506421c 100644 --- a/php-transformer/tests/fixtures/parity/html-button-style-fidelity-outline-from-css.json +++ b/php-transformer/tests/fixtures/parity/html-button-style-fidelity-outline-from-css.json @@ -24,6 +24,6 @@ { "path": "status", "assert": "equals", "value": "success" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link has-text-color has-background has-border-color wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#135e96;background-color:transparent;border-color:#135e96;border-width:2px;border-style:solid;border-radius:8px;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" } + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-color:#135e96;border-style:solid;border-width:2px;border-radius:8px;color:#135e96;background-color:transparent;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" } ] } diff --git a/php-transformer/tests/fixtures/parity/html-cta-container-static-css-button-style-signals.json b/php-transformer/tests/fixtures/parity/html-cta-container-static-css-button-style-signals.json index cc844f27..a490a1c9 100644 --- a/php-transformer/tests/fixtures/parity/html-cta-container-static-css-button-style-signals.json +++ b/php-transformer/tests/fixtures/parity/html-cta-container-static-css-button-style-signals.json @@ -25,8 +25,8 @@ { "path": "status", "assert": "equals", "value": "success" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link has-text-color has-background has-border-color wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#fff;background-color:#2563eb;border-color:#2563eb;border-width:2px;border-style:solid;border-radius:999px;padding-top:14px;padding-right:28px;padding-bottom:14px;padding-left:28px;font-weight:700\"" }, + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-color:#2563eb;border-style:solid;border-width:2px;border-radius:999px;color:#fff;background-color:#2563eb;padding-top:14px;padding-right:28px;padding-bottom:14px;padding-left:28px;font-weight:700\"" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#2563eb;background-color:transparent;border-color:currentColor;border-width:2px;border-style:solid;border-radius:999px;padding-top:14px;padding-right:28px;padding-bottom:14px;padding-left:28px;font-weight:700\"" } + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-color:currentColor;border-style:solid;border-width:2px;border-radius:999px;color:#2563eb;background-color:transparent;padding-top:14px;padding-right:28px;padding-bottom:14px;padding-left:28px;font-weight:700\"" } ] } diff --git a/php-transformer/tests/fixtures/parity/html-pseudo-state-rules-not-inlined-resting.json b/php-transformer/tests/fixtures/parity/html-pseudo-state-rules-not-inlined-resting.json index 1d01037a..e9530bac 100644 --- a/php-transformer/tests/fixtures/parity/html-pseudo-state-rules-not-inlined-resting.json +++ b/php-transformer/tests/fixtures/parity/html-pseudo-state-rules-not-inlined-resting.json @@ -25,7 +25,7 @@ "expected_fallbacks": [], "expect": [ { "path": "status", "assert": "equals", "value": "success" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#ffffff;background-color:#13314f;border-radius:6px;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-radius:6px;color:#ffffff;background-color:#13314f;padding-top:12px;padding-right:24px;padding-bottom:12px;padding-left:24px\"" }, { "path": "serialized_blocks", "assert": "contains", "value": "style=\"background-color:#101418;padding-top:40px;padding-right:36px;padding-bottom:40px;padding-left:36px\"" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "#f0ac22" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "border-radius:2px" }, diff --git a/php-transformer/tests/fixtures/parity/html-source-styled-button-preserves-style.json b/php-transformer/tests/fixtures/parity/html-source-styled-button-preserves-style.json index 7ec12374..ae021683 100644 --- a/php-transformer/tests/fixtures/parity/html-source-styled-button-preserves-style.json +++ b/php-transformer/tests/fixtures/parity/html-source-styled-button-preserves-style.json @@ -24,7 +24,7 @@ { "path": "status", "assert": "equals", "value": "success" }, { "path": "serialized_blocks", "assert": "contains", "value": "
" }, { "path": "serialized_blocks", "assert": "contains", "value": "class=\"wp-block-button__link has-text-color has-background wp-element-button\"" }, - { "path": "serialized_blocks", "assert": "contains", "value": "style=\"color:#f9fafb;background-color:#111827;border-radius:6px;padding-top:10px;padding-right:20px;padding-bottom:10px;padding-left:20px;font-weight:800;text-transform:uppercase\"" }, + { "path": "serialized_blocks", "assert": "contains", "value": "style=\"border-radius:6px;color:#f9fafb;background-color:#111827;padding-top:10px;padding-right:20px;padding-bottom:10px;padding-left:20px;font-weight:800;text-transform:uppercase\"" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "background-color:#f7f7f7" }, { "path": "serialized_blocks", "assert": "not_contains", "value": "border-width" } ]