Skip to content

VIP: Enable co-authors plus filter that disabled the querying by post_author on VIP Go#653

Closed
shantanu2704 wants to merge 392 commits into
Automattic:developfrom
shantanu2704:VIP/enable-coauthors_plus_should_query_post_author-on-VIP-Go
Closed

VIP: Enable co-authors plus filter that disabled the querying by post_author on VIP Go#653
shantanu2704 wants to merge 392 commits into
Automattic:developfrom
shantanu2704:VIP/enable-coauthors_plus_should_query_post_author-on-VIP-Go

Conversation

@shantanu2704

Copy link
Copy Markdown
Contributor

This speeds up the SQL query. This filter has been enabled on WordPress.com VIP. This filter is active on WordPress.com VIP but not on VIP Go.

We'd need to run the backfill CLI before this can be merged in.

Rebecca Hum and others added 30 commits September 8, 2017 13:18
…_list_authors

remove duplicates from linked accounts on coauthors_wp_list_authors()
…uthors

coauthors_wp_list_authors() has option to list only guest authors now
Remove associated guest user when mapped user id deleted.
user_login spaces problem when using add_coauthors
- Use simple tax queries for CAP to improve performance
- Detail of filter to add to theme
- Adding CLI command to run
Adding details of filter for slow performance
Since we made CAP consistent with core in it's handling of author archives where there are no posts (see Automattic#425) we no longer expect there to be a 404 response on the author archive for a guest author.
…table

Guest Author Counts are more accurate
rebeccahum and others added 16 commits December 7, 2018 12:01
Revert "BUGFIX regular expression in posts_where_filter()"
SQL Error from Regex in WHERE Clause
This is a pretty big hack :) It would be better to remove the inputs completely rather than hiding them (via javascript or hooking directly into Gutenberg) but this is a good start.
Merge 3.3.1 release for Gutenberg compatibility to master
…l-filter-get_coauthors-1

# Conflicts:
#	template-tags.php
…_coauthors-1

Add filter to get_coauthors
…_author on VIP Go

This speeds up the SQL query. This filter has been enabled on WordPress.com VIP. This filter is active on WordPress.com VIP
but not on VIP Go.
@GaryJones

Copy link
Copy Markdown
Contributor

@shantanu2704 Is this still needed for VIP?

@GaryJones GaryJones added the status: awaiting reporter feedback Awaiting feedback from reporter label Jul 27, 2023
@shantanu2704

Copy link
Copy Markdown
Contributor Author

I don't know, @GaryJones :(
I'm looking back at VIP Intern Shantanu in disappointment for not including any further details.
Thanks to GitHub, here's some more context around why we considered adding this filter.

@GaryJones GaryJones added this to the Future milestone Jul 28, 2023
@GaryJones GaryJones added status: needs investigation Needs further investigation and removed status: awaiting reporter feedback Awaiting feedback from reporter labels Jul 28, 2023
@GaryJones

Copy link
Copy Markdown
Contributor

Adding to a future milestone to investigate later on. @shantanu2704 Do you fancy checking to see if the query by post_author is coming up as slow / needed any more?

@GaryJones GaryJones changed the base branch from main to develop August 25, 2023 15:23
@GaryJones GaryJones removed this from the Future milestone Apr 22, 2026
@GaryJones

Copy link
Copy Markdown
Contributor

Thank you for this, @shantanu2704, and apologies that it sat open for so long.

The behaviour you were after — being able to disable querying by post_author on VIP — is now available on develop through the coauthors_plus_should_query_post_author filter, which gates exactly that path. Between that and several years of changes to the query and helper layout, this branch has drifted well past a clean rebase (it also bundles some VIP/Travis/README artefacts that no longer fit the current repo).

Rather than leave it lingering, we're going to close it out — but the underlying need is covered by the filter on develop. Thanks again for the contribution; it helped inform where we ended up.

@GaryJones GaryJones closed this Jun 22, 2026
@shantanu2704

Copy link
Copy Markdown
Contributor Author

Thanks for closing the loop on this, @GaryJones !

@GaryJones GaryJones removed the status: needs investigation Needs further investigation label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.